Skip to contentSkip to conversation

radeonfb i2c regression post-2.6.18.

DISCUSSION Benjamin Herrenschmidt 4 participants 14 messages Nov 18, 2007 – Nov 24, 2007 Framebuffer layer

lore
Share & tools
lore
#0 lore raw
Quoted 7 lines · Roger Leigh

Hi folks,

I'm using an Apple Cinema Display connected via DVI to an Apple Mac Mini with Radeon 9200 graphics. This used to work fine, but with kernels >= 2.6.19, the monitor powers off as soon as the framebuffer is initialised, making for a less than usable system. I've tested with 2.6.(19|2[012]), and I didn't see any related changes in 2.6.23.

.../...

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

(Also, Michel, can you check if it fixes your other problem with this code ? ie. your "hot crash")

Cheers,
Ben.

-------- Forwarded Message --------
From: Jean Delvare <[email protected]>
To: [email protected]
Cc: Benjamin Herrenschmidt <[email protected]>, Antonino Daplas <[email protected]>
Subject: [PATCH] fb_ddc: Fix DDC lines quirk
Date: Sun, 18 Nov 2007 14:21:41 +0100

The code in fb_ddc_read() is said to be based on the implementation of the radeon driver:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fc5891c8a3ba284f13994d7bc1f1bfa8283982de

However, comparing the old radeon driver code with the new fb_ddc code reveals some differences. Most notably, the I2C bus lines are held at the end of the function, while the original code was releasing them (as the comment above correctly says.)

There are a few other differences, which appear to be responsible for read failures on my system. While tracing low-level I2C code in i2c-algo-bit, I noticed that the initial attempt to read the EDID always failed. It takes one retry for the read to succeed. As we are about to remove this automatic retry property from i2c-algo-bit, reading the EDID would really fail.

As a summary, the I2C lines quirk which is supposedly needed to read EDID on some older monitors is currently breaking the (first) read on all other monitors (and might not even work with older ones - did anyone try since October 2006?)

After applying the patch below, which makes the code in fb_ddc_read() really similar to what the radeon driver used to have, the first EDID read succeeds again.

On top of that, as it appears that this code has been broken for one year now and nobody seems to have complained, I'm curious if it makes sense to keep this quirk in place. It makes the code more complex and slower just for the sake of monitors which I guess nobody uses anymore. Can't we just get rid of it?

---
 drivers/video/fb_ddc.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/video/fb_ddc.c +4 -4
@@ -56,13 +56,12 @@ unsigned char *fb_ddc_read(struct i2c_ad
 	int i, j;
 
 	algo_data->setscl(algo_data->data, 1);
-	algo_data->setscl(algo_data->data, 0);
 
 	for (i = 0; i < 3; i++) {
 		/* For some old monitors we need the
 		 * following process to initialize/stop DDC
 		 */
-		algo_data->setsda(algo_data->data, 0);
+		algo_data->setsda(algo_data->data, 1);
 		msleep(13);
 
 		algo_data->setscl(algo_data->data, 1);
@@ -97,14 +96,15 @@ unsigned char *fb_ddc_read(struct i2c_ad
 		algo_data->setsda(algo_data->data, 1);
 		msleep(15);
 		algo_data->setscl(algo_data->data, 0);
+		algo_data->setsda(algo_data->data, 0);
 		if (edid)
 			break;
 	}
 	/* Release the DDC lines when done or the Apple Cinema HD display
 	 * will switch off
 	 */
-	algo_data->setsda(algo_data->data, 0);
-	algo_data->setscl(algo_data->data, 0);
+	algo_data->setsda(algo_data->data, 1);
+	algo_data->setscl(algo_data->data, 1);
 
 	return edid;
 }
#1 lore raw
Quoted 9 lines · Benjamin Herrenschmidt
Quoted 7 lines · Roger Leigh

Hi folks,

I'm using an Apple Cinema Display connected via DVI to an Apple Mac Mini with Radeon 9200 graphics. This used to work fine, but with kernels >= 2.6.19, the monitor powers off as soon as the framebuffer is initialised, making for a less than usable system. I've tested with 2.6.(19|2[012]), and I didn't see any related changes in 2.6.23.

Quoted 5 lines
   .../...

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

This patch fixes the problem. The monitor stays powered on during the switch to the framebuffer.

Thanks,
Roger

Signature · 4 lines
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
#2 lore raw
Quoted 7 lines
Quoted 4 lines

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

This patch fixes the problem. The monitor stays powered on during the switch to the framebuffer.

Excellent ! That saves me having to test myself :-)

As far as I'm concerned, that's an Ack for the patch.

Ben.

#3 lore raw
Quoted 11 lines · On Wednesday 21 November 2007 20:58:09 Benjamin Herrenschmidt wrote:
Quoted 7 lines
Quoted 4 lines

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

This patch fixes the problem. The monitor stays powered on during the switch to the framebuffer.

Excellent ! That saves me having to test myself :-)

As far as I'm concerned, that's an Ack for the patch.

I'll test tomorrow if that also fixes my problem.
You'll hear from me.

Signature · 1 line
Greetings Michael.
#4 lore raw
Quoted 9 lines · Michael Buesch
Quoted 8 lines · On Wednesday 21 November 2007 20:58:09 Benjamin Herrenschmidt wrote:
Quoted 7 lines
Quoted 4 lines

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

This patch fixes the problem. The monitor stays powered on during the switch to the framebuffer.

Quoted 6 lines
Quoted 3 lines

Excellent ! That saves me having to test myself :-)

As far as I'm concerned, that's an Ack for the patch.

I'll test tomorrow if that also fixes my problem.
You'll hear from me.

Thanks Michael !

Cheers,
Ben.

#5 lore raw
In reply to Benjamin Herrenschmidt
Quoted 10 lines · Benjamin Herrenschmidt
Quoted 6 lines
Quoted 3 lines

Can you try the patch from Jean that I pasted below and let us know if it helps ? It looks like the releasing of the i2c lines may have been done backward.

This patch fixes the problem. The monitor stays powered on during the switch to the framebuffer.

Excellent ! That saves me having to test myself :-)

As far as I'm concerned, that's an Ack for the patch.

Fantastic, thanks! I've copied this to Debian bugs 433236 and 426124 which were about this problem.

BTW, the framebuffer penguin logo looked a little wierd (low number of colours, odd colours), though on my powerpc it has always looked odd (wrong colours). Could there be some endianness bug in the fblogo code? I'll check it with other video options when I next have a few minutes.

Thanks again,
Roger

Signature · 4 lines
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
#6 lore raw
Quoted 8 lines · Roger Leigh

Fantastic, thanks! I've copied this to Debian bugs 433236 and 426124 which were about this problem.

BTW, the framebuffer penguin logo looked a little wierd (low number of colours, odd colours), though on my powerpc it has always looked odd (wrong colours). Could there be some endianness bug in the fblogo code? I'll check it with other video options when I next have a few minutes.

Strange, it's always been working fine for me.

Ben.

#7 lore raw
In reply to Benjamin Herrenschmidt
Quoted 36 lines · On Monday 19 November 2007 00:16:06 Benjamin Herrenschmidt wrote:

(Also, Michel, can you check if it fixes your other problem with this code ? ie. your "hot crash")

-------- Forwarded Message --------
From: Jean Delvare <[email protected]>
To: [email protected]
Cc: Benjamin Herrenschmidt <[email protected]>, Antonino Daplas <[email protected]>
Subject: [PATCH] fb_ddc: Fix DDC lines quirk
Date: Sun, 18 Nov 2007 14:21:41 +0100

The code in fb_ddc_read() is said to be based on the implementation of the radeon driver:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fc5891c8a3ba284f13994d7bc1f1bfa8283982de

However, comparing the old radeon driver code with the new fb_ddc code reveals some differences. Most notably, the I2C bus lines are held at the end of the function, while the original code was releasing them (as the comment above correctly says.)

There are a few other differences, which appear to be responsible for read failures on my system. While tracing low-level I2C code in i2c-algo-bit, I noticed that the initial attempt to read the EDID always failed. It takes one retry for the read to succeed. As we are about to remove this automatic retry property from i2c-algo-bit, reading the EDID would really fail.

As a summary, the I2C lines quirk which is supposedly needed to read EDID on some older monitors is currently breaking the (first) read on all other monitors (and might not even work with older ones - did anyone try since October 2006?)

After applying the patch below, which makes the code in fb_ddc_read() really similar to what the radeon driver used to have, the first EDID read succeeds again.

Quoted 5 lines

On top of that, as it appears that this code has been broken for one year now and nobody seems to have complained, I'm curious if it makes sense to keep this quirk in place. It makes the code more complex and slower just for the sake of monitors which I guess nobody uses anymore. Can't we just get rid of it?

This patch fixes my crash problem.
Thanks a lot guys!

Quoted 1 line
Quoted 44 lines
---
 drivers/video/fb_ddc.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/video/fb_ddc.c +4 -4
@@ -56,13 +56,12 @@ unsigned char *fb_ddc_read(struct i2c_ad
 	int i, j;
 
 	algo_data->setscl(algo_data->data, 1);
-	algo_data->setscl(algo_data->data, 0);
 
 	for (i = 0; i < 3; i++) {
 		/* For some old monitors we need the
 		 * following process to initialize/stop DDC
 		 */
-		algo_data->setsda(algo_data->data, 0);
+		algo_data->setsda(algo_data->data, 1);
 		msleep(13);
 
 		algo_data->setscl(algo_data->data, 1);
@@ -97,14 +96,15 @@ unsigned char *fb_ddc_read(struct i2c_ad
 		algo_data->setsda(algo_data->data, 1);
 		msleep(15);
 		algo_data->setscl(algo_data->data, 0);
+		algo_data->setsda(algo_data->data, 0);
 		if (edid)
 			break;
 	}
 	/* Release the DDC lines when done or the Apple Cinema HD display
 	 * will switch off
 	 */
-	algo_data->setsda(algo_data->data, 0);
-	algo_data->setscl(algo_data->data, 0);
+	algo_data->setsda(algo_data->data, 1);
+	algo_data->setscl(algo_data->data, 1);
 
 	return edid;
 }
Signature · 1 line
Greetings Michael.
#8 lore raw
Quoted 1 line · Michael Buesch

This patch fixes my crash problem.

Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash.

Signature · 1 line
Jean Delvare
#9 lore raw
Quoted 5 lines · Jean Delvare
Quoted 1 line · Michael Buesch

This patch fixes my crash problem.

Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash.

Really sneaky... apparently, keeping the i2c lines asserted on his laptop model would drain enough current through the pullups (or the chip) that the temperature will raise significantly, causing a thermal shutdown if the machine was already warm.

A bit scary... looks to me that a pullup is a bit too weak somewhere on the motherboard.

That also means that this fix should reduce power consumption on the battery significantly on those machines as it must take quite a bit of power to increase the temperature that significantly (either that, or the heating part sits just next to the sensor).

Cheers,
Ben.

#10 lore raw
Quoted 13 lines · Benjamin Herrenschmidt
Quoted 5 lines · Jean Delvare
Quoted 1 line · Michael Buesch

This patch fixes my crash problem.

Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash.

Really sneaky... apparently, keeping the i2c lines asserted on his laptop model would drain enough current through the pullups (or the chip) that the temperature will raise significantly, causing a thermal shutdown if the machine was already warm.

Quoted 7 lines

A bit scary... looks to me that a pullup is a bit too weak somewhere on the motherboard.

That also means that this fix should reduce power consumption on the battery significantly on those machines as it must take quite a bit of power to increase the temperature that significantly (either that, or the heating part sits just next to the sensor).

Wow, nasty. Then my patch really needs to go to Linus at the earliest.

Thanks,

Signature · 1 line
Jean Delvare
#11 lore raw
In reply to Jean Delvare
Quoted 6 lines · On Friday 23 November 2007 23:29:28 Jean Delvare wrote:
Quoted 1 line · Michael Buesch

This patch fixes my crash problem.

Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash.

It's not the code that crashes. It's the hardware that turns off the machine. It only happens if I boot the machine and only if it's hot at this time. Some hardware will turn off the hardware two or three seconds after the radeon driver was loaded.
It seems to be some overheating protection that's going crazy.

Signature · 1 line
Greetings Michael.
#12 lore raw
Quoted 9 lines · Michael Buesch
Quoted 2 lines · On Friday 23 November 2007 23:29:28 Jean Delvare wrote:

Out of curiosity, what kind of crash was it? I admit that I can't see how the code could crash.

It's not the code that crashes. It's the hardware that turns off the machine. It only happens if I boot the machine and only if it's hot at this time. Some hardware will turn off the hardware two or three seconds after the radeon driver was loaded.
It seems to be some overheating protection that's going crazy.

Very strange indeed. Another possibility is that there is a hardware monitoring chip connected to one of the Radeon adapter's I2C buses, and that holding the I2C lines prevents reading from it, so whatever is responsible for controlling the temperature prefers to play it safe and shuts everything down. Somehow it seems more realistic than an actual overheating (3 seconds is a very short period of time for that), but we'd need the exact schematics of the hardware, and the details of the thermal control system, to validate this theory.

Anyway, no need to worry anymore now that the bug is fixed :)

Signature · 1 line
Jean Delvare
#13 lore raw
Quoted 11 lines

Very strange indeed. Another possibility is that there is a hardware monitoring chip connected to one of the Radeon adapter's I2C buses, and that holding the I2C lines prevents reading from it, so whatever is responsible for controlling the temperature prefers to play it safe and shuts everything down. Somehow it seems more realistic than an actual overheating (3 seconds is a very short period of time for that), but we'd need the exact schematics of the hardware, and the details of the thermal control system, to validate this theory.

Anyway, no need to worry anymore now that the bug is fixed :)

Actually, that's a possibility yes, though generally Apple put all temp. monitoring chips elsewhere, it could well be the case.

Ben.