Skip to contentSkip to conversation

wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT

PATCH New Oleg Nesterov 1 participant 1 message Nov 24, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT

The first "p->exit_state != EXIT_ZOMBIE" check doesn't make too much sense. The exit_state was EXIT_ZOMBIE when the function was called, and another thread can change it to EXIT_DEAD right after the check.

The second condition is not possible, detached non-traced threads were already filtered out by eligible_child(), we didn't drop tasklist since then.

kernel/exit.c renamed from kernel/exit.c~8_wtz_dead_code +0 -4
@@ -1193,10 +1193,6 @@ static int wait_task_zombie(struct task_
 		int exit_code = p->exit_code;
 		int why, status;
 
-		if (unlikely(p->exit_state != EXIT_ZOMBIE))
-			return 0;
-		if (unlikely(p->exit_signal == -1 && p->ptrace == 0))
-			return 0;
 		get_task_struct(p);
 		read_unlock(&tasklist_lock);
 		if ((exit_code & 0x7f) == 0) {