b43: reinit on too many PHY TX errors
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 68 lines · On Saturday 24 November 2007 21:11:11 Stefano Brivio wrote:
Restart the hardware on too many PHY TX errors. A thousand PHY TX errors per 15 seconds means we won't be able to recover for sure.
Signed-off-by Stefano Brivio <[email protected]>To: Michael Buesch <[email protected]>
---
Index:
wireless-2.6/drivers/net/wireless/b43/b43.h
===================================================================drivers/net/wireless/b43/b43.h +5
-0@@ -391,6 +391,8 @@ enum {#define B43_DEFAULT_SHORT_RETRY_LIMIT 7#define B43_DEFAULT_LONG_RETRY_LIMIT 4 +#define B43_PHY_TX_BADNESS_LIMIT 1000 +/* Max size of a security key */ #define B43_SEC_KEYSIZE 16/* Security algorithms. */ @@ -546,6 +548,9 @@ struct b43_phy {/* OFDM address read/write caching for hardware auto-increment. */ u16 ofdm_addr;u8 ofdm_valid;/* 0: invalid, 1: read, 2: write */ + +/* PHY TX errors counter. */ +u16 txerr_cnt; };/* Data structures for DMA transmission, per 80211 core. */ Index:
wireless-2.6/drivers/net/wireless/b43/main.c
===================================================================drivers/net/wireless/b43/main.c +13
-1@@ -1394,8 +1394,17 @@ static void b43_interrupt_tasklet(structif (unlikely (reason &B43_IRQ_MAC_TXERR ))b43err (dev->wl,"MAC transmission error\n" ); -if (unlikely (reason &B43_IRQ_PHY_TXERR )) +if (unlikely (reason &B43_IRQ_PHY_TXERR )) {b43err (dev->wl,"PHY transmission error\n" ); +if (dev->phy.txerr_cnt <B43_PHY_TX_BADNESS_LIMIT ) + dev->phy.txerr_cnt++; +else { + dev->phy.txerr_cnt =0 ; +b43err (dev->wl,"Too many PHY TX errors, " +"restarting the controller\n" ); +b43_controller_restart (dev,"PHY TX errors" ); + } + }if (unlikely (merged_dma_reason & (B43_DMAIRQ_FATALMASK |B43_DMAIRQ_NONFATALMASK ))) {@@ -2259,6 +2268,9 @@ static int b43_chip_init(struct b43_wlde/* OFDM address caching. */ phy->ofdm_valid =0 ; +/* PHY TX errors counter. */ + phy->txerr_cnt =0 ; + err =0 ;b43dbg (dev->wl,"Chip initialized\n" ); out:
drivers/net/wireless/b43/main.c static void b43_periodic_every15sec(stru · line 2360
Quoted 5 lines
drivers/net/wireless/b43/main.c +2
-0@@ -2344,6 +2356,8 @@ static void b43_periodic_every15sec(stru }b43_phy_xmitpower (dev);//FIXME: unless scanning? //TODO for APHY (temperature?) + + phy->txerr_cnt =0 ;
Needs either atomic_t plus memory barriers or spin_lock(&wl->irq_lock). I'd suggest atomic_t with mb()s as it's a bad idea to completely sync with IRQs on every 15sec pwork for this error counter.
Signature · 1 line
Greetings Michael.
PATCH v2 4/5 b43: reinit on too many PHY TX errors
Restart the hardware on too many PHY TX errors. A thousand PHY TX errors per 15 seconds means we won't be able to recover for sure.
---
drivers/net/wireless/b43/b43.h +5 -0
@@ -391,6 +391,8 @@ enum {#define B43_DEFAULT_SHORT_RETRY_LIMIT 7#define B43_DEFAULT_LONG_RETRY_LIMIT 4 +#define B43_PHY_TX_BADNESS_LIMIT 1000 +/* Max size of a security key */ #define B43_SEC_KEYSIZE 16/* Security algorithms. */
@@ -546,6 +548,9 @@ struct b43_phy {/* OFDM address read/write caching for hardware auto-increment. */ u16 ofdm_addr;u8 ofdm_valid;/* 0: invalid, 1: read, 2: write */ + +/* PHY TX errors counter. */ +atomic_t txerr_cnt; };/* Data structures for DMA transmission, per 80211 core. */
drivers/net/wireless/b43/main.c +16 -1
@@ -1394,8 +1394,17 @@ static void b43_interrupt_tasklet(structif (unlikely (reason &B43_IRQ_MAC_TXERR ))b43err (dev->wl,"MAC transmission error\n" ); -if (unlikely (reason &B43_IRQ_PHY_TXERR )) +if (unlikely (reason &B43_IRQ_PHY_TXERR )) {b43err (dev->wl,"PHY transmission error\n" ); +rmb (); +if (unlikely (atomic_dec_and_test (&dev->phy.txerr_cnt))) { +atomic_set (&dev->phy.txerr_cnt, +B43_PHY_TX_BADNESS_LIMIT ); +b43err (dev->wl,"Too many PHY TX errors, " +"restarting the controller\n" ); +b43_controller_restart (dev,"PHY TX errors" ); + } + }if (unlikely (merged_dma_reason & (B43_DMAIRQ_FATALMASK |B43_DMAIRQ_NONFATALMASK ))) {
@@ -2259,6 +2268,9 @@ static int b43_chip_init(struct b43_wlde/* OFDM address caching. */ phy->ofdm_valid =0 ; +/* PHY TX errors counter. */ +atomic_set (&phy->txerr_cnt,B43_PHY_TX_BADNESS_LIMIT ); + err =0 ;b43dbg (dev->wl,"Chip initialized\n" ); out:
@@ -2344,6 +2356,9 @@ static void b43_periodic_every15sec(stru }b43_phy_xmitpower (dev);//FIXME: unless scanning? //TODO for APHY (temperature?) + +atomic_set (&phy->txerr_cnt,B43_PHY_TX_BADNESS_LIMIT ); +wmb (); }static void do_periodic_work (struct b43_wldev *dev)
Signature · 2 lines
Ciao Stefano
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v2 5/5 b43legacy: reinit on too many PHY TX errors
Restart the hardware on too many PHY TX errors. A thousand PHY TX errors per 15 seconds means we won't be able to recover for sure.
---
drivers/net/wireless/b43legacy/b43legacy.h +5 -0
@@ -276,6 +276,8 @@#define B43legacy_DEFAULT_SHORT_RETRY_LIMIT 7#define B43legacy_DEFAULT_LONG_RETRY_LIMIT 4 +#define B43legacy_PHY_TX_BADNESS_LIMIT 1000 +/* Max size of a security key */ #define B43legacy_SEC_KEYSIZE 16/* Security algorithms. */
@@ -511,6 +513,9 @@ struct b43legacy_phy {u16 lofcal;u16 initval; + +/* PHY TX errors counter. */ +atomic_t txerr_cnt; };/* Data structures for DMA transmission, per 80211 core. */
drivers/net/wireless/b43legacy/main.c +14 -1
@@ -1221,8 +1221,15 @@ static void b43legacy_interrupt_tasklet(if (unlikely (reason & B43legacy_IRQ_MAC_TXERR))b43legacyerr (dev->wl,"MAC transmission error\n" ); -if (unlikely (reason & B43legacy_IRQ_PHY_TXERR)) +if (unlikely (reason & B43legacy_IRQ_PHY_TXERR)) {b43legacyerr (dev->wl,"PHY transmission error\n" ); +rmb (); +if (unlikely (atomic_dec_and_test (&dev->phy.txerr_cnt))) { +b43legacyerr (dev->wl,"Too many PHY TX errors, " +"restarting the controller\n" ); +b43legacy_controller_restart (dev,"PHY TX errors" ); + } + }if (unlikely (merged_dma_reason & (B43legacy_DMAIRQ_FATALMASK | B43legacy_DMAIRQ_NONFATALMASK))) {
@@ -2094,6 +2101,9 @@ static int b43legacy_chip_init(struct b4b43legacy_write16 (dev, B43legacy_MMIO_POWERUP_DELAY, dev->dev->bus->chipco.fast_pwrup_delay); +/* PHY TX errors counter. */ +atomic_set (&phy->txerr_cnt, B43legacy_PHY_TX_BADNESS_LIMIT); +B43legacy_WARN_ON (err !=0 );b43legacydbg (dev->wl,"Chip initialized\n" ); out:
@@ -2138,6 +2148,9 @@ static void b43legacy_periodic_every30sestatic void b43legacy_periodic_every15sec (struct b43legacy_wldev *dev) {b43legacy_phy_xmitpower (dev);/* FIXME: unless scanning? */ + +atomic_set (&dev->phy.txerr_cnt, B43legacy_PHY_TX_BADNESS_LIMIT); +wmb (); }static void do_periodic_work (struct b43legacy_wldev *dev)
Signature · 2 lines
Ciao Stefano