Skip to contentSkip to conversation

[[email protected]: intel-iommu-PMEN-think-oh patch.]

[email protected]: intel-iommu-PMEN-think-oh patch. mark gross 1 participant 1 message Nov 27, 2007 PCI

lore
Share & tools
lore

mark gross

author
#0 lore raw

I forgot to cc the list.

--mgross

----- Forwarded message from mark gross <[email protected]> -----

Date: Tue, 27 Nov 2007 15:46:09 -0800
From: mark gross <[email protected]>
To: Andrew Morton <[email protected]>
Reply-To: [email protected]
Subject: intel-iommu-PMEN-think-oh patch.

I screwed up with my earlier patch to enable the portected memroy. The macro IOMMU_WAIT, exits when the condition goes true. Without this patch the code will hang at boot and some ( all?) vtd enabled systems.

--mgross

drivers/pci/intel-iommu.c +1 -1
Index: linux-2.6.24-rc2+/drivers/pci/intel-iommu.c
===================================================================
@@ -704,7 +704,7 @@
 
 	/* wait for the protected region status bit to clear */
 	IOMMU_WAIT_OP(iommu, DMAR_PMEN_REG,
-		readl, (pmen & DMA_PMEN_PRS), pmen);
+		readl, !(pmen & DMA_PMEN_PRS), pmen);
 
 	spin_unlock_irqrestore(&iommu->register_lock, flags);
 }

----- End forwarded message -----