Skip to contentSkip to conversation

au1xxx-ide: au_ide_probe() fixes

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 3 messages Nov 27, 2007 – Nov 28, 2007 libata

lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 1/6 au1xxx-ide: au_ide_probe() fixes

* hwif->hold is always set in au_ide_probe() (few lines earlier), no need to set it again

* hwif->{channel,select_data,config_data} should be always zero

* autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/mips/au1xxx-ide.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/ide/mips/au1xxx-ide.c +2 -3
Index: b/drivers/ide/mips/au1xxx-ide.c
===================================================================
@@ -677,15 +677,14 @@ static int au_ide_probe(struct device *d
 	hwif->dma_setup                 = &auide_dma_setup;
 	hwif->ide_dma_test_irq          = &auide_dma_test_irq;
 	hwif->dma_lost_irq		= &auide_dma_lost_irq;
-#else /* !CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA */
+#endif
 	hwif->channel                   = 0;
-	hwif->hold                      = 1;
 	hwif->select_data               = 0;    /* no chipset-specific code */
 	hwif->config_data               = 0;    /* no chipset-specific code */
 
 	hwif->drives[0].autotune        = 1;    /* 1=autotune, 2=noautotune, 0=default */
 	hwif->drives[1].autotune	= 1;
-#endif
+
 	hwif->drives[0].no_io_32bit	= 1;
 	hwif->drives[1].no_io_32bit	= 1;
Acked-by on v1 1/6
#1 lore raw
Quoted 6 lines · Bartlomiej Zolnierkiewicz

* hwif->hold is always set in au_ide_probe() (few lines earlier), no need to set it again

* hwif->{channel,select_data,config_data} should be always zero

* autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined

You mean "also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA is defined"?

Quoted 1 line
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Acked-by Sergei Shtylyov <[email protected]>

MBR, Sergei

author
#2 lore raw
Quoted 10 lines · Sergei Shtylyov
Quoted 6 lines · Bartlomiej Zolnierkiewicz

* hwif->hold is always set in au_ide_probe() (few lines earlier), no need to set it again

* hwif->{channel,select_data,config_data} should be always zero

* autotune PIO also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_BDMA is not defined

You mean "also if CONFIG_BLK_DEV_IDE_AU1XXX_MDMA2_DBDMA is defined"?

Yes, fixed.

Thanks,
Bart