Markers Implementation for RCU Tracing
cover Markers Implementation for RCU Tracing
Hi,
Please review the ensuing set of patches which convert the
existing RCU tracing mechanism for Preempt RCU and RCU Boost into markers.
These patches are based upon the 2.6.24-rc2-rt1 kernel tree.
Along with marker transition, the RCU Tracing infrastructure has also been modularised to be built as a kernel module, thereby enabling runtime changes to the RCU Tracing infrastructure.
Patch [1/2] - Patch that converts the Preempt RCU tracing in rcupreempt.c into markers.
Patch [1/2] - Patch that converts the Preempt RCU Boost tracing in rcupreempt-boost.c into markers.
Thanks,
K.Prasad
([email protected])
Quoted 11 lines · K. Prasad
Hi,
Please review the ensuing set of patches which convert the
existing RCU tracing mechanism for Preempt RCU and RCU Boost into markers.These patches are based upon the 2.6.24-rc2-rt1 kernel tree.
Along with marker transition, the RCU Tracing infrastructure has also been modularised to be built as a kernel module, thereby enabling runtime changes to the RCU Tracing infrastructure.
Quoted 5 lines
Patch [1/2] - Patch that converts the Preempt RCU tracing in
rcupreempt.cinto markers.Patch [1/2] - Patch that converts the Preempt RCU Boost tracing in
rcupreempt-boost.cinto markers.
Looks good to me, though I do not pretend to understand the markers implementation. I presume that the markers implementation forces the varargs usage -- though the markers do seem quite a bit nicer in allowing the formatting to be specified more naturally.
Thanx, Paul
Quoted 15 lines · Paul E. McKenney
Quoted 14 lines · K. Prasad
Hi,
Please review the ensuing set of patches which convert the
existing RCU tracing mechanism for Preempt RCU and RCU Boost into markers.These patches are based upon the 2.6.24-rc2-rt1 kernel tree.
Along with marker transition, the RCU Tracing infrastructure has also been modularised to be built as a kernel module, thereby enabling runtime changes to the RCU Tracing infrastructure.
Patch [1/2] - Patch that converts the Preempt RCU tracing in
rcupreempt.cinto markers.
Quoted 8 lines
Quoted 2 lines
Patch [1/2] - Patch that converts the Preempt RCU Boost tracing in
rcupreempt-boost.cinto markers.Looks good to me, though I do not pretend to understand the markers implementation. I presume that the markers implementation forces the varargs usage -- though the markers do seem quite a bit nicer in allowing the formatting to be specified more naturally.
Paul,
Thanks for the quick review.
Yes, varargs are required for marker handlers even with fixed set of arguments.
Ingo,
Can you please include these patches in your rt patchset?
Thanks,
K.Prasad