Skip to contentSkip to conversation

blackfin compile error

DISCUSSION Applied Adrian Bunk 4 participants 5 messages Dec 2, 2007 – Dec 3, 2007

lore
Share & tools
lore
#0 lore raw

It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:

<-- snip -->

...
CC arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info') /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info') make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1

<-- snip -->

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#1 lore raw
Quoted 7 lines · Adrian Bunk

It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:

<-- snip -->

...
CC arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer

Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI header file which is in -mm tree.

David, could you please submit the Blackfin SPI update to mainline?

Quoted 24 lines

/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info') /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info') make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1

<-- snip -->

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 5 lines · Bryan Wu
Quoted 4 lines · Adrian Bunk

It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:

<-- snip -->

Quoted 8 lines
Quoted 3 lines

...
CC arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer

Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI header file which is in -mm tree.

David, could you please submit the Blackfin SPI update to mainline?

So far as I know they're all ready for Andrew to get them to Linus...

Quoted 13 lines
Quoted 12 lines

/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: extra brace group at end of initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: (near initialization for 'bfin_spi0_info') /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: excess elements in struct initializer /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: warning: (near initialization for 'bfin_spi0_info') make[2]: *** [arch/blackfin/mach-bf537/boards/stamp.o] Error 1

<-- snip -->

cu
Adrian

--

#3 lore raw
Quoted 10 lines · On Sat, 1 Dec 2007 22:59:05 -0800 David Brownell <[email protected]> wrote:
Quoted 9 lines · Bryan Wu
Quoted 7 lines · Adrian Bunk

It seems commit 5d448dd50712ae42f8176b5bb8db4703bef6f0f5 was incomplete:

<-- snip -->

...
CC arch/blackfin/mach-bf537/boards/stamp.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/blackfin/mach-bf537/boards/stamp.c:539: error: unknown field 'pin_req' specified in initializer

Quoted 7 lines
Quoted 4 lines

Yes, there is a SPI patch adding the field 'pin_req' in a Blackfin SPI header file which is in -mm tree.

David, could you please submit the Blackfin SPI update to mainline?

So far as I know they're all ready for Andrew to get them to Linus...

I have all these:

spi-at25-driver-is-for-eeprom-not-flash.patch spi-use-mutex-not-semaphore.patch spi-simplify-spi_sync-calling-convention.patch spi-use-simplified-spi_sync-calling-convention.patch
#
spi-initial-bf54x-spi-support.patch spi-bfin-spi-uses-portmux-calls.patch spi-spi_bfin-cleanups-error-handling.patch spi-spi_bfin-handles-spi_transfercs_change.patch spi-spi_bfin-dont-bypass-spi-framework.patch spi-spi_bfin-uses-platform-device-resources.patch spi-spi_bfin-uses-portmux-for-additional-busses.patch spi-spi_bfin-rearrange-portmux-calls.patch spi-spi_bfin-change-handling-of-communication-parameters.patch spi-spi_bfin-relocate-spin-waits.patch spi-spi_bfin-handle-multiple-spi_masters.patch spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch spi-spi_bfin-update-handling-of-delay-after-deselect.patch spi-spi_bfin-resequence-dma-start-stop.patch
# blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch blackfin-spi-driver-use-void-__iomem-for-regs_base.patch blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch atmel_spi-throughput-improvement.patch atmel_spi-chain-dma-transfers.patch atmel_spi-fix-dmachain-oops-with-debug-enabled.patch

queued for 2.6.25. If some of them need to be bumped up to 2.6.24: which ones and why?

#4 lore raw
Quoted 3 lines · Andrew Morton

I have all these:

spi-at25-driver-is-for-eeprom-not-flash.patch

I'd be tempted to merge that since it's documentation-only, and I like to see such stuff merged ASAP. But otherwise it's non-essential.

Quoted 1 line

spi-use-mutex-not-semaphore.patch

Non-essential.

Quoted 2 lines

spi-simplify-spi_sync-calling-convention.patch spi-use-simplified-spi_sync-calling-convention.patch

The first one fixes some minor bugs, so would be good to merge.

The second does minor associated cleanup ... non-essential.

Quoted 12 lines

#
spi-initial-bf54x-spi-support.patch spi-bfin-spi-uses-portmux-calls.patch spi-spi_bfin-cleanups-error-handling.patch spi-spi_bfin-handles-spi_transfercs_change.patch spi-spi_bfin-dont-bypass-spi-framework.patch spi-spi_bfin-uses-platform-device-resources.patch spi-spi_bfin-uses-portmux-for-additional-busses.patch spi-spi_bfin-rearrange-portmux-calls.patch spi-spi_bfin-change-handling-of-communication-parameters.patch spi-spi_bfin-relocate-spin-waits.patch spi-spi_bfin-handle-multiple-spi_masters.patch

Quoted 8 lines

spi-spi_bfin-bugfix-for-816-bit-word-sizes.patch spi-spi_bfin-update-handling-of-delay-after-deselect.patch spi-spi_bfin-resequence-dma-start-stop.patch
# blackfin-spi-driver-use-cpu_relax-to-replace-continue-in-while-busywait.patch blackfin-spi-driver-use-void-__iomem-for-regs_base.patch blackfin-spi-driver-move-hard-coded-pin_req-to-board-file.patch blackfin-spi-driver-reconfigure-speed_hz-and-bits_per_word-in-each-spi-transfer.patch

The fix to the compile error is in the next-to-last of these. Bryan says they're highly interdependent, and they also include quite a number of bugfixes (some "critical") that have been used in Analog's treee for many months now.

That makes sense to me, since they've been bouncing around for quite a while now. I'd be OK with merging all of them; if something breaks, it'd be no worse than the current state (and would only affect Blackfin).

Quoted 3 lines

atmel_spi-throughput-improvement.patch atmel_spi-chain-dma-transfers.patch atmel_spi-fix-dmachain-oops-with-debug-enabled.patch

Those can wait; they're performance updates.

Quoted 2 lines

queued for 2.6.25. If some of them need to be bumped up to 2.6.24: which ones and why?

I'd say all those Blackfin patches should go, and the one calling convention patch, are appropriate as bugfixes. And the doc patch, unless there's a reason to hold it back.

- Dave