Skip to contentSkip to conversation

PATCH: Remove endflag in NMI smp_call_function call

PATCH Prarit Bhargava 1 participant 1 message Dec 3, 2007 x86

lore
Share & tools
lore
#0 lore raw

(Wim, I'm not sure if you're the right person to get this or not. Nothing else
came close in the MAINTAINERS file ....)

'endflag' is globally defined -- Passing endflag into smp_call_function is no longer necessary.

arch/x86/kernel/nmi_32.c +1 -1
index f5cc47c..50ba4e6 100644
@@ -89,7 +89,7 @@ static int __init check_nmi_watchdog(void)
 	printk(KERN_INFO "Testing NMI watchdog ... ");
 
 	if (nmi_watchdog == NMI_LOCAL_APIC)
-		smp_call_function(nmi_cpu_busy, (void *)&endflag, 0, 0);
+		smp_call_function(nmi_cpu_busy, NULL, 0, 0);
 
 	for_each_possible_cpu(cpu)
 		prev_nmi_count[cpu] = per_cpu(irq_stat, cpu).__nmi_count;
arch/x86/kernel/nmi_64.c +1 -1
index a576fd7..0443068 100644
@@ -97,7 +97,7 @@ int __init check_nmi_watchdog (void)
 
 #ifdef CONFIG_SMP
 	if (nmi_watchdog == NMI_LOCAL_APIC)
-		smp_call_function(nmi_cpu_busy, (void *)&endflag, 0, 0);
+		smp_call_function(nmi_cpu_busy, NULL, 0, 0);
 #endif
 
 	for (cpu = 0; cpu < NR_CPUS; cpu++)