suspend-related lockdep warning
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)
this has been happening for quite some time and might even be happening in mainline.
Also, a few seconds after resume has completed we get a whimper from the hangcheck driver:
[ 1.762425] usb 2-1: configuration #1 chosen from 1 choice [ 1.826548] input: Microsoft Microsoft Wireless Optical Mouse_ 1.00 as /class/input/input9 [ 1.866211] input: USB HID v1.11 Mouse [Microsoft Microsoft Wireless Optical Mouse_ 1.00] on usb-0000:00:1d.1-1 [ 5.757927] Hangcheck: hangcheck value past margin!
Quoted 4 lines · Andrew Morton
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
Quoted 9 lines
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53
I guess this is the task_lock() in refrigerator().
If that is the case, I don't understand this trace at all.
Quoted 25 lines
[ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)this has been happening for quite some time and might even be happening in mainline.
Also, a few seconds after resume has completed we get a whimper from the hangcheck driver:
[ 1.762425] usb 2-1: configuration #1 chosen from 1 choice [ 1.826548] input: Microsoft Microsoft Wireless Optical Mouse_ 1.00 as /class/input/input9 [ 1.866211] input: USB HID v1.11 Mouse [Microsoft Microsoft Wireless Optical Mouse_ 1.00] on usb-0000:00:1d.1-1 [ 5.757927] Hangcheck: hangcheck value past margin!
Hi!
Quoted 27 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)
Quoted 2 lines
this has been happening for quite some time and might even be happening in mainline.
Is it complaining that we entered refrigerator with irqs disabled?
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 29 lines · Pavel Machek
Hi!
Quoted 27 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)
Quoted 4 lines
Quoted 2 lines
this has been happening for quite some time and might even be happening in mainline.
Is it complaining that we entered refrigerator with irqs disabled?
Or that someone else called task_lock() with irqs disabled at one point ...
Hm, perhaps it's related to kernel preemption. Andrew, I guess the kernel is preemptible?
Greetings,
Rafael
Quoted 33 lines · On Sun, 2 Dec 2007 21:33:23 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 32 lines · Pavel Machek
Hi!
Quoted 29 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)this has been happening for quite some time and might even be happening in mainline.
Quoted 7 lines
Quoted 1 line
Is it complaining that we entered refrigerator with irqs disabled?
Or that someone else called
task_lock()with irqs disabled at one point ...Hm, perhaps it's related to kernel preemption. Andrew, I guess the kernel is preemptible?
Quoted 37 lines · Andrew Morton
Quoted 35 lines · On Sun, 2 Dec 2007 21:33:23 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 33 lines · Pavel Machek
Hi!
Quoted 27 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)Quoted 2 lines
this has been happening for quite some time and might even be happening in mainline.
Is it complaining that we entered refrigerator with irqs disabled?
Quoted 7 lines
Quoted 5 lines
Or that someone else called
task_lock()with irqs disabled at one point ...Hm, perhaps it's related to kernel preemption. Andrew, I guess the kernel is preemptible?
Is this reproducible with kernel preemption off?
Quoted 40 lines · On Mon, 3 Dec 2007 23:34:26 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 39 lines · Andrew Morton
Quoted 37 lines · On Sun, 2 Dec 2007 21:33:23 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 29 lines · Pavel Machek
Hi!
Quoted 27 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)Quoted 4 lines
Quoted 2 lines
this has been happening for quite some time and might even be happening in mainline.
Is it complaining that we entered refrigerator with irqs disabled?
Or that someone else called
task_lock()with irqs disabled at one point ...
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hm, perhaps it's related to kernel preemption. Andrew, I guess the kernel is preemptible?
Is this reproducible with kernel preemption off?
yes. Current -mm lineup:
[ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. [ 34.911876] Syncing filesystems ... done. [ 34.934526] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 #2 [ 34.935036] [<c0104853>] show_trace_log_lvl+0x12/0x25 [ 34.935142] [<c010506c>] show_trace+0xd/0x10 [ 34.935231] [<c0105850>] dump_stack+0x55/0x5d [ 34.935322] [<c0136125>] check_flags+0x7f/0x11a [ 34.935417] [<c0139210>] lock_acquire+0x3a/0x86 [ 34.935511] [<c0318faf>] _spin_lock+0x1c/0x49 [ 34.935603] [<c0140fc7>] refrigerator+0x13/0xc8 [ 34.935697] [<c01270ac>] get_signal_to_deliver+0x34/0x2e8 [ 34.935807] [<c0102edc>] do_notify_resume+0x8c/0x6fe [ 34.935907] [<c0103a2c>] work_notifysig+0x13/0x1b [ 34.936004] ======================= [ 34.936072] irq event stamp: 253 [ 34.936133] hardirqs last enabled at (253): [<c0103a8d>] syscall_exit_work+0x11/0x26 [ 34.936294] hardirqs last disabled at (252): [<c0103956>] syscall_exit+0x14/0x25 [ 34.936446] softirqs last enabled at (0): [<c011baf9>] copy_process+0x300/0x1246 [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 [ 34.954308] (elapsed 0.01 seconds) done. [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
Quoted 66 lines · Andrew Morton
Quoted 40 lines · On Mon, 3 Dec 2007 23:34:26 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 39 lines · Andrew Morton
Quoted 37 lines · On Sun, 2 Dec 2007 21:33:23 +0100 "Rafael J. Wysocki" <[email protected]> wrote:
Quoted 29 lines · Pavel Machek
Hi!
Quoted 27 lines
2.6.24-rc3-mm2 (which will be released if it boots on two more machines and if I stay awake) will say this during suspend-to-RAM on the Vaio:
[ 91.876445] Syncing filesystems ... done. [ 92.382595] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 92.384000] Pid: 1925, comm: dbus-daemon Not tainted 2.6.24-rc3-mm2 #32 [ 92.384177] [<c0104a74>] show_trace_log_lvl+0x12/0x25 [ 92.384335] [<c01052ff>] show_trace+0xd/0x10 [ 92.384469] [<c01059be>] dump_stack+0x55/0x5d [ 92.384605] [<c0136a29>] check_flags+0x7f/0x11a [ 92.384746] [<c0139cfb>] lock_acquire+0x3a/0x86 [ 92.384886] [<c031f4de>] _spin_lock+0x26/0x53 [ 92.385023] [<c0141d3b>] refrigerator+0x13/0xc8 [ 92.385163] [<c01274c8>] get_signal_to_deliver+0x32/0x3fb [ 92.385326] [<c01030f4>] do_notify_resume+0x8c/0x699 [ 92.385476] [<c0103c18>] work_notifysig+0x13/0x1b [ 92.385620] ======================= [ 92.385719] irq event stamp: 309 [ 92.385809] hardirqs last enabled at (309): [<c0103c79>] syscall_exit_work+0x11/0x26 [ 92.386045] hardirqs last disabled at (308): [<c0103b42>] syscall_exit+0x14/0x25 [ 92.386265] softirqs last enabled at (0): [<c011bea5>] copy_process+0x374/0x130e [ 92.386491] softirqs last disabled at (0): [<00000000>] 0x0 [ 92.392457] (elapsed 0.00 seconds) done. [ 92.392581] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done. [ 92.392882] PM: Entering mem sleep [ 92.392974] Suspending console(s)Quoted 4 lines
Quoted 2 lines
this has been happening for quite some time and might even be happening in mainline.
Is it complaining that we entered refrigerator with irqs disabled?
Or that someone else called
task_lock()with irqs disabled at one point ...Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Hm, perhaps it's related to kernel preemption. Andrew, I guess the kernel is preemptible?
Is this reproducible with kernel preemption off?
yes. Current -mm lineup:
[ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. [ 34.911876] Syncing filesystems ... done. [ 34.934526] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 #2 [ 34.935036] [<c0104853>] show_trace_log_lvl+0x12/0x25 [ 34.935142] [<c010506c>] show_trace+0xd/0x10 [ 34.935231] [<c0105850>] dump_stack+0x55/0x5d [ 34.935322] [<c0136125>] check_flags+0x7f/0x11a [ 34.935417] [<c0139210>] lock_acquire+0x3a/0x86 [ 34.935511] [<c0318faf>] _spin_lock+0x1c/0x49 [ 34.935603] [<c0140fc7>] refrigerator+0x13/0xc8 [ 34.935697] [<c01270ac>] get_signal_to_deliver+0x34/0x2e8 [ 34.935807] [<c0102edc>] do_notify_resume+0x8c/0x6fe [ 34.935907] [<c0103a2c>] work_notifysig+0x13/0x1b
Quoted 8 lines
[ 34.936004] ======================= [ 34.936072] irq event stamp: 253 [ 34.936133] hardirqs last enabled at (253): [<c0103a8d>] syscall_exit_work+0x11/0x26 [ 34.936294] hardirqs last disabled at (252): [<c0103956>] syscall_exit+0x14/0x25 [ 34.936446] softirqs last enabled at (0): [<c011baf9>] copy_process+0x300/0x1246 [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 [ 34.954308] (elapsed 0.01 seconds) done. [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
Hmm, do I understand correctly that lockdep expects us to disable interrupts before acquiring the task lock in refrigerator()? That would be strange.
Ingo, can you have a look at this, please?
Quoted 25 lines · Rafael J. Wysocki
Quoted 14 lines · Andrew Morton
[ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. [ 34.911876] Syncing filesystems ... done. [ 34.934526] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 #2 [ 34.935036] [<c0104853>] show_trace_log_lvl+0x12/0x25 [ 34.935142] [<c010506c>] show_trace+0xd/0x10 [ 34.935231] [<c0105850>] dump_stack+0x55/0x5d [ 34.935322] [<c0136125>] check_flags+0x7f/0x11a [ 34.935417] [<c0139210>] lock_acquire+0x3a/0x86 [ 34.935511] [<c0318faf>] _spin_lock+0x1c/0x49 [ 34.935603] [<c0140fc7>] refrigerator+0x13/0xc8 [ 34.935697] [<c01270ac>] get_signal_to_deliver+0x34/0x2e8 [ 34.935807] [<c0102edc>] do_notify_resume+0x8c/0x6fe [ 34.935907] [<c0103a2c>] work_notifysig+0x13/0x1bQuoted 8 lines
[ 34.936004] ======================= [ 34.936072] irq event stamp: 253 [ 34.936133] hardirqs last enabled at (253): [<c0103a8d>] syscall_exit_work+0x11/0x26 [ 34.936294] hardirqs last disabled at (252): [<c0103956>] syscall_exit+0x14/0x25 [ 34.936446] softirqs last enabled at (0): [<c011baf9>] copy_process+0x300/0x1246 [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 [ 34.954308] (elapsed 0.01 seconds) done. [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.
Quoted 4 lines
Hmm, do I understand correctly that lockdep expects us to disable interrupts before acquiring the task lock in
refrigerator()? That would be strange.Ingo, can you have a look at this, please?
No its complaining that the IRQ state changed without anybody telling it about it. Usually an unannotated cli/sti.
The particular line it warns, (lockdep.c:2662), suggests...
/me grabs a copy of 24-rc3-mm2
... that hardirqs are disabled, but irq tracking thinks they are still
enabled. So that would be an unannotated cli.
Quoted 35 lines · On Thu, 06 Dec 2007 11:31:28 +0100 Peter Zijlstra <[email protected]>…
Quoted 25 lines · Rafael J. Wysocki
Quoted 14 lines · Andrew Morton
[ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. [ 34.911876] Syncing filesystems ... done. [ 34.934526] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 #2 [ 34.935036] [<c0104853>] show_trace_log_lvl+0x12/0x25 [ 34.935142] [<c010506c>] show_trace+0xd/0x10 [ 34.935231] [<c0105850>] dump_stack+0x55/0x5d [ 34.935322] [<c0136125>] check_flags+0x7f/0x11a [ 34.935417] [<c0139210>] lock_acquire+0x3a/0x86 [ 34.935511] [<c0318faf>] _spin_lock+0x1c/0x49 [ 34.935603] [<c0140fc7>] refrigerator+0x13/0xc8 [ 34.935697] [<c01270ac>] get_signal_to_deliver+0x34/0x2e8 [ 34.935807] [<c0102edc>] do_notify_resume+0x8c/0x6fe [ 34.935907] [<c0103a2c>] work_notifysig+0x13/0x1bQuoted 8 lines
[ 34.936004] ======================= [ 34.936072] irq event stamp: 253 [ 34.936133] hardirqs last enabled at (253): [<c0103a8d>] syscall_exit_work+0x11/0x26 [ 34.936294] hardirqs last disabled at (252): [<c0103956>] syscall_exit+0x14/0x25 [ 34.936446] softirqs last enabled at (0): [<c011baf9>] copy_process+0x300/0x1246 [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 [ 34.954308] (elapsed 0.01 seconds) done. [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.Quoted 4 lines
Hmm, do I understand correctly that lockdep expects us to disable interrupts before acquiring the task lock in
refrigerator()? That would be strange.Ingo, can you have a look at this, please?
No its complaining that the IRQ state changed without anybody telling it about it. Usually an unannotated cli/sti.
Quoted 7 lines
The particular line it warns, (lockdep.c:2662), suggests...
/me grabs a copy of 24-rc3-mm2
... that hardirqs are disabled, but irq tracking thinks they are still
enabled. So that would be an unannotated cli.
It would be nice to make that warning tell us that - we've hit it a few times and I never knew this was the reason.
Quoted 39 lines · Andrew Morton
Quoted 37 lines · On Thu, 06 Dec 2007 11:31:28 +0100 Peter Zijlstra <[email protected]>…
Quoted 25 lines · Rafael J. Wysocki
Quoted 14 lines · Andrew Morton
[ 34.455096] ipw2200: Failed to send WEP_KEY: Command timed out. [ 34.911876] Syncing filesystems ... done. [ 34.934526] Freezing user space processes ... WARNING: at kernel/lockdep.c:2662 check_flags() [ 34.934917] Pid: 1922, comm: dbus-daemon Not tainted 2.6.24-rc3-mm3 #2 [ 34.935036] [<c0104853>] show_trace_log_lvl+0x12/0x25 [ 34.935142] [<c010506c>] show_trace+0xd/0x10 [ 34.935231] [<c0105850>] dump_stack+0x55/0x5d [ 34.935322] [<c0136125>] check_flags+0x7f/0x11a [ 34.935417] [<c0139210>] lock_acquire+0x3a/0x86 [ 34.935511] [<c0318faf>] _spin_lock+0x1c/0x49 [ 34.935603] [<c0140fc7>] refrigerator+0x13/0xc8 [ 34.935697] [<c01270ac>] get_signal_to_deliver+0x34/0x2e8 [ 34.935807] [<c0102edc>] do_notify_resume+0x8c/0x6fe [ 34.935907] [<c0103a2c>] work_notifysig+0x13/0x1bQuoted 8 lines
[ 34.936004] ======================= [ 34.936072] irq event stamp: 253 [ 34.936133] hardirqs last enabled at (253): [<c0103a8d>] syscall_exit_work+0x11/0x26 [ 34.936294] hardirqs last disabled at (252): [<c0103956>] syscall_exit+0x14/0x25 [ 34.936446] softirqs last enabled at (0): [<c011baf9>] copy_process+0x300/0x1246 [ 34.936599] softirqs last disabled at (0): [<00000000>] 0x0 [ 34.954308] (elapsed 0.01 seconds) done. [ 34.954389] Freezing remaining freezable tasks ... (elapsed 0.00 seconds) done.Quoted 4 lines
Hmm, do I understand correctly that lockdep expects us to disable interrupts before acquiring the task lock in
refrigerator()? That would be strange.Ingo, can you have a look at this, please?
No its complaining that the IRQ state changed without anybody telling it about it. Usually an unannotated cli/sti.
The particular line it warns, (lockdep.c:2662), suggests...
Quoted 8 lines
Quoted 5 lines
/me grabs a copy of 24-rc3-mm2
... that hardirqs are disabled, but irq tracking thinks they are still
enabled. So that would be an unannotated cli.It would be nice to make that warning tell us that - we've hit it a few times and I never knew this was the reason.
Ingo just did that, patch should be coming to a lockdep repo near you soon :-)
Quoted 2 lines · Andrew Morton
It would be nice to make that warning tell us that - we've hit it a few times and I never knew this was the reason.
i'm a mind-reader and a time-traveler as well, so i've got the patch below lined up in my sched.git queue already :-)
Ingo
-------------->
Subject: lockdep: make cli/sti annotation warnings clearer
From: Ingo Molnar <[email protected]>
make cli/sti annotation warnings easier to interpret.
--- kernel/lockdep.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
kernel/lockdep.c +9 -4
@@ -2654,10 +2654,15 @@ static void check_flags(unsigned long flif (!debug_locks)return ; -if (irqs_disabled_flags (flags)) -DEBUG_LOCKS_WARN_ON (current->hardirqs_enabled); -else -DEBUG_LOCKS_WARN_ON (!current->hardirqs_enabled); +if (irqs_disabled_flags (flags)) { +if (DEBUG_LOCKS_WARN_ON (current->hardirqs_enabled)) { +printk ("possible reason: unannotated irqs-off.\n" ); + } + }else { +if (DEBUG_LOCKS_WARN_ON (!current->hardirqs_enabled)) { +printk ("possible reason: unannotated irqs-on.\n" ); + } + }/* * We dont accurately track softirq state in e.g.