NET: mac80211 - fix inappropriate memory freeing

PATCH In review Cyrill Gorcunov 2 participants 2 messages Dec 3, 2007 mac80211

Share & tools

Cyrill Gorcunov

author

2007-12-03 19:23 UTC #0 lore raw

PATCH 1/1 NET: mac80211 - fix inappropriate memory freeing

This patch does fix inappropriate memory freeing in case of requested rate_control_ops was not found. In this case the list head entity is going to be accidently wasted.

Signed-off-by Cyrill Gorcunov <[email protected]>

---
 net/mac80211/ieee80211_rate.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

net/mac80211/ieee80211_rate.c +1 -1

index 3260a4a..c3f2783 100644
@@ -60,11 +60,11 @@ void ieee80211_rate_control_unregister(struct rate_control_ops *ops)
 	list_for_each_entry(alg, &rate_ctrl_algs, list) {
 		if (alg->ops == ops) {
 			list_del(&alg->list);
+			kfree(alg);
 			break;
 		}
 	}
 	mutex_unlock(&rate_ctrl_mutex);
-	kfree(alg);
 }
 EXPORT_SYMBOL(ieee80211_rate_control_unregister);

Signature · 1 line

1.5.3.5

Michael Wu

Acked-by on v1 1/1

2007-12-03 22:18 UTC #1 lore raw

Quoted 5 lines · On Monday 03 December 2007 14:22:49 Cyrill Gorcunov wrote:

This patch does fix inappropriate memory freeing in case of requested rate_control_ops was not found. In this case the list head entity is going to be accidently wasted.
Signed-off-by Cyrill Gorcunov <[email protected]>

Acked-by Michael Wu <[email protected]>

Thanks,
-Michael Wu