Skip to contentSkip to conversation

PATCH: Hitachi disk quirk

PATCH Lukas Hejtmanek 2 participants 3 messages Dec 4, 2007 libata

lore
Share & tools
lore
#0 lore raw

Hello,

the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi disk has also problem with NCQ.

Signature · 1 line
Lukáš Hejtmánek
drivers/ata/libata-core.c +1 -0
@@ -4159,6 +4159,7 @@
 	{ "HTS541612J9SA00",	"SBDIC7JP",	ATA_HORKAGE_NONCQ, },
 	{ "HDT722516DLA380",	"V43OA96A",	ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
+	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },
 	{ "WDC WD740ADFD-00NLR1", NULL,		ATA_HORKAGE_NONCQ, },
 	{ "WDC WD3200AAJS-00RYA0", "12.01B01",	ATA_HORKAGE_NONCQ, },
#1 lore raw
Quoted 4 lines · Lukas Hejtmanek

Hello,

the following patch should be applied into 2.6.24-rc3 as the mentioned Hitachi disk has also problem with NCQ.

Which problems, exactly?

Note that recent massive "NCQ horkage" isn't necessary due to drives fault. Search for "spurious completions during NCQ" for recent discussions (many of them).

drivers/ata/libata-core.c line 4163

Quoted 5 lines
drivers/ata/libata-core.c +1 -0
 	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
+	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },

/mjt

#2 lore raw
Quoted 1 line · Michael Tokarev

Which problems, exactly?

it is spurious completitions and I saw that because of that the drives are blacklisted. Moreover, the same drive is already blacklisted but with different firmware.

Quoted 11 lines

Note that recent massive "NCQ horkage" isn't necessary due to drives fault. Search for "spurious completions during NCQ" for recent discussions (many of them).

drivers/ata/libata-core.c line 4163

Quoted 5 lines
drivers/ata/libata-core.c +1 -0
 	{ "Hitachi HTS541616J9SA00", "SB4OC70P", ATA_HORKAGE_NONCQ, },
+	{ "HITACHI HTS541616J9SA00", "SB4IC7UP", ATA_HORKAGE_NONCQ, },
 	{ "Hitachi HTS542525K9SA00", "BBFOC31P", ATA_HORKAGE_NONCQ, },

/mjt

Signature · 1 line
Lukáš Hejtmánek