config_aneg for phy not supporting autonegotiation

Hello,

I added a driver for a phy that doesn't support autonegotiation (see below).

I didn't add SUPPORTED_Autoneg to hirschmannrs422_driver.features. I expected that this results in hirschmannrs422_config_aneg never being called, but that's wrong. So I wonder what it should do.

Moreover that phy only supports 10MBit/Half but still it seems to use something different first and short after bringing the device up I get a printk saying:

Trying 10/HALF

I didn't investigate that yet.

I couldn't find a place in the generic phy code that uses driver.features, probably it's just that that needs fixing?

Best regards
Uwe

--->8---
From: Uwe Kleine-König <[email protected]>

add Hirschmann RS422 phy

---
 drivers/net/phy/Kconfig            |    3 ++
 drivers/net/phy/Makefile           |    1 +
 drivers/net/phy/hirschmann-rs422.c |   55 ++++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/hirschmann-rs422.c

index 54b2ba9..39d4905 100644
@@ -90,6 +90,9 @@ config FIXED_MII_AMNT
         This control will have specified number allocated for each fixed
         PHY type enabled.
 
+config HIRSCHMANNRS422_PHY
+	tristate "Driver for Hirschmann's RS422 PHY"
+
 config MDIO_BITBANG
 	tristate "Support for bitbanged MDIO buses"
 	help

index 3d6cc7b..748d69f 100644
@@ -13,4 +13,5 @@ obj-$(CONFIG_VITESSE_PHY)	+= vitesse.o
 obj-$(CONFIG_BROADCOM_PHY)	+= broadcom.o
 obj-$(CONFIG_ICPLUS_PHY)	+= icplus.o
 obj-$(CONFIG_FIXED_PHY)		+= fixed.o
+obj-$(CONFIG_HIRSCHMANNRS422_PHY) += hirschmann-rs422.o
 obj-$(CONFIG_MDIO_BITBANG)	+= mdio-bitbang.o

1.5.3.6


-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962