Skip to contentSkip to conversation

scsi_wait_scan Kconfig option

PATCH Nick Warne 4 participants 5 messages Dec 7, 2007 – Dec 8, 2007 SCSI

lore
Share & tools
lore

Nick Warne

author
#0 lore raw

Hi all,

I am bringing this up again - primarily as I forgot about it after patching my build tree ages ago:

http://lkml.org/lkml/2007/10/27/68

Today I built and installed git for the first time and cloned Linus' tree (very trick!).

I try not to build a modular kernel, but only have modules ON due to nVidia (sigh). So I was semi-surprised when I saw the scsi_wait_scan module being built again, yet NO WHERE in menuconfig is it present to turn OFF. Even if I hand edit .config, make puts it back again...

.config
# SCSI device support
#
# CONFIG_RAID_ATTRS is not set
CONFIG_SCSI=y
CONFIG_SCSI_DMA=y
# CONFIG_SCSI_TGT is not set
# CONFIG_SCSI_NETLINK is not set
# CONFIG_SCSI_PROC_FS is not set

#
# SCSI support type (disk, tape, CD-ROM)
#
CONFIG_BLK_DEV_SD=y
# CONFIG_CHR_DEV_ST is not set
# CONFIG_CHR_DEV_OSST is not set
# CONFIG_BLK_DEV_SR is not set
# CONFIG_CHR_DEV_SG is not set
# CONFIG_CHR_DEV_SCH is not set

#
# Some SCSI devices (e.g. CD jukebox) support multiple LUNs #
# CONFIG_SCSI_MULTI_LUN is not set
# CONFIG_SCSI_CONSTANTS is not set
# CONFIG_SCSI_LOGGING is not set
# CONFIG_SCSI_SCAN_ASYNC is not set CONFIG_SCSI_WAIT_SCAN=m

I have attached my patch again :-)

Nick

Signature · 1 line
Free Software Foundation Associate Member 5508
drivers/scsi/Kconfig renamed from drivers/scsi/Kconfig_old +8 -1
@@ -248,10 +248,17 @@
 	  or async on the kernel's command line.
 
 config SCSI_WAIT_SCAN
-	tristate
+	tristate "Wait for SCSI scan completion"
 	default m
 	depends on SCSI
 	depends on MODULES
+	help
+	  The SCSI subsystem can probe for devices while the rest of the
+	  system continues booting, and even probe devices on different
+	  busses in parallel, leading to a significant speed-up.
+
+	  You can load the scsi_wait_scan module to ensure that all scans
+	  have completed.
 
 menu "SCSI Transports"
 	depends on SCSI
#1 lore raw
Quoted 4 lines · Nick Warne

I am bringing this up again - primarily as I forgot about it after patching my build tree ages ago:

http://lkml.org/lkml/2007/10/27/68

Please see the patch I sent some days ago, which does the very same thing: http://marc.info/?l=linux-kernel&m=119677244318528&w=2

I would extend the help text a bit more to make clear what it really does, since there is not much documentation around.

Quoted 4 lines

I try not to build a modular kernel, but only have modules ON due to nVidia (sigh). So I was semi-surprised when I saw the scsi_wait_scan module being built again, yet NO WHERE in menuconfig is it present to turn OFF. Even if I hand edit .config, make puts it back again...

True...

Regards,

Signature · 11 lines
Clemens Koller
_______________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Str. 45/1
81379 Muenchen
Germany

http://www.anagramm-technology.com
Phone: +49-89-741518-50
Fax: +49-89-741518-19
author
#2 lore raw
Quoted 5 lines · On Sat, 08 Dec 2007 14:11:44 +0100 Clemens Koller <[email protected]>…
Quoted 4 lines · Nick Warne

I am bringing this up again - primarily as I forgot about it after patching my build tree ages ago:

http://lkml.org/lkml/2007/10/27/68

Subject: Re: Fw: scsi_wait_scan Kconfig option
Date: Fri, 7 Dec 2007 12:47:56 -0700

Quoted 4 lines · Nick Warne

I try not to build a modular kernel, but only have modules ON due to nVidia (sigh). So I was semi-surprised when I saw the scsi_wait_scan module being built again, yet NO WHERE in menuconfig is it present to turn OFF. Even if I hand edit .config, make puts it back again...

Quoted 10 lines · On Fri, 7 Dec 2007 12:47:56 -0700 Matthew Wilcox <[email protected]> wrote:

You have modules on ... which means you might decide to load a scsi driver as a module. Maybe one that isn't part of the source tree. The scsi_wait_scan module is only 1500 bytes. Apart from a sense of ideological purity (odd in someone who chooses to use nVidia rather than, say, nv or nouveau), this really isn't a problem.

Please see the patch I sent some days ago, which does the very same thing: http://marc.info/?l=linux-kernel&m=119677244318528&w=2

True...

Well, that's two of us would that like to be able to stop it building :-)

Nick

Signature · 1 line
Free Software Foundation Associate Member 5508
#3 lore raw
Quoted 9 lines
Quoted 8 lines · Clemens Koller
Quoted 4 lines · Nick Warne

I am bringing this up again - primarily as I forgot about it after patching my build tree ages ago:

http://lkml.org/lkml/2007/10/27/68

Please see the patch I sent some days ago, which does the very same thing: http://marc.info/?l=linux-kernel&m=119677244318528&w=2

Besides, in order for scsi_wait_scan to work, drivers need to support it explicitly, don't they? If so, simply kill the "default m" from config SCSI_WAIT_SCAN and let any driver which is integrated with it select it.

(Not that I'm a friend of select, but here is a case where it won't hurt too much.)

Signature · 3 lines
Stefan Richter
-=====-=-=== ==-- -=---
http://arcgraph.de/sr/
#4 lore raw
Quoted 3 lines · Stefan Richter

Besides, in order for scsi_wait_scan to work, drivers need to support it explicitly, don't they? If so, simply kill the "default m" from config SCSI_WAIT_SCAN and let any driver which is integrated with it select it.

No. All drivers which call scsi_scan_host() support it.

Signature · 4 lines
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."