Skip to contentSkip to conversation

netns: network namespace was passed into dev_getbyhwaddr but not used

PATCH Applied Denis V. Lunev 2 participants 2 messages Dec 12, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Denis V. Lunev

author
#0 lore raw

PATCH 1/1 netns: network namespace was passed into dev_getbyhwaddr but not used

netns: network namespace was passed into dev_getbyhwaddr but not used

Signed-off-by Denis V. Lunev <[email protected]>
net/core/dev.c +1 -1
index 06615df..677f35b 100644
@@ -675,7 +675,7 @@ struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type, char *h
 
 	ASSERT_RTNL();
 
-	for_each_netdev(&init_net, dev)
+	for_each_netdev(net, dev)
 		if (dev->type == type &&
 		    !memcmp(dev->dev_addr, ha, dev->addr_len))
 			return dev;
maintainer Applied
#1 lore raw

From: "Denis V. Lunev" <[email protected]>
Date: Wed, 12 Dec 2007 14:05:17 +0300

Quoted 3 lines

netns: network namespace was passed into dev_getbyhwaddr but not used

Signed-off-by Denis V. Lunev <[email protected]>

Applied.

Please always put the subsystem name in the headline in all capitals and surround it with brackets, like this:

[NETNS]: Blah blah blah.

Also treat the description line as a true English sentence, this means capitalize the first word and put a period at the end of it. This is a changelog message for a professional piece of software, not some "innanet" slang talk on some IRC channel. :-)

I make these edits to every one of your patch submissions and it's getting tiring, I hoped you would notice this yourself before my needing to tell you about it explicitly :-)