fix cciss locking bug.

PATCH Dave Jones 1 participant 1 message Dec 12, 2007

Subsystems (2)

SCSI Block layer

lore

Share & tools

lore

Dave Jones

author

2007-12-12 03:44 UTC #0 lore raw

do_cciss_intr takes the controller lock on entry, and if something goes wrong, it calls fail_all_cmds which tries to take the same lock.

Signed-off-by Dave Jones <[email protected]>

drivers/block/cciss.c +1 -0

index 7d70496..1c57583 100644
@@ -2756,6 +2756,7 @@ static irqreturn_t do_cciss_intr(int irq, void *dev_id)
 					printk(KERN_WARNING
 					       "cciss: controller cciss%d failed, stopping.\n",
 					       h->ctlr);
+					spin_unlock_irqrestore(CCISS_LOCK(h->ctlr), flags);
 					fail_all_cmds(h->ctlr);
 					return IRQ_HANDLED;
 				}

Signature · 1 line

http://www.codemonkey.org.uk