Skip to contentSkip to conversation

sysctl : proc_dointvec_minmax() expects int values for min/max guard values

PATCH Applied Eric Dumazet 2 participants 2 messages Dec 12, 2007 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysctl : proc_dointvec_minmax() expects int values for min/max guard values

min_sched_granularity_ns, max_sched_granularity_ns, min_wakeup_granularity_ns and max_wakeup_granularity_ns are declared "unsigned long".

This is incorrect since proc_dointvec_minmax() expects plain "int" guard values.

This bug only triggers on big endian 64 bit arches.

kernel/sysctl.c +4 -4
index 8ac5171..707a26b 100644
@@ -225,10 +225,10 @@ static struct ctl_table root_table[] = {
 };
 
 #ifdef CONFIG_SCHED_DEBUG
-static unsigned long min_sched_granularity_ns = 100000;		/* 100 usecs */
-static unsigned long max_sched_granularity_ns = NSEC_PER_SEC;	/* 1 second */
-static unsigned long min_wakeup_granularity_ns;			/* 0 usecs */
-static unsigned long max_wakeup_granularity_ns = NSEC_PER_SEC;	/* 1 second */
+static int min_sched_granularity_ns = 100000;		/* 100 usecs */
+static int max_sched_granularity_ns = NSEC_PER_SEC;	/* 1 second */
+static int min_wakeup_granularity_ns;			/* 0 usecs */
+static int max_wakeup_granularity_ns = NSEC_PER_SEC;	/* 1 second */
 #endif
 
 static struct ctl_table kern_table[] = {
Applied
#1 lore raw
Quoted 8 lines · Eric Dumazet

min_sched_granularity_ns, max_sched_granularity_ns, min_wakeup_granularity_ns and max_wakeup_granularity_ns are declared "unsigned long".

This is incorrect since proc_dointvec_minmax() expects plain "int" guard values.

This bug only triggers on big endian 64 bit arches.

thanks, applied it to the 2.6.24 fixes queue.

Ingo