Skip to contentSkip to conversation

sound/ad1848: fix printk format

PATCH In review Randy Dunlap 2 participants 4 messages Oct 29, 2007 – Dec 13, 2007 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sound/ad1848: fix printk format

From: Randy Dunlap <[email protected]>

Fix printk format warning:

sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

---
 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/isa/ad1848/ad1848_lib.c +1 -1
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %lu\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
#1 lore raw

At Mon, 29 Oct 2007 11:20:10 -0700,

Quoted 8 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warning:

sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Thanks, but another fix was already in ALSA tree.

Jaroslav, please prepare for push again? Some patches are really worth to be in 2.6.24.

Takashi

Quoted 21 lines
---
 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/isa/ad1848/ad1848_lib.c +1 -2
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %lu\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 7 lines · On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote:

At Mon, 29 Oct 2007 11:20:10 -0700,

Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warning:

Quoted 8 lines
Quoted 3 lines

sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Thanks, but another fix was already in ALSA tree.

Jaroslav, please prepare for push again? Some patches are really worth to be in 2.6.24.

Hi,
This is still needed, over 1 month later....

Quoted 12 lines

Takashi

Quoted 10 lines
---
 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/isa/ad1848/ad1848_lib.c +0 -0
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
Quoted 6 lines

sound/isa/ad1848/ad1848_lib.c static void snd_ad1848_mce_down(struct s

Quoted 6 lines
sound/isa/ad1848/ad1848_lib.c +1 -2
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %lu\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
-

---
~Randy

#3 lore raw

At Wed, 12 Dec 2007 20:42:46 -0800,

Quoted 14 lines · Randy Dunlap
Quoted 11 lines · On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote:

At Mon, 29 Oct 2007 11:20:10 -0700,

Quoted 8 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix printk format warning:

sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Quoted 7 lines
Quoted 4 lines

Thanks, but another fix was already in ALSA tree.

Jaroslav, please prepare for push again? Some patches are really worth to be in 2.6.24.

Hi,
This is still needed, over 1 month later....

Thanks for notice. It's in the alsa.git tree but it's slipped from the last push...

Jaroslav, could you make it for push please?

thanks,

Takashi

Quoted 25 lines
Quoted 14 lines

Takashi

Quoted 10 lines
---
 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/isa/ad1848/ad1848_lib.c +0 -0
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
Quoted 6 lines

sound/isa/ad1848/ad1848_lib.c static void snd_ad1848_mce_down(struct s

Quoted 6 lines
sound/isa/ad1848/ad1848_lib.c +1 -2
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %lu\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
-

---
~Randy