Skip to contentSkip to conversation

e100: free IRQ to remove warningwhenrebooting

PATCH In review Auke Kok 2 participants 2 messages Dec 13, 2007 – Dec 14, 2007

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Auke Kok

author
#0 lore raw

PATCH 1/1 e100: free IRQ to remove warningwhenrebooting

Adapted from Ian Wienand <[email protected]>

Explicitly free the IRQ before removing the device to remove a warning "Destroying IRQ without calling free_irq"

Signed-off-by Auke Kok <[email protected]>
Cc Ian Wienand <[email protected]>

---

 drivers/net/e100.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/net/e100.c +4 -1
index 27f4d4a..f630ea9 100644
@@ -2807,8 +2807,9 @@ static int e100_suspend(struct pci_dev *pdev, pm_message_t state)
 		pci_enable_wake(pdev, PCI_D3cold, 0);
 	}
 
-	pci_disable_device(pdev);
 	free_irq(pdev->irq, netdev);
+
+	pci_disable_device(pdev);
 	pci_set_power_state(pdev, PCI_D3hot);
 
 	return 0;

@@ -2850,6 +2851,8 @@ static void e100_shutdown(struct pci_dev *pdev)
 		pci_enable_wake(pdev, PCI_D3cold, 0);
 	}
 
+	free_irq(pdev->irq, netdev);
+
 	pci_disable_device(pdev);
 	pci_set_power_state(pdev, PCI_D3hot);
 }