Skip to contentSkip to conversation

Reduce whitespaces in fib_rules.h.

PATCH In review Denis V. Lunev 4 participants 6 messages Dec 13, 2007 1 message not in the archive

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

Denis V. Lunev

author
#0 lore raw

PATCH 1/1 Reduce whitespaces in fib_rules.h.

There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines.

Signed-off-by Denis V. Lunev <[email protected]>
---
 include/net/fib_rules.h |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)
include/net/fib_rules.h +7 -9
index 2364db1..d20db25 100644
@@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla)
 	return frh->table;
 }
 
-extern int			fib_rules_register(struct fib_rules_ops *);
-extern int			fib_rules_unregister(struct fib_rules_ops *);
-extern void                     fib_rules_cleanup_ops(struct fib_rules_ops *);
+extern int fib_rules_register(struct fib_rules_ops *);
+extern int fib_rules_unregister(struct fib_rules_ops *);
+extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
 
-extern int			fib_rules_lookup(struct fib_rules_ops *,
-						 struct flowi *, int flags,
-						 struct fib_lookup_arg *);
-extern int			fib_default_rule_add(struct fib_rules_ops *,
-						     u32 pref, u32 table,
-						     u32 flags);
+extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags,
+			    struct fib_lookup_arg *);
+extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table,
+				u32 flags);
 #endif
Signature · 1 line
1.5.3.rc5

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 2 lines · Denis V. Lunev

There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines.

If this patch is going in, it would be nice to get rid of "extern" as well.

Alexey, who once removed all externs from prototypes
and got 4 seconds compilation speedup.

Quoted 24 lines
include/net/fib_rules.h +7 -9
@@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla)
 	return frh->table;
 }
 
-extern int			fib_rules_register(struct fib_rules_ops *);
-extern int			fib_rules_unregister(struct fib_rules_ops *);
-extern void                     fib_rules_cleanup_ops(struct fib_rules_ops *);
+extern int fib_rules_register(struct fib_rules_ops *);
+extern int fib_rules_unregister(struct fib_rules_ops *);
+extern void fib_rules_cleanup_ops(struct fib_rules_ops *);
 
-extern int			fib_rules_lookup(struct fib_rules_ops *,
-						 struct flowi *, int flags,
-						 struct fib_lookup_arg *);
-extern int			fib_default_rule_add(struct fib_rules_ops *,
-						     u32 pref, u32 table,
-						     u32 flags);
+extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags,
+			    struct fib_lookup_arg *);
+extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table,
+				u32 flags);
 #endif
maintainer
#3 lore raw

From: Alexey Dobriyan <[email protected]>
Date: Thu, 13 Dec 2007 17:47:07 +0300

Quoted 6 lines · Denis V. Lunev
Quoted 2 lines

There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines.

If this patch is going in, it would be nice to get rid of "extern" as well.

The convention in the networking headers is to use extern, and this is pretty consistently done across the board.

If we are going to do this, which I personally see no reason for, we should do it across the whole networking.

Consistency is much more important than whatever reason you could come up with to get rid of the 'extern'.

maintainer
#4 lore raw
In reply to Denis V. Lunev

From: "Denis V. Lunev" <[email protected]>
Date: Thu, 13 Dec 2007 17:18:42 +0300

Quoted 4 lines

There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines.

Signed-off-by Denis V. Lunev <[email protected]>

This is just noise and serves nothing other than to invite potential patch conflicts which makes development harder.

If you happened to be changing these for other reasons, I'd say OK, but not like this.

#5 lore raw
Quoted 6 lines · David Miller

From: "Denis V. Lunev" <[email protected]>
Date: Thu, 13 Dec 2007 17:18:42 +0300

Quoted 3 lines

There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines.

Quoted 8 lines
Quoted 1 line
Signed-off-by Denis V. Lunev <[email protected]>

This is just noise and serves nothing other than to invite potential patch conflicts which makes development harder.

If you happened to be changing these for other reasons, I'd say OK, but not like this.

I will add parameter to these calls. The line will be too long after that. I'd like to separate sense changes from, you perfectly correct, useless changes :(

Could you still apply it, or I will need to send fully functional set to you including this?

maintainer
#6 lore raw

From: "Denis V. Lunev" <[email protected]>
Date: Thu, 13 Dec 2007 18:01:32 +0300

Quoted 2 lines

Could you still apply it, or I will need to send fully functional set to you including this?

Please combine the changes so that when you change the args you fixup the whitespace as well.