Skip to contentSkip to conversation

libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes

PATCH In review [email protected] 1 participant 1 message Dec 14, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 6/9 libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes

From: Andrew Morton <[email protected]>

WARNING: line over 80 characters
#36: FILE: drivers/ata/pata_bf54x.c:1512:
+ while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) {

ERROR: need spaces around that '>' (ctx:VxV) #36: FILE: drivers/ata/pata_bf54x.c:1512:
+ while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) {
^

total: 1 errors, 1 warnings, 19 lines checked

Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc Jeff Garzik <[email protected]>
Cc Sonic Zhang <[email protected]>
Cc Tejun Heo <[email protected]>
Cc sonic zhang <[email protected]>

---

 drivers/ata/pata_bf54x.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/pata_bf54x.c renamed from drivers/ata/pata_bf54x.c~libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes +2 -1
diff -puN drivers/ata/pata_bf54x.c~libata-set-proper-ata-udma-mode-for-bf548-according-to-system-clock-checkpatch-fixes drivers/ata/pata_bf54x.c
@@ -1509,7 +1509,8 @@ static int __devinit bfin_atapi_probe(st
 	if (res == NULL)
 		return -EINVAL;
 
-	while (bfin_port_info[board_idx].udma_mask>0 && udma_fsclk[udma_mode] > fsclk) {
+	while (bfin_port_info[board_idx].udma_mask > 0 &&
+			udma_fsclk[udma_mode] > fsclk) {
 		udma_mode--;
 		bfin_port_info[board_idx].udma_mask >>= 1;
 	}

_