SCSI/sym53c416: kill pointless irq handler loop and test
PATCH 11/30 SCSI/sym53c416: kill pointless irq handler loop and test
From: Jeff Garzik <[email protected]>
- kill pointless irq handler loop to find base address, it is already passed to irq handler via Scsi_Host.
- kill now-pointless !base test.
Signed-off-by Jeff Garzik <[email protected]>
Cc James Bottomley <[email protected]>
Cc Matthew Wilcox <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/scsi/sym53c416.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)
drivers/scsi/sym53c416.c renamed from drivers/scsi/sym53c416.c~scsi-sym53c416-kill-pointless-irq-handler-loop-and-test +1 -15
@@ -328,27 +328,13 @@ static __inline__ unsigned int sym53c416static irqreturn_t sym53c416_intr_handle (int irq,void *dev_id) {struct Scsi_Host *dev = dev_id; -int base =0 ; +int base = dev->io_port;int i;unsigned long flags =0 ;unsigned char status_reg, pio_int_reg, int_reg;struct scatterlist *sg;unsigned int tot_trans =0 ; -/* We search the base address of the host adapter which caused the interrupt */ -/* FIXME: should pass dev_id sensibly as hosts[i] */ -for (i =0 ; i < host_index && !base; i++) -if (irq == hosts[i].irq) - base = hosts[i].base; -/* If no adapter found, we cannot handle the interrupt. Leave a message */ -/* and continue. This should never happen... */ -if (!base) - { -printk (KERN_ERR "sym53c416: No host adapter defined for interrupt %d\n" , irq); -return IRQ_NONE ; - } -/* Now we have the base address and we can start handling the interrupt */ -spin_lock_irqsave (dev->host_lock,flags); status_reg =inb (base +STATUS_REG ); pio_int_reg =inb (base +PIO_INT_REG );
_