drivers/dma/ioat_dma.c: inlining failed

PATCH In review S.Çağlar Onur 5 participants 6 messages Dec 14, 2007 – Jan 6, 2008

Subsystems (2)

dmaengine Intel i/oat DMA driver

lore

Share & tools

lore

S.Çağlar Onur

author

2007-12-14 19:45 UTC #0 lore raw

PATCH 1/1 drivers/dma/ioat_dma.c: inlining failed

Hi;

After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves following compiliation error with gcc-3.4.6. Following patch solves this issue for me;

[...]
CC [M] drivers/dma/ioat.o
CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Signed-off-by S.Çağlar Onur <[email protected]>

drivers/dma/ioat_dma.c +17 ~~-22~~

index c1c2dcc..1d66b82 100644
@@ -173,10 +173,25 @@ static void ioat_set_dest(dma_addr_t addr,
 	tx_to_ioat_desc(tx)->dst = addr;
 }
 
+/**
+ * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
+ *                                 descriptors to hw
+ * @chan: DMA channel handle
+ */
 static inline void __ioat1_dma_memcpy_issue_pending(
-					       struct ioat_dma_chan *ioat_chan);
+						struct ioat_dma_chan *ioat_chan)
+{
+	ioat_chan->pending = 0;
+	writeb(IOAT_CHANCMD_APPEND, ioat_chan->reg_base + IOAT1_CHANCMD_OFFSET);
+}
+
 static inline void __ioat2_dma_memcpy_issue_pending(
-					       struct ioat_dma_chan *ioat_chan);
+						struct ioat_dma_chan *ioat_chan)
+{
+	ioat_chan->pending = 0;
+	writew(ioat_chan->dmacount,
+	       ioat_chan->reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
+}
 
 static dma_cookie_t ioat1_tx_submit(struct dma_async_tx_descriptor *tx)
 {

@@ -700,18 +715,6 @@ static struct dma_async_tx_descriptor *ioat2_dma_prep_memcpy(
 }
 
 
-/**
- * ioat_dma_memcpy_issue_pending - push potentially unrecognized appended
- *                                 descriptors to hw
- * @chan: DMA channel handle
- */
-static inline void __ioat1_dma_memcpy_issue_pending(
-						struct ioat_dma_chan *ioat_chan)
-{
-	ioat_chan->pending = 0;
-	writeb(IOAT_CHANCMD_APPEND, ioat_chan->reg_base + IOAT1_CHANCMD_OFFSET);
-}
-
 static void ioat1_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);

@@ -723,14 +726,6 @@ static void ioat1_dma_memcpy_issue_pending(struct dma_chan *chan)
 	}
 }
 
-static inline void __ioat2_dma_memcpy_issue_pending(
-						struct ioat_dma_chan *ioat_chan)
-{
-	ioat_chan->pending = 0;
-	writew(ioat_chan->dmacount,
-	       ioat_chan->reg_base + IOAT_CHAN_DMACOUNT_OFFSET);
-}
-
 static void ioat2_dma_memcpy_issue_pending(struct dma_chan *chan)
 {
 	struct ioat_dma_chan *ioat_chan = to_ioat_chan(chan);

Cheers

Signature · 4 lines

S.Çağlar Onur <[email protected]>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

Nelson, Shannon

2007-12-14 19:58 UTC #1 lore raw

Quoted 26 lines

-----Original Message-----
From: S.Çağlar Onur [mailto:[email protected]]
Sent: Friday, December 14, 2007 11:45 AM
To: [email protected]
Cc: Nelson, Shannon
Subject: [PATCH] drivers/dma/ioat_dma.c: inlining failed
Hi;
After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves following compiliation error with gcc-3.4.6. Following patch solves this issue for me;
[...]
CC [M] drivers/dma/ioat.o
CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Quoted 1 line

Signed-off-by S.Çağlar Onur <[email protected]>

[...]

Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336

sln
--
======================================================================
Mr. Shannon Nelson LAN Access Division, Intel Corp.
[email protected] I don't speak for Intel
(503) 712-7659 Parents can't afford to be squeamish.

Andrew Morton

2007-12-14 23:16 UTC #2 lore raw

Quoted 26 lines · Shannon

Quoted 26 lines
-----Original Message-----
From: S.__a__lar Onur [mailto:[email protected]]
Sent: Friday, December 14, 2007 11:45 AM
To: [email protected]
Cc: Nelson, Shannon
Subject: [PATCH] drivers/dma/ioat_dma.c: inlining failed
Hi;
After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves following compiliation error with gcc-3.4.6. Following patch solves this issue for me;
[...]
CC [M] drivers/dma/ioat.o
CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Quoted 5 lines

Quoted 1 line
Signed-off-by S.__a__lar Onur <[email protected]>
[...]
Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336

Nobody told me that it fixed anything serious so I had it scheduled for 2.6.25. I'll move it up.

Mariusz Kozlowski

2008-01-06 12:57 UTC #3 lore raw

Hello,

Quoted 17 lines

Quoted 17 lines
Quoted 17 lines
After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves following compiliation error with gcc-3.4.6. Following patch solves this issue for me;
[...]
CC [M] drivers/dma/ioat.o
CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
Signed-off-by S.__a__lar Onur <[email protected]>
[...]
Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336
Nobody told me that it fixed anything serious so I had it scheduled for 2.6.25. I'll move it up.

BTW. It's still not there. Latest Linus linux-2.6 git tree with gcc-3.4.6:

CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
make[2]: *** [drivers/dma/ioat_dma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2

Regards,

Mariusz

Adrian Bunk

2008-01-06 13:04 UTC #4 lore raw

Quoted 30 lines · Mariusz Kozlowski

Hello,
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
After commit 7bb67c14fd3778504fb77da30ce11582336dfced, Linus's git tree gaves following compiliation error with gcc-3.4.6. Following patch solves this issue for me;
[...]
CC [M] drivers/dma/ioat.o
CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available
drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here make[2]: *** [drivers/dma/ioat_dma.o] Hata 1
make[1]: *** [drivers/dma] Hata 2
make: *** [drivers] Hata 2
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by S.__a__lar Onur <[email protected]>
[...]
Yep. I posted a similar patch with a couple more tweaks after a month ago after Andrew's comments, which hasn't yet moved from -mm to Linus' tree. See http://lkml.org/lkml/2007/11/16/336
Nobody told me that it fixed anything serious so I had it scheduled for 2.6.25. I'll move it up.
BTW. It's still not there. Latest Linus linux-2.6 git tree with gcc-3.4.6:

Quoted 7 lines

CC [M] drivers/dma/ioat_dma.o
drivers/dma/ioat_dma.c: In function `ioat1_tx_submit':
drivers/dma/ioat_dma.c:177: sorry, unimplemented: inlining failed in call to '__ioat1_dma_memcpy_issue_pending': function body not available drivers/dma/ioat_dma.c:268: sorry, unimplemented: called from here
make[2]: *** [drivers/dma/ioat_dma.o] Error 1
make[1]: *** [drivers/dma] Error 2
make: *** [drivers] Error 2

The fix is in Linus' tree since 17 Dec 2007, and the line numbers in your error messages also don't make sense in the current tree.

Is there any problem with your local copy of the tree?

Quoted 3 lines

Regards,
Mariusz

cu
Adrian

Signature · 4 lines

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Mariusz Kozlowski

2008-01-06 15:19 UTC #5 lore raw

Hello,

Quoted 2 lines

The fix is in Linus' tree since 17 Dec 2007, and the line numbers in your error messages also don't make sense in the current tree.

True.

Quoted 1 line

Is there any problem with your local copy of the tree?

Oh crap ... how could this happen? I'd say it is my git & branches PEBKAC.

Regards,

Mariusz