Skip to contentSkip to conversation

x86-64: also define AT_VECTOR_SIZE_ARCH

PATCH In review Jan Beulich 2 participants 4 messages Dec 10, 2007 – Dec 17, 2007

lore
Share & tools
lore

Jan Beulich

author
#0 lore raw

PATCH 1/1 x86-64: also define AT_VECTOR_SIZE_ARCH

The patch introducing this left out x86-64, despite it also having extra entries.

Signed-off-by Jan Beulich <[email protected]>
Cc Olaf Hering <[email protected]>
 include/asm-x86/system_64.h |    6 ++++++
 1 file changed, 6 insertions(+)
include/asm-x86/system_64.h +6 -0
@@ -7,6 +7,12 @@
 
 #ifdef __KERNEL__
 
+#ifdef CONFIG_IA32_EMULATION
+#define AT_VECTOR_SIZE_ARCH 2
+#else
+#define AT_VECTOR_SIZE_ARCH 1
+#endif
+
 #define __SAVE(reg,offset) "movq %%" #reg ",(14-" #offset ")*8(%%rsp)\n\t"
 #define __RESTORE(reg,offset) "movq (14-" #offset ")*8(%%rsp),%%" #reg "\n\t"
#1 lore raw
Quoted 2 lines · Jan Beulich

The patch introducing this left out x86-64, despite it also having extra entries.

thanks, applied. Is there any 2.6.24 urgency for this?

Ingo

author
#2 lore raw
Quoted 8 lines
Quoted 1 line
Quoted 1 line

Ingo Molnar <[email protected]> 17.12.07 14:42 >>>

Quoted 2 lines · Jan Beulich

The patch introducing this left out x86-64, despite it also having extra entries.

thanks, applied. Is there any 2.6.24 urgency for this?

While I haven't seen x86-64 to break due to this (it appears that 32-bit apps would be more susceptible), I know that we had major problems with the respective piece missing from the 32-bit Xen kernels in openSuSE 10.3, so I would strongly suggest putting this into .24.

Jan

#3 lore raw
Quoted 7 lines · Jan Beulich
Quoted 7 lines
Quoted 1 line
Quoted 1 line

Ingo Molnar <[email protected]> 17.12.07 14:42 >>>

Quoted 2 lines · Jan Beulich

The patch introducing this left out x86-64, despite it also having extra entries.

Quoted 6 lines
Quoted 1 line

thanks, applied. Is there any 2.6.24 urgency for this?

While I haven't seen x86-64 to break due to this (it appears that 32-bit apps would be more susceptible), I know that we had major problems with the respective piece missing from the 32-bit Xen kernels in openSuSE 10.3, so I would strongly suggest putting this into .24.

ok, queued it up for the next push.

Ingo