Skip to contentSkip to conversation

ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X

PATCH In review Kyungmin Park 2 participants 2 messages Dec 18, 2007

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 ARM: OMAP: Remove undefined CONFIG_ARCH_OMAP242X

Remove undefined CONFIG_ARCH_OMAP242X.
It boots on locked SRAM board.

Comment from Tony.
Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be needed here. If not selected, the cpu_is_omapxxxx() functions are if (0) {} functions and get optimized out.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/plat-omap/sram.c +0 -2
index afe8181..c377cb0 100644
@@ -91,11 +91,9 @@ static int is_sram_locked(void)
 {
 	int type = 0;
 
-#if defined(CONFIG_ARCH_OMAP242X)
 	if (cpu_is_omap242x())
 		type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
 			OMAP2_DEVICETYPE_MASK);
-#endif
 
 	if (type == GP_DEVICE) {
 		/* RAMFW: R/W access to all initiators for all qualifier sets */
#1 lore raw
Quoted 16 lines · Kyungmin Park

Remove undefined CONFIG_ARCH_OMAP242X.
It boots on locked SRAM board.

Comment from Tony.
Additionally the #if defined(CONFIG_ARCH_OMAP242X) should not be needed here. If not selected, the cpu_is_omapxxxx() functions are if (0) {} functions and get optimized out.

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/plat-omap/sram.c +0 -0
index afe8181..c377cb0 100644
@@ -91,11 +91,9 @@ static int is_sram_locked(void)
 {

arch/arm/plat-omap/sram.c static int is_sram_locked(void) · line 99

Quoted 10 lines
arch/arm/plat-omap/sram.c +0 -2
 	int type = 0;
 
-#if defined(CONFIG_ARCH_OMAP242X)
 	if (cpu_is_omap242x())
 		type = (ctrl_read_reg(OMAP24XX_CONTROL_STATUS) &
 			OMAP2_DEVICETYPE_MASK);
-#endif
 
 	if (type == GP_DEVICE) {
 		/* RAMFW: R/W access to all initiators for all qualifier sets */

Pushing today.

Tony