Skip to contentSkip to conversation

Avoid two divides in tcp_output.c

TCP Applied Eric Dumazet 2 participants 2 messages Dec 21, 2007

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Because 'free_space' variable in __tcp_select_window() is signed, expression (free_space / 2) forces compiler to emit an integer divide.

This can be changed to a plain right shift, less expensive.

net/ipv4/tcp_output.c +2 -2
index 7c50271..9a9510a 100644
@@ -1627,7 +1627,7 @@ u32 __tcp_select_window(struct sock *sk)
 	if (mss > full_space)
 		mss = full_space;
 
-	if (free_space < full_space/2) {
+	if (free_space < (full_space >> 1)) {
 		icsk->icsk_ack.quick = 0;
 
 		if (tcp_memory_pressure)
@@ -1666,7 +1666,7 @@ u32 __tcp_select_window(struct sock *sk)
 		if (window <= free_space - mss || window > free_space)
 			window = (free_space/mss)*mss;
 		else if (mss == full_space &&
-			 free_space > window + full_space/2)
+			 free_space > window + (full_space >> 1))
 			window = free_space;
 	}
 
maintainer Applied
#1 lore raw

From: Eric Dumazet <[email protected]>
Date: Fri, 21 Dec 2007 06:34:28 +0100

Quoted 6 lines

Because 'free_space' variable in __tcp_select_window() is signed, expression (free_space / 2) forces compiler to emit an integer divide.

This can be changed to a plain right shift, less expensive.

Applied to net-2.6.25, thanks Eric.