Skip to contentSkip to conversation

alpha/parisc: Removing config variable DEBUG_RWLOCK

PATCH In review Jiri Olsa 5 participants 8 messages Nov 15, 2007 – Dec 20, 2007

Subsystems (3)
Kernel janitors PA-RISC architecture Alpha port
lore
Share & tools
lore

Jiri Olsa

author
#0 lore raw

PATCH 1/1 alpha/parisc: Removing config variable DEBUG_RWLOCK

Removing config variable DEBUG_RWLOCK, since it is not used

Signed-off-by Jiri Olsa <[email protected]>
---
 arch/alpha/Kconfig.debug           |    9 ---------
 arch/alpha/defconfig               |    1 -
 arch/parisc/Kconfig.debug          |    9 ---------
 arch/parisc/configs/a500_defconfig |    1 -
 4 files changed, 0 insertions(+), 20 deletions(-)
arch/alpha/Kconfig.debug +0 -9
index f45f28c..3f6265f 100644
@@ -7,15 +7,6 @@ config EARLY_PRINTK
 	depends on ALPHA_GENERIC || ALPHA_SRM
 	default y
 
-config DEBUG_RWLOCK
-	bool "Read-write spinlock debugging"
-	depends on DEBUG_KERNEL
-	help
-	  If you say Y here then read-write lock processing will count how many
-	  times it has tried to get the lock and issue an error message after
-	  too many attempts.  If you suspect a rwlock problem or a kernel
-	  hacker asks for this option then say Y.  Otherwise say N.
-
 config ALPHA_LEGACY_START_ADDRESS
 	bool "Legacy kernel start address"
 	depends on ALPHA_GENERIC
arch/alpha/defconfig +0 -1
index 6da9c3d..e43f68f 100644
@@ -882,7 +882,6 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_DEBUG_SPINLOCK is not set
 CONFIG_DEBUG_INFO=y
 CONFIG_EARLY_PRINTK=y
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_SEMAPHORE is not set
 CONFIG_ALPHA_LEGACY_START_ADDRESS=y
 CONFIG_MATHEMU=y
arch/parisc/Kconfig.debug +0 -9
index 9166bd1..bc989e5 100644
@@ -2,15 +2,6 @@ menu "Kernel hacking"
 
 source "lib/Kconfig.debug"
 
-config DEBUG_RWLOCK
-        bool "Read-write spinlock debugging"
-        depends on DEBUG_KERNEL && SMP
-        help
-          If you say Y here then read-write lock processing will count how many
-          times it has tried to get the lock and issue an error message after
-          too many attempts.  If you suspect a rwlock problem or a kernel
-          hacker asks for this option then say Y.  Otherwise say N.
-
 config DEBUG_RODATA
        bool "Write protect kernel read-only data structures"
        depends on DEBUG_KERNEL
arch/parisc/configs/a500_defconfig +0 -1
index ea07121..ddacc72 100644
@@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
 CONFIG_FORCED_INLINING=y
 # CONFIG_RCU_TORTURE_TEST is not set
 # CONFIG_FAULT_INJECTION is not set
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_RODATA is not set
 
 #
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Jiri Olsa

Removing config variable DEBUG_RWLOCK, since it is not used

Signed-off-by Jiri Olsa <[email protected]>

For the arch/parisc bit:

Acked-by Grant Grundler <[email protected]>

thanks,
grant

Quoted 71 lines
---
 arch/alpha/Kconfig.debug           |    9 ---------
 arch/alpha/defconfig               |    1 -
 arch/parisc/Kconfig.debug          |    9 ---------
 arch/parisc/configs/a500_defconfig |    1 -
 4 files changed, 0 insertions(+), 20 deletions(-)
arch/alpha/Kconfig.debug +0 -9
index f45f28c..3f6265f 100644
@@ -7,15 +7,6 @@ config EARLY_PRINTK
 	depends on ALPHA_GENERIC || ALPHA_SRM
 	default y
 
-config DEBUG_RWLOCK
-	bool "Read-write spinlock debugging"
-	depends on DEBUG_KERNEL
-	help
-	  If you say Y here then read-write lock processing will count how many
-	  times it has tried to get the lock and issue an error message after
-	  too many attempts.  If you suspect a rwlock problem or a kernel
-	  hacker asks for this option then say Y.  Otherwise say N.
-
 config ALPHA_LEGACY_START_ADDRESS
 	bool "Legacy kernel start address"
 	depends on ALPHA_GENERIC
arch/alpha/defconfig +0 -1
index 6da9c3d..e43f68f 100644
@@ -882,7 +882,6 @@ CONFIG_MAGIC_SYSRQ=y
 # CONFIG_DEBUG_SPINLOCK is not set
 CONFIG_DEBUG_INFO=y
 CONFIG_EARLY_PRINTK=y
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_SEMAPHORE is not set
 CONFIG_ALPHA_LEGACY_START_ADDRESS=y
 CONFIG_MATHEMU=y
arch/parisc/Kconfig.debug +0 -9
index 9166bd1..bc989e5 100644
@@ -2,15 +2,6 @@ menu "Kernel hacking"
 
 source "lib/Kconfig.debug"
 
-config DEBUG_RWLOCK
-        bool "Read-write spinlock debugging"
-        depends on DEBUG_KERNEL && SMP
-        help
-          If you say Y here then read-write lock processing will count how many
-          times it has tried to get the lock and issue an error message after
-          too many attempts.  If you suspect a rwlock problem or a kernel
-          hacker asks for this option then say Y.  Otherwise say N.
-
 config DEBUG_RODATA
        bool "Write protect kernel read-only data structures"
        depends on DEBUG_KERNEL
arch/parisc/configs/a500_defconfig +0 -1
index ea07121..ddacc72 100644
@@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
 CONFIG_FORCED_INLINING=y
 # CONFIG_RCU_TORTURE_TEST is not set
 # CONFIG_FAULT_INJECTION is not set
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_RODATA is not set
 
 #
#2 lore raw
Quoted 2 lines · Grant Grundler
Quoted 1 line · Jiri Olsa

Removing config variable DEBUG_RWLOCK, since it is not used

... snip ...

Quoted 10 lines

arch/parisc/configs/a500_defconfig CONFIG_SCHED_DEBUG=y · line 1053

Quoted 10 lines
arch/parisc/configs/a500_defconfig +0 -1
index ea07121..ddacc72 100644
@@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
 CONFIG_FORCED_INLINING=y
 # CONFIG_RCU_TORTURE_TEST is not set
 # CONFIG_FAULT_INJECTION is not set
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_RODATA is not set

IIRC, you typically don't bother fixing up the defconfig files -- those will be regenerated eventually.

rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA

http://crashcourse.ca
====================================

author
#3 lore raw
Quoted 7 lines · Robert P. J. Day
Quoted 2 lines · Grant Grundler
Quoted 1 line · Jiri Olsa

Removing config variable DEBUG_RWLOCK, since it is not used

... snip ...

Quoted 13 lines
Quoted 10 lines

arch/parisc/configs/a500_defconfig CONFIG_SCHED_DEBUG=y · line 1053

Quoted 10 lines
arch/parisc/configs/a500_defconfig +0 -1
index ea07121..ddacc72 100644
@@ -1050,7 +1050,6 @@ CONFIG_SCHED_DEBUG=y
 CONFIG_FORCED_INLINING=y
 # CONFIG_RCU_TORTURE_TEST is not set
 # CONFIG_FAULT_INJECTION is not set
-# CONFIG_DEBUG_RWLOCK is not set
 # CONFIG_DEBUG_RODATA is not set

IIRC, you typically don't bother fixing up the defconfig files -- those will be regenerated eventually.

I think they are part of repository... I'll check

Quoted 11 lines

rday
--
====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA

http://crashcourse.ca
====================================

#4 lore raw
Quoted 6 lines · Jiri Olsa
Quoted 2 lines · Robert P. J. Day

IIRC, you typically don't bother fixing up the defconfig files -- those will be regenerated eventually.

I think they are part of repository... I'll check

yes, they're part of the repository but, as it was once explained to me, they're autogenerated on a regular basis so, once there's no remaining references to a Kconfig variable, the corresponding entries in the defconfig files should eventually go away automatically. ergo, don't spend any time trying to clean them up.

rday
--

====================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA

http://crashcourse.ca
====================================

#5 lore raw
In reply to Robert P. J. Day

On Thu, Nov 15, 2007 at 02:54:45PM -0500, Robert P. J. Day wrote:
...

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines

-# CONFIG_DEBUG_RWLOCK is not set
# CONFIG_DEBUG_RODATA is not set

IIRC, you typically don't bother fixing up the defconfig files -- those will be regenerated eventually.

It's not automatic though. So I don't mind the update.

thanks,
grant

#7 lore raw

Re: [parisc-linux] [PATCH] alpha/parisc: Removing config variable

In reply to Jiri Olsa
Quoted 10 lines · On Thu, 20 Dec 2007 12:07:00 -0500 Kyle McMartin <[email protected]> wrote:
Quoted 3 lines · Jiri Olsa

Removing config variable DEBUG_RWLOCK, since it is not used

Signed-off-by Jiri Olsa <[email protected]>

ack.

Andrew, should I apply the parisc half of this, or do you want to queue the whole patch?

I can take care of it. Jiri, next time please do this sort of thing as separate patches: alpha and parisc changes get into the mainline tree via different routes (ie: via different maintainer trees).

Thanks.