e1000e: Use deferrable timer for watchdog
Subsystems (2)
PATCH 1/2 e1000e: Use deferrable timer for watchdog
From: Parag Warudkar <[email protected]>
Reduce wakeups from idle per second.
Signed-off-by Parag Warudkar <[email protected]>
Signed-off-by Auke Kok <[email protected]>
---
drivers/net/e1000e/netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000e/netdev.c +1 -1
@@ -3931,7 +3931,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev, goto err_eeprom; } -init_timer (&adapter->watchdog_timer); +init_timer_deferrable (&adapter->watchdog_timer); adapter->watchdog_timer.function = &e1000_watchdog; adapter->watchdog_timer.data = (unsigned long ) adapter;
PATCH 2/2 e1000: Use deferrable timer for watchdog
From: Parag Warudkar <[email protected]>
Reduces wakeups from idle per second.
Signed-off-by Parag Warudkar <[email protected]>
Signed-off-by Auke Kok <[email protected]>
---
drivers/net/e1000/e1000_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000/e1000_main.c +1 -1
@@ -1066,7 +1066,7 @@ e1000_probe(struct pci_dev *pdev, adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall; adapter->tx_fifo_stall_timer.data = (unsigned long ) adapter; -init_timer (&adapter->watchdog_timer); +init_timer_deferrable (&adapter->watchdog_timer); adapter->watchdog_timer.function = &e1000_watchdog; adapter->watchdog_timer.data = (unsigned long ) adapter;
Quoted 7 lines · Auke Kok
From: Parag Warudkar <[email protected]>
Reduce wakeups from idle per second.
Signed-off-by Parag Warudkar <[email protected]>Signed-off-by Auke Kok <[email protected]>---
Jeff,
given the discussion with Stephen I'd like to skip merging this patch and the e1000 one for now. The unforeseen implications of this are just not controlled enough and we need to guarantee some limit of deferral first.
Auke