Skip to contentSkip to conversation

bamboo: remove bogus "ranges" property in EBC node

PATCH In review Benjamin Herrenschmidt 2 participants 4 messages Dec 21, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 18/21 bamboo: remove bogus "ranges" property in EBC node

This removes a bogus empty "ranges" property in the EBC device node of the Bamboo board device-tree.

The "ranges" property will be created by the boot wrapper, there is no need to have an empty property there, and that causes recent dtc to complain.

---

 arch/powerpc/boot/dts/bamboo.dts |    1 -
 1 file changed, 1 deletion(-)
arch/powerpc/boot/dts/bamboo.dts +0 -1
@@ -126,7 +126,6 @@
 				#address-cells = <2>;
 				#size-cells = <1>;
 				clock-frequency = <0>; /* Filled in by zImage */
-				ranges;
 				interrupts = <5 1>;
 				interrupt-parent = <&UIC1>;
 			};
#1 lore raw
Quoted 6 lines · On Fri, 21 Dec 2007 15:39:35 +1100 Benjamin Herrenschmidt…

This removes a bogus empty "ranges" property in the EBC device node of the Bamboo board device-tree.

The "ranges" property will be created by the boot wrapper, there is no need to have an empty property there, and that causes recent dtc to complain.

The wrapper doesn't do anything with EBC for bamboo because the EBC stuff is a nightmare on this board. The patch can stand, but I'll fixup the comments in the changelog.

josh

#2 lore raw
Quoted 6 lines · Josh Boyer
Quoted 3 lines · On Fri, 21 Dec 2007 15:39:35 +1100 Benjamin Herrenschmidt…

This removes a bogus empty "ranges" property in the EBC device node of the Bamboo board device-tree.

Quoted 7 lines
Quoted 3 lines

The "ranges" property will be created by the boot wrapper, there is no need to have an empty property there, and that causes recent dtc to complain.

The wrapper doesn't do anything with EBC for bamboo because the EBC stuff is a nightmare on this board. The patch can stand, but I'll fixup the comments in the changelog.

The wrapper could still create ranges for the chip select settings no ?

In any case, empty "ranges" is bogus.

Ben.

#3 lore raw
Quoted 12 lines · On Sat, 22 Dec 2007 08:16:55 +1100 Benjamin Herrenschmidt…
Quoted 10 lines · Josh Boyer
Quoted 6 lines · On Fri, 21 Dec 2007 15:39:35 +1100 Benjamin Herrenschmidt…

This removes a bogus empty "ranges" property in the EBC device node of the Bamboo board device-tree.

The "ranges" property will be created by the boot wrapper, there is no need to have an empty property there, and that causes recent dtc to complain.

Quoted 5 lines
Quoted 3 lines

The wrapper doesn't do anything with EBC for bamboo because the EBC stuff is a nightmare on this board. The patch can stand, but I'll fixup the comments in the changelog.

The wrapper could still create ranges for the chip select settings no ?

It could. It doesn't though. Perhaps our interpretation of "will be created" differed.

Quoted 1 line

In any case, empty "ranges" is bogus.

Correct. Which is why I said I'd just edit the changelog :).

josh