Do not fail build if mkimage is not available

PATCH In review Michael Buesch 2 participants 3 messages Dec 23, 2007 PowerPC

Share & tools

Michael Buesch

author

2007-12-23 19:57 UTC #0 lore raw

PATCH 1/1 Do not fail build if mkimage is not available

This fixes the boot image wrapper script to not fail the kernel build if mkimage is not available.
As some distributions don't ship the mkimage program and I am not interested in uboot images anyway, I don't want to fail the whole kernel build process because of this unneeded dependency.

Simply drop an error message, but don't fail the build.

Signed-off-by Michael Buesch <[email protected]>

arch/powerpc/boot/wrapper +8 -0

Index: wireless-2.6/arch/powerpc/boot/wrapper
===================================================================
@@ -195,6 +195,14 @@ if [ -n "$version" ]; then
 fi
 
 case "$platform" in
+cuboot* | uboot)
+    if ! [ -x mkimage ]; then
+        echo "mkimage not available. Can not create $platform image."
+        exit 0
+    fi
+esac
+
+case "$platform" in
 uboot)
     rm -f "$ofile"
     mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \

Josh Boyer

2007-12-23 20:05 UTC #1 lore raw

Quoted 7 lines · On Sun, 23 Dec 2007 20:31:08 +0100 Michael Buesch <[email protected]> wrote:

This fixes the boot image wrapper script to not fail the kernel build if mkimage is not available.
As some distributions don't ship the mkimage program and I am not interested in uboot images anyway, I don't want to fail the whole kernel build process because of this unneeded dependency.
Simply drop an error message, but don't fail the build.

This is probably OK for now, but I'm working on getting mkimage merged into the kernel so it will just get ripped back out later if I'm successful.

josh

Michael Buesch

author

2007-12-23 21:23 UTC #2 lore raw

Quoted 9 lines · On Sunday 23 December 2007 21:05:16 Josh Boyer wrote:

Quoted 6 lines · On Sun, 23 Dec 2007 20:31:08 +0100 Michael Buesch <[email protected]> wrote:
This fixes the boot image wrapper script to not fail the kernel build if mkimage is not available.
As some distributions don't ship the mkimage program and I am not interested in uboot images anyway, I don't want to fail the whole kernel build process because of this unneeded dependency.

Quoted 5 lines

Quoted 1 line
Simply drop an error message, but don't fail the build.
This is probably OK for now, but I'm working on getting mkimage merged into the kernel so it will just get ripped back out later if I'm successful.

Yeah, cool. I am fine with this. :)

I just don't want to install a tool into my operating system that I do not need. Shipping it with the kernel is the best option.

Signature · 1 line

Greetings Michael.