Skip to contentSkip to conversation

Build breakage on powerpc with 2.6.24-rc6-mm1

PATCH Balbir Singh 4 participants 4 messages Dec 23, 2007 – Dec 24, 2007 Network drivers

lore
Share & tools
lore
#0 lore raw

Hi,

I see the following error with the iseries_veth driver in 2.6.24-rc6-mm1

drivers/net/iseries_veth.c: In function ‘veth_init_connection’:
drivers/net/iseries_veth.c:818: warning: unused variable ‘rc’ drivers/net/iseries_veth.c: In function ‘veth_probe_one’:
drivers/net/iseries_veth.c:1086: error: ‘veth_port_ktypeq’ undeclared (first use in this function) drivers/net/iseries_veth.c:1086: error: (Each undeclared identifier is reported only once
drivers/net/iseries_veth.c:1086: error: for each function it appears in.)
make[2]: *** [drivers/net/iseries_veth.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Here's a patch, compile tested to fix the compilation problem

Remove unused variable rc and fix a typo, veth_port_type was called veth_port_typeq

---

 drivers/net/iseries_veth.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/iseries_veth.c renamed from drivers/net/iseries_veth.c~fix-iseries-veth-driver +2 -2
diff -puN drivers/net/iseries_veth.c~fix-iseries-veth-driver drivers/net/iseries_veth.c
@@ -815,7 +815,7 @@ static int veth_init_connection(u8 rlp)
 {
 	struct veth_lpar_connection *cnx;
 	struct veth_msg *msgs;
-	int i, rc;
+	int i;
 
 	if ( (rlp == this_lp)
 	     || ! HvLpConfig_doLpsCommunicateOnVirtualLan(this_lp, rlp) )
@@ -1083,7 +1083,7 @@ static struct net_device * __init veth_p
 		return NULL;
 	}
 
-	kobject_init(&port->kobject, &veth_port_ktypeq);
+	kobject_init(&port->kobject, &veth_port_ktype);
 	if (0 != kobject_add(&port->kobject, &dev->dev.kobj, "veth_port"))
 		veth_error("Failed adding port for %s to sysfs.\n", dev->name);
 

_

Signature · 4 lines
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
#1 lore raw

Hi Balbir,

Thanks for the report.

Quoted 15 lines · On Mon, 24 Dec 2007 04:11:58 +0530 Balbir Singh <[email protected]>…

I see the following error with the iseries_veth driver in 2.6.24-rc6-mm1

drivers/net/iseries_veth.c: In function ‘veth_init_connection’:
drivers/net/iseries_veth.c:818: warning: unused variable ‘rc’ drivers/net/iseries_veth.c: In function ‘veth_probe_one’:
drivers/net/iseries_veth.c:1086: error: ‘veth_port_ktypeq’ undeclared (first use in this function) drivers/net/iseries_veth.c:1086: error: (Each undeclared identifier is reported only once
drivers/net/iseries_veth.c:1086: error: for each function it appears in.)
make[2]: *** [drivers/net/iseries_veth.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Yeah, that would be gregkh-driver-kobject-convert-drivers-net-iseries_vethc-to-use-kobject_init-add_ng.

Hi Greg, do you even build with your patches applied?

Quoted 1 line

Here's a patch, compile tested to fix the compilation problem

Hopefully Greg will fix his original patch before it reaches Linus.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw
Quoted 20 lines · Stephen Rothwell

Hi Balbir,

Thanks for the report.

Quoted 15 lines · On Mon, 24 Dec 2007 04:11:58 +0530 Balbir Singh <[email protected]>…

I see the following error with the iseries_veth driver in 2.6.24-rc6-mm1

drivers/net/iseries_veth.c: In function ‘veth_init_connection’:
drivers/net/iseries_veth.c:818: warning: unused variable ‘rc’ drivers/net/iseries_veth.c: In function ‘veth_probe_one’:
drivers/net/iseries_veth.c:1086: error: ‘veth_port_ktypeq’ undeclared (first use in this function) drivers/net/iseries_veth.c:1086: error: (Each undeclared identifier is reported only once
drivers/net/iseries_veth.c:1086: error: for each function it appears in.)
make[2]: *** [drivers/net/iseries_veth.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

Thanks for the report, sorry for the typos, I'll fix up my patch.

Quoted 4 lines

Yeah, that would be gregkh-driver-kobject-convert-drivers-net-iseries_vethc-to-use-kobject_init-add_ng.

Hi Greg, do you even build with your patches applied?

For the power architecture, no, I do not. I used to, but my cross-build box died and I haven't taken the time to set it all up again. For i386 and x86-64 I do build everything, and as that's 99% of the users, it's usually fine :)

I did start to try to get a s390 cross-build working, but ran out of time a week or so ago...

Quoted 3 lines
Quoted 1 line

Here's a patch, compile tested to fix the compilation problem

Hopefully Greg will fix his original patch before it reaches Linus.

I will do that.

thanks,

greg k-h

#3 lore raw
Quoted 4 lines · Greg KH
Quoted 1 line

Hi Greg, do you even build with your patches applied?

For the power architecture, no, I do not. I used to, but my cross-build box died and I haven't taken the time to set it all up again.

Crosstool makes it really easy. It's demo-powerpc-970.sh will build a toolchain that can build both 32- and 64-bit powerpc kernels. It's got a demo-s390.sh as well, but I haven't tried that one myself.

-Olof