Add information on enabling sound on the MPC8641 HPCN
Subsystems (2)
PATCH 1/1 Add information on enabling sound on the MPC8641 HPCN
Add a comment to the DTS file for the MPC8641 HPCN describing a wiring change needed to get sound working on this board.
---
For a two-line comment, I thought the DTS would be the best place to put this information.
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8641_hpcn.dts +3 -0
@@ -7,6 +7,9 @@ * under the terms of the GNU General Public License as published by the * Free Software Foundation; either version 2 of the License, or (at your * option) any later version. + * + * On some revisions of this board, C29 of the Uli M1575 must be connected + * to ground (e.g. ground of resistor R353) in order to enable sound. */
Signature · 1 line
1.5.2.4
Quoted 8 lines · Timur Tabi
Add a comment to the DTS file for the MPC8641 HPCN describing a wiring change needed to get sound working on this board.
Signed-off-by Timur Tabi <[email protected]>---
For a two-line comment, I thought the DTS would be the best place to put this information.
Sounds like a board rework document on your support site is the right place for this. We normally don't document board reworks required in the linux sources, do we?
-Olof
Quoted 2 lines · Olof Johansson
Sounds like a board rework document on your support site is the right place for this.
Except that no one would know to look there. I don't even know who to contact to get that kind of information on that site.
Quoted 2 lines
We normally don't document board reworks required in the linux sources, do we?
I do, if I can find a discrete place for it. The patch for my QE UART driver has a similar comment in the DTS for the 8323E MDS.
Quoted 6 lines · Timur Tabi
Quoted 2 lines · Olof Johansson
Sounds like a board rework document on your support site is the right place for this.
Except that no one would know to look there.
Why do you expect people to look at the device tree source file instead? It seems even more remote to me.
Quoted 2 lines
I don't even know who to contact to get that kind of information on that site.
That's a pretty lame excuse. :)
Quoted 5 lines
Quoted 2 lines
We normally don't document board reworks required in the linux sources, do we?
I do, if I can find a discrete place for it. The patch for my QE UART driver has a similar comment in the DTS for the 8323E MDS.
Are freescale customers really used to going to the linux device tree sources to find out how to modify their boards to achieve certain functionality with their eval boards?! I guess you guys are taking the "device trees are used to describe the hardware" statement to it's fullest extent.
-Olof
Quoted 5 lines · Olof Johansson
Are freescale customers really used to going to the linux device tree sources to find out how to modify their boards to achieve certain functionality with their eval boards?! I guess you guys are taking the "device trees are used to describe the hardware" statement to it's fullest extent.
Well, I've always been a rebel.
Honestly, I just thought it would be harmless and a lot easier (for me) than trying to convince some documentation dude to write it up and publish it.
Quoted 8 lines · Timur Tabi
Quoted 5 lines · Olof Johansson
Are freescale customers really used to going to the linux device tree sources to find out how to modify their boards to achieve certain functionality with their eval boards?! I guess you guys are taking the "device trees are used to describe the hardware" statement to it's fullest extent.
Quoted 5 lines
Well, I've always been a rebel.
Honestly, I just thought it would be harmless and a lot easier (for me) than trying to convince some documentation dude to write it up and publish it.
Heh. Well, it's up to Kumar what to do about this one upstream, it just seemed like a weird choice to document board reworks in the device tree comments.
Having it somewhere that sticks to google's database is better than nothing at all, I suppose. :)
-Olof