Skip to contentSkip to conversation

serial: Make default_serial_console() a weak function

PATCH RESEND New Matthias Fuchs 2 participants 2 messages Dec 27, 2007 – Jan 9, 2008

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 serial: Make default_serial_console() a weak function

With this patch it is possible to reimplement default_serial_console() in board specific code. This will be done in the upcomming PMC440 U-Boot port. This also allows the lwmon board maintainer to remove the '#if !defined(CONFIG_LWMON) ...' from common/serial.c.

---
 common/serial.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
common/serial.c +3 -1
index b9916e2..5601080 100644
@@ -33,7 +33,7 @@ static struct serial_device *serial_devices = NULL;
 static struct serial_device *serial_current = NULL;
 
 #if !defined(CONFIG_LWMON) && !defined(CONFIG_PXA27X)
-struct serial_device *default_serial_console (void)
+struct serial_device *__default_serial_console (void)
 {
 #if defined(CONFIG_8xx_CONS_SMC1) || defined(CONFIG_8xx_CONS_SMC2)
 	return &serial_smc_device;
@@ -64,6 +64,8 @@ struct serial_device *default_serial_console (void)
 #error No default console
 #endif
 }
+
+struct serial_device *default_serial_console(void) __attribute__((weak, alias("__default_serial_console")));
 #endif
 
 int serial_register (struct serial_device *dev)
Signature · 1 line
1.5.3
#1 lore raw

PATCH RESEND 1/1 serial: Make default_serial_console() a weak function

Quoted 6 lines · In message <[email protected]> you wrote:

With this patch it is possible to reimplement default_serial_console() in board specific code. This will be done in the upcomming PMC440 U-Boot port. This also allows the lwmon board maintainer to remove the '#if !defined(CONFIG_LWMON) ...' from common/serial.c.

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After Goliath's defeat, giants ceased to command respect.
- Freeman Dyson