Skip to contentSkip to conversation

ide-pmac: macio resource freeing bugfix

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Dec 30, 2007 – Jan 4, 2008

Subsystems (2)
PowerPC libata
lore
Share & tools
lore

Bartlomiej Zolnierkiewicz

author
#0 lore raw

PATCH 2/3 ide-pmac: macio resource freeing bugfix

Release DMA resource before zeroing pmif.

Cc Benjamin Herrenschmidt <[email protected]>
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
---
 drivers/ide/ppc/pmac.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ide/ppc/pmac.c +3 -3
Index: b/drivers/ide/ppc/pmac.c
===================================================================
@@ -1228,12 +1228,12 @@ pmac_ide_macio_attach(struct macio_dev *
 		/* The inteface is released to the common IDE layer */
 		dev_set_drvdata(&mdev->ofdev.dev, NULL);
 		iounmap(base);
-		if (pmif->dma_regs)
+		if (pmif->dma_regs) {
 			iounmap(pmif->dma_regs);
+			macio_release_resource(mdev, 1);
+		}
 		memset(pmif, 0, sizeof(*pmif));
 		macio_release_resource(mdev, 0);
-		if (pmif->dma_regs)
-			macio_release_resource(mdev, 1);
 	}
 
 	return rc;