Skip to contentSkip to conversation

restore Cell OProfile support

PATCH In review Adrian Bunk 3 participants 5 messages Dec 28, 2007 – Jan 2, 2008 PowerPC

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 restore Cell OProfile support

This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.

Signed-off-by Adrian Bunk <[email protected]>

---

 kernel/Kconfig.instrumentation |    8 ++++++++
 1 file changed, 8 insertions(+)

6d1446d35d367fdbdd2a0a29e0d156646ff40630

kernel/Kconfig.instrumentation +8 -0
index a76635d..9d143e6 100644
@@ -53,2 +53,10 @@ config HARDWARE_PM
 
+config OPROFILE_CELL
+	bool "OProfile for Cell Broadband Engine"
+	depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) 
+	default y
+	help
+	  Profiling of Cell BE SPUs requires special support enabled
+	  by this option.
+
 config KPROBES
#1 lore raw
Quoted 5 lines · * Adrian Bunk ([email protected]) wrote:

This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.

Signed-off-by Adrian Bunk <[email protected]>

Same here : why isn't this on by default when SPU_FS and OPROFILE are enabled ?

Quoted 22 lines

---

 kernel/Kconfig.instrumentation |    8 ++++++++
 1 file changed, 8 insertions(+)

6d1446d35d367fdbdd2a0a29e0d156646ff40630

kernel/Kconfig.instrumentation +8 -0
index a76635d..9d143e6 100644
@@ -53,2 +53,10 @@ config HARDWARE_PM
 
+config OPROFILE_CELL
+	bool "OProfile for Cell Broadband Engine"
+	depends on PPC && (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y) 
+	default y
+	help
+	  Profiling of Cell BE SPUs requires special support enabled
+	  by this option.
+
 config KPROBES
Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
#2 lore raw

PATCH 1/1 Fix Cell OProfile support

In reply to Adrian Bunk

This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.

It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave this as a supplementary user-selectable option, it is now automatically enabled whenever SPU_FS and OPROFILE are enabled.

Signed-off-by Mathieu Desnoyers <[email protected]>
CC Adrian Bunk <[email protected]>
CC Randy Dunlap <[email protected]>
CC [email protected]
CC [email protected]
CC [email protected]
CC [email protected]
---
 arch/powerpc/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)
arch/powerpc/Kconfig +4 -0
Index: linux-2.6-lttng/arch/powerpc/Kconfig
===================================================================
@@ -163,6 +163,10 @@ config PPC_OF_PLATFORM_PCI
 	depends on PPC64 # not supported on 32 bits yet
 	default n
 
+config OPROFILE_CELL
+	def_bool y
+	depends on (SPU_FS = y && OPROFILE = m) || (SPU_FS = y && OPROFILE = y)
+
 source "init/Kconfig"
 
 source "arch/powerpc/platforms/Kconfig"
Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
#3 lore raw

Re: [2.6.24 patch] Fix Cell OProfile support

Quoted 6 lines · Mathieu Desnoyers

This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.

It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave this as a supplementary user-selectable option, it is now automatically enabled whenever SPU_FS and OPROFILE are enabled.

This one has already been superceded by the fix in aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an automatically selected option, from arch/powerpc/platforms/cell/Kconfig.

	Arnd <><
#4 lore raw

Re: [2.6.24 patch] Fix Cell OProfile support

Quoted 4 lines · * Arnd Bergmann ([email protected]) wrote:
Quoted 3 lines · Mathieu Desnoyers

This patch restores the Cell OProfile support that was killed by commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.

Quoted 8 lines
Quoted 3 lines

It puts it in arch/powerpc/Kconfig. Since I don't see any good reason to leave this as a supplementary user-selectable option, it is now automatically enabled whenever SPU_FS and OPROFILE are enabled.

This one has already been superceded by the fix in aed3a8c9bb1a8623a618232087c5ff62718e3b9a, which made CONFIG_OPROFILE_CELL an automatically selected option, from arch/powerpc/platforms/cell/Kconfig.

Great, so my patch should be dropped. Thanks!

Mathieu

Quoted 7 lines
	Arnd <><

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68