Skip to contentSkip to conversation

CIFS: #if 0 mode_to_access_flags()

PATCH In review Adrian Bunk 3 participants 3 messages Jan 1, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CIFS: #if 0 mode_to_access_flags()

This patch #if 0's the unused mode_to_access_flags(), fixing the following compile warning:

<-- snip -->

...
CC fs/cifs/cifsacl.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/cifs/cifsacl.c:200: warning: ‘mode_to_access_flags’ defined but not used
...

<-- snip -->

---

 fs/cifs/cifsacl.c |    2 ++
 1 file changed, 2 insertions(+)

0cf530f754b974ee5e58b3346828bb5586440c92

fs/cifs/cifsacl.c +2 -0
index c312adc..771a22f 100644
@@ -189,6 +189,7 @@ static void access_flags_to_mode(__le32 ace_flags, int type, umode_t *pmode,
 	return;
 }
 
+#if 0
 /*
    Generate access flags to reflect permissions mode is the existing mode.
    This function is called for every ACE in the DACL whose SID matches
@@ -219,6 +220,7 @@ static void mode_to_access_flags(umode_t mode, umode_t bits_to_use,
 #endif
 	return;
 }
+#endif  /*  0  */
 
 
 #ifdef CONFIG_CIFS_DEBUG2
#1 lore raw
Quoted 2 lines · Adrian Bunk

This patch #if 0's the unused mode_to_access_flags(), fixing the following compile warning:

Please remove it completely instead.

#2 lore raw

The cifsacl code which uses that function was not ready in time for 2.6.24 but is in the cifs development tree now..

Quoted 6 lines · Christoph Hellwig
Quoted 2 lines · Adrian Bunk

This patch #if 0's the unused mode_to_access_flags(), fixing the following compile warning:

Please remove it completely instead.

Signature · 3 lines
Thanks,

Steve