Skip to contentSkip to conversation

remove a.out interpreter for ELF executables

PATCH In review Adrian Bunk 4 participants 6 messages Jan 1, 2008 – Jan 6, 2008

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove a.out interpreter for ELF executables

This patch contains the scheduled removal of the a.out interpreter support for ELF executables.

---

 Documentation/feature-removal-schedule.txt |   11 -
 fs/binfmt_elf.c                            |  142 +--------------------
 2 files changed, 13 insertions(+), 140 deletions(-)

aca21a4f123d9844fc03c69c3313c5a715a2fd36

Documentation/feature-removal-schedule.txt +0 -11
index e754923..bca1eda 100644
@@ -107,17 +107,6 @@ Who:	Eric Biederman <[email protected]>
 
 ---------------------------
 
-What:  a.out interpreter support for ELF executables
-When:  2.6.25
-Files: fs/binfmt_elf.c
-Why:   Using a.out interpreters for ELF executables was a feature for
-       transition from a.out to ELF. But now it is unlikely to be still
-       needed anymore and removing it would simplify the hairy ELF
-       loader code.
-Who:   Andi Kleen <[email protected]>
-
----------------------------
-
 What:	remove EXPORT_SYMBOL(kernel_thread)
 When:	August 2006
 Files:	arch/*/kernel/*_ksyms.c
fs/binfmt_elf.c +13 -129

231 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · On Tuesday 01 January 2008 14:47:49 Adrian Bunk wrote:

This patch contains the scheduled removal of the a.out interpreter support for ELF executables.

I already have a similar patch queued

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-aout-interpreter

Also removal of the old unused iBCS hooks while I was on it

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-ibcs-support

-Andi

#2 lore raw
Quoted 4 lines · On Tue, 1 Jan 2008 15:36:32 +0100 Andi Kleen <[email protected]> wrote:
Quoted 2 lines · On Tuesday 01 January 2008 14:47:49 Adrian Bunk wrote:

This patch contains the scheduled removal of the a.out interpreter support for ELF executables.

Quoted 8 lines

I already have a similar patch queued

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-aout-interpreter

Also removal of the old unused iBCS hooks while I was on it

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-ibcs-support

Guys, please take a look at similar patches from David in -mm before even vaguely thinking of breathing anywhere in the remote vicinity of fs/binfmt_elf.c (sob).

#3 lore raw
Quoted 10 lines · Andrew Morton
Quoted 8 lines · On Tue, 1 Jan 2008 15:36:32 +0100 Andi Kleen <[email protected]> wrote:
Quoted 2 lines · On Tuesday 01 January 2008 14:47:49 Adrian Bunk wrote:

This patch contains the scheduled removal of the a.out interpreter support for ELF executables.

I already have a similar patch queued

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-aout-interpreter

Quoted 8 lines
Quoted 4 lines

Also removal of the old unused iBCS hooks while I was on it

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-ibcs-support

Guys, please take a look at similar patches from David in -mm before even vaguely thinking of breathing anywhere in the remote vicinity of fs/binfmt_elf.c (sob).

What David's patch does in fs/binfmt_elf.c is to make code conditional - exactly the code Andi removes as scheduled in 2.6.25. You should be able to simply drop the fs/binfmt_elf.c parts from aout-suppress-aout-library-support-if-config_arch_supports_aout.patch.

cu
Adrian

BTW: There are also patch conflicts with git-x86, but since they are not
from David you have yet to ask us to look at them. ;-)

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#4 lore raw
Quoted 5 lines · On Tue, 1 Jan 2008 15:36:32 +0100 Andi Kleen <[email protected]> wrote:

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-aout-interpreter

Also removal of the old unused iBCS hooks while I was on it

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-ibcs-support

Is iBCS support the basis for SCO & SVr4 support? (These both sound useful.)

#5 lore raw
Quoted 10 lines · David Newall
Quoted 5 lines · On Tue, 1 Jan 2008 15:36:32 +0100 Andi Kleen <[email protected]> wrote:

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-aout-interpreter

Also removal of the old unused iBCS hooks while I was on it

ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/remove-ibcs-support

Is iBCS support the basis for SCO & SVr4 support? (These both sound useful.)

Yes, but that always required an external patchkit which AFAIK existed only for 2.4. The point is that if you have to apply an external patchkit anyways you can as well apply the small patches for these hooks too. But it doesn't make sense to carry the (admittedly minor) overhead for this in all kernels. Also the ELF loader is quite hairy code and any simplification of it helps.

-Andi