remove broken MTD drivers
Subsystems (2)
PATCH 1/1 remove broken MTD drivers
This patch removes two MTD drivers that have been marked as BROKEN 19 months ago due to requiring nonexisting header files.
---
This patch has been sent on:
- 24 Oct 2007
drivers/mtd/nand/Kconfig | 12 drivers/mtd/nand/Makefile | 2 drivers/mtd/nand/ppchameleonevb.c | 439 ------------------------------ drivers/mtd/nand/toto.c | 208 -------------- 4 files changed, 661 deletions(-)
eb65564be12f427ae8a96a2ffa7e727a814e1129
drivers/mtd/nand/Kconfig +0 -12
@@ -69,12 +69,6 @@ config MTD_NAND_AMS_DELTA help Support for NAND flash on Amstrad E3 (Delta). -config MTD_NAND_TOTO - tristate "NAND Flash device on TOTO board" - depends on ARCH_OMAP && BROKEN - help - Support for NAND flash on Texas Instruments Toto platform. - config MTD_NAND_TS7250 tristate "NAND Flash device on TS-7250 board" depends on MACH_TS72XX
@@ -120,12 +114,6 @@ config MTD_NAND_RTC_FROM4 This enables the driver for the Renesas Technology AG-AND flash interface board (FROM_BOARD4) -config MTD_NAND_PPCHAMELEONEVB - tristate "NAND Flash device on PPChameleonEVB board" - depends on PPCHAMELEONEVB && BROKEN - help - This enables the NAND flash driver on the PPChameleon EVB Board. - config MTD_NAND_S3C2410 tristate "NAND Flash support for S3C2410/S3C2440 SoC" depends on ARCH_S3C2410
drivers/mtd/nand/Makefile +0 -2
@@ -9,12 +9,10 @@ obj-$(CONFIG_MTD_NAND_IDS) += nand_ids.o obj-$(CONFIG_MTD_NAND_CAFE) += cafe_nand.o obj-$(CONFIG_MTD_NAND_SPIA) += spia.o obj-$(CONFIG_MTD_NAND_AMS_DELTA) += ams-delta.o -obj-$(CONFIG_MTD_NAND_TOTO) += toto.o obj-$(CONFIG_MTD_NAND_AUTCPU12) += autcpu12.o obj-$(CONFIG_MTD_NAND_EDB7312) += edb7312.o obj-$(CONFIG_MTD_NAND_AU1550) += au1550nd.o obj-$(CONFIG_MTD_NAND_BF5XX) += bf5xx_nand.o -obj-$(CONFIG_MTD_NAND_PPCHAMELEONEVB) += ppchameleonevb.o obj-$(CONFIG_MTD_NAND_S3C2410) += s3c2410.o obj-$(CONFIG_MTD_NAND_DISKONCHIP) += diskonchip.o obj-$(CONFIG_MTD_NAND_H1900) += h1910.o
drivers/mtd/nand/ppchameleonevb.c deleted +0 -439
439 lines not on this page · raw message
drivers/mtd/nand/toto.c deleted +0 -208
208 lines not on this page · raw message
Quoted 4 lines · Adrian Bunk
This patch removes two MTD drivers that have been marked as BROKEN 19 months ago due to requiring nonexisting header files.
Signed-off-by Adrian Bunk <[email protected]>
Any particular reason you didn't Cc the authors identified in the drivers you're removing?
Signature · 1 line
dwmw2
Quoted 8 lines · David Woodhouse
Quoted 4 lines · Adrian Bunk
This patch removes two MTD drivers that have been marked as BROKEN 19 months ago due to requiring nonexisting header files.
Signed-off-by Adrian Bunk <[email protected]>Any particular reason you didn't Cc the authors identified in the drivers you're removing?
The header of ppchameleonevb.c claims it comes from [email protected] which bounces and the header of toto.c contains as only address Thomas' address (I took the wrong one from the commit, but bounced the email to him).
Quoted 1 line
dwmw2
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 2 lines · In message <[email protected]> you wrote:
The header of
ppchameleonevb.cclaims it comes from [email protected]
Argh. That's indeed ancient code.
So what should I do to fix this? Wait for Thomas' response, or port patches here?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] A Chairman was as necessary to a Board planet as the zero was in mathematics, but being a zero had big disadvantages... - Terry Pratchett, _The Dark Side of the Sun_
Quoted 8 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:
The header of
ppchameleonevb.cclaims it comes from [email protected]Argh. That's indeed ancient code.
So what should I do to fix this? Wait for Thomas' response, or port patches here?
I'd say post patches, and I'd expect David to actually be the one who reviews and incorporates them.
Quoted 3 lines
Best regards,
Wolfgang Denk
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedQuoted 2 lines · In message <[email protected]> you wrote:
This patch removes two MTD drivers that have been marked as BROKEN 19 months ago due to requiring nonexisting header files.
...
Quoted 3 lines
drivers/mtd/nand/Kconfig | 12 drivers/mtd/nand/Makefile | 2 drivers/mtd/nand/ppchameleonevb.c | 439 ------------------------------
It would have been nice if you had put the autors of the files on Cc:
Regarding the PPChameleon NAND support: I discussed this issue with tglx on 23 June 2006. Thomas promised to fix the driver if I send him the missing file and eventually needed patches.
I did so on Fri, 23 Jun 2006 23:23:42 +0200.
Thomas, can you please have a look at this?
If you don't have time / resources please let me know so we can submit the stuff here on the list...
Thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] "More software projects have gone awry for lack of calendar time than for all other causes combined." - Fred Brooks, Jr., _The Mythical Man Month_