Skip to contentSkip to conversation

#if 0 dma_async_memcpy_buf_to_buf()

PATCH In review Adrian Bunk 3 participants 3 messages Jan 1, 2008 – Jan 2, 2008 dmaengine

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 #if 0 dma_async_memcpy_buf_to_buf()

This patch #if 0's the unused dma_async_memcpy_buf_to_buf().

Signed-off-by Adrian Bunk <[email protected]>

---

This patch has been sent on:
- 14 Aug 2007

 drivers/dma/dmaengine.c   |    2 ++
 include/linux/dmaengine.h |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

b91933344bed48adf2b64ca0f98c45b92ef69b79

drivers/dma/dmaengine.c +2 -0
index 8248992..f0cda56 100644
@@ -459,6 +459,7 @@ void dma_async_device_unregister(struct dma_device *device)
 }
 EXPORT_SYMBOL(dma_async_device_unregister);
 
+#if 0
 /**
  * dma_async_memcpy_buf_to_buf - offloaded copy between virtual addresses
  * @chan: DMA channel to offload copy to

@@ -501,6 +502,7 @@ dma_async_memcpy_buf_to_buf(struct dma_chan *chan, void *dest,
 	return cookie;
 }
 EXPORT_SYMBOL(dma_async_memcpy_buf_to_buf);
+#endif  /*  0  */
 
 /**
  * dma_async_memcpy_buf_to_pg - offloaded copy from address to page
include/linux/dmaengine.h +0 -2
index a3b6035..75bdd65 100644
@@ -302,8 +302,6 @@ struct dma_device {
 void dma_async_client_register(struct dma_client *client);
 void dma_async_client_unregister(struct dma_client *client);
 void dma_async_client_chan_request(struct dma_client *client);
-dma_cookie_t dma_async_memcpy_buf_to_buf(struct dma_chan *chan,
-	void *dest, void *src, size_t len);
 dma_cookie_t dma_async_memcpy_buf_to_pg(struct dma_chan *chan,
 	struct page *page, unsigned int offset, void *kdata, size_t len);
 dma_cookie_t dma_async_memcpy_pg_to_pg(struct dma_chan *chan,
#2 lore raw
Quoted 9 lines

From: Alan Cox [mailto:[email protected]]
Sent: Tuesday, January 01, 2008 6:26 AM
To: Adrian Bunk
Cc: Nelson, Shannon; Williams, Dan J; [email protected]
Subject: Re: [2.6 patch] #if 0 dma_async_memcpy_buf_to_buf()

On Tue, 1 Jan 2008 15:49:24 +0200
Adrian Bunk <[email protected]> wrote:

Quoted 7 lines
Quoted 3 lines

This patch #if 0's the unused dma_async_memcpy_buf_to_buf().

Signed-off-by Adrian Bunk <[email protected]>

NAK. Yet again you are trying to remove bits of APIs in ways that make no sense.

Yes, this should be a NAK.

Thank you Alan.

sln