powerpc systbl.h broken
PATCH 1/1 powerpc systbl.h broken
Hi,
In current 2.6.23 (I have checked 2.6.23.12 and 2.6.23.9) the end of include/asm-powerpc/systbl.h reads:
--snip--SYSCALL_SPU(getcpu)COMPAT_SYS(epoll_pwait)COMPAT_SYS_SPU(utimensat)COMPAT_SYS(fallocate)COMPAT_SYS_SPU(signalfd)COMPAT_SYS_SPU(timerfd)SYSCALL_SPU(eventfd)COMPAT_SYS_SPU(sync_file_range2)
--snap--
This obviously does not match the definitions in asm-powerpc/unistd.h:
--snip--
#define __NR_getcpu 302
#define __NR_epoll_pwait 303
#define __NR_utimensat 304
#define __NR_signalfd 305
#define __NR_timerfd 306
#define __NR_eventfd 307
#define __NR_sync_file_range2 308
#define __NR_fallocate 309
--snap--
which breaks the system calls 305 to 309 inclusive.
I've attached the simple patch which fixes the problem.
yours,
- clifford
Signature · 2 lines
"Any sufficiently advanced technology is indistinguishable from magic." - Arthur C. Clarke
include/asm-powerpc/systbl.h renamed from include/asm-powerpc/systbl.h.orig +1 -1
@@ -308,8 +308,8 @@ SYSCALL_SPU(getcpu) COMPAT_SYS(epoll_pwait) COMPAT_SYS_SPU(utimensat) -COMPAT_SYS(fallocate) COMPAT_SYS_SPU(signalfd) COMPAT_SYS_SPU(timerfd) SYSCALL_SPU(eventfd) COMPAT_SYS_SPU(sync_file_range2) +COMPAT_SYS(fallocate)
Hi Clifford,
Thanks for the report.
PowerPC problems should be reported to [email protected].
This has been fixed in the current (approaching 2.6.24) kernel. It should be fixed in 2.6.23.xx, so I have cc'd this to [email protected] (and linuxppc-dev, of course).
(Also, please post patches inline, don't attach them. And you need to reply to this with a Signed-off-by: line.)
Signature · 48 lines
Cheers, Stephen Rothwell [email protected] ------------------------------------------------------------------------ From: Clifford Wolf <[email protected]> Hi, In current 2.6.23 (I have checked 2.6.23.12 and 2.6.23.9) the end of include/asm-powerpc/systbl.h reads: --snip-- SYSCALL_SPU(getcpu) COMPAT_SYS(epoll_pwait) COMPAT_SYS_SPU(utimensat) COMPAT_SYS(fallocate) COMPAT_SYS_SPU(signalfd) COMPAT_SYS_SPU(timerfd) SYSCALL_SPU(eventfd) COMPAT_SYS_SPU(sync_file_range2) --snap-- This obviously does not match the definitions in asm-powerpc/unistd.h: --snip-- #define __NR_getcpu 302 #define __NR_epoll_pwait 303 #define __NR_utimensat 304 #define __NR_signalfd 305 #define __NR_timerfd 306 #define __NR_eventfd 307 #define __NR_sync_file_range2 308 #define __NR_fallocate 309 --snap-- which breaks the system calls 305 to 309 inclusive. --- linux-2.6.23.12/include/asm-powerpc/systbl.h.orig 2008-01-02 15:09:04.000000000 +0100 +++ linux-2.6.23.12/include/asm-powerpc/systbl.h 2008-01-02 15:09:29.000000000 +0100 @@ -308,8 +308,8 @@ SYSCALL_SPU(getcpu) COMPAT_SYS(epoll_pwait) COMPAT_SYS_SPU(utimensat) -COMPAT_SYS(fallocate) COMPAT_SYS_SPU(signalfd) COMPAT_SYS_SPU(timerfd) SYSCALL_SPU(eventfd) COMPAT_SYS_SPU(sync_file_range2) +COMPAT_SYS(fallocate)
Quoted 4 lines · On Thu, 3 Jan 2008 13:16:24 +1100 Stephen Rothwell <[email protected]> wrote:
This has been fixed in the current (approaching 2.6.24) kernel. It should be fixed in 2.6.23.xx, so I have cc'd this to [email protected] (and linuxppc-dev, of course).
Should have been [email protected]. (where I have sent another copy of the email)
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/