x86: clean up apic_32/64.c
PATCH 1/1 x86: clean up apic_32/64.c
White space and coding style clean up.
Make apic_32/64.c similar.
--- arch/x86/kernel/apic_32.c | 5 ++--- arch/x86/kernel/apic_64.c | 23 +++++++++++++++++------ 2 files changed, 19 insertions(+), 9 deletions(-)
arch/x86/kernel/apic_32.c +2 -3
@@ -577,7 +577,6 @@ static void local_apic_timer_interrupt(void)* [ if a single-CPU system runs an SMP kernel then we call the local * interrupt as well. Thus we cannot inline the local irq ... ] */ -void smp_apic_timer_interrupt (struct pt_regs *regs) {struct pt_regs *old_regs =set_irq_regs (regs);
@@ -1021,7 +1020,7 @@ void __cpuinit setup_local_APIC(void)/* * Detect and initialize APIC */ -static int __init detect_init_APIC (void ) +static int __init detect_init_APIC (void ) {u32 h, l, features;
@@ -1165,7 +1164,7 @@ fake_ioapic_page:* This initializes the IO-APIC and APIC hardware if this is * a UP kernel. */ -int __init APIC_init_uniprocessor (void ) +int __init APIC_init_uniprocessor (void ) {if (enable_local_apic <0 )clear_cpu_cap (&boot_cpu_data,X86_FEATURE_APIC );
arch/x86/kernel/apic_64.c +17 -6
@@ -23,33 +23,37 @@#include <linux/mc146818rtc.h> #include <linux/kernel_stat.h> #include <linux/sysdev.h> -#include <linux/module.h> #include <linux/ioport.h> #include <linux/clockchips.h> #include <linux/acpi_pmtmr.h> +#include <linux/module.h> #include <asm/atomic.h> #include <asm/smp.h> #include <asm/mtrr.h> #include <asm/mpspec.h> +#include <asm/hpet.h> #include <asm/pgalloc.h> #include <asm/mach_apic.h> #include <asm/nmi.h> #include <asm/idle.h> #include <asm/proto.h> #include <asm/timex.h> -#include <asm/hpet.h> #include <asm/apic.h> -int apic_verbosity;int disable_apic_timer__cpuinitdata ;static int apic_calibrate_pmtmr__initdata ;int disable_apic; -/* Local APIC timer works in C2? */ +/* Local APIC timer works in C2 */ int local_apic_timer_c2_ok;EXPORT_SYMBOL_GPL (local_apic_timer_c2_ok); +/* +* Debug level, exported for io_apic.c +*/ +int apic_verbosity; +static struct resource lapic_resource = { .name ="Local APIC" , .flags =IORESOURCE_MEM |IORESOURCE_BUSY ,
@@ -355,6 +359,11 @@ static void __init calibrate_APIC_clock(void) calibration_result = result /HZ ; } +/* +* Setup the boot APIC +* +* Calibrate and verify the result. +*/ void __init setup_boot_APIC_clock (void ) {/*
@@ -1109,8 +1118,8 @@ static struct sysdev_class lapic_sysclass = { };static struct sys_device device_lapic = { - .id =0 , - .cls = &lapic_sysclass, + .id =0 , + .cls = &lapic_sysclass, };static void __cpuinit apic_pm_activate (void )
@@ -1121,9 +1130,11 @@ static void __cpuinit apic_pm_activate(void)static int __init init_lapic_sysfs (void ) {int error; +if (!cpu_has_apic)return 0 ;/* XXX: remove suspend/resume procs if !apic_pm_state.active? */ + error =sysdev_class_register (&lapic_sysclass);if (!error) error =sysdev_register (&device_lapic);
Signature · 1 line
1.5.3.6
Ingo Molnar
AppliedQuoted 1 line · Hiroshi Shimamoto
White space and coding style clean up. Make apic_32/64.c similar.
thanks, applied. FYI, there's still a bit left in apic_32.c:
total: 5 errors, 1 warnings, 1566 lines checked
we might as well go for all of them? :-)
Ingo
Quoted 9 lines · Ingo Molnar
Quoted 1 line · Hiroshi Shimamoto
White space and coding style clean up. Make apic_32/64.c similar.
thanks, applied. FYI, there's still a bit left in
apic_32.c:total: 5 errors, 1 warnings, 1566 lines checked
we might as well go for all of them? :-)
thanks, I made a clean up patch for it.
total: 0 errors, 0 warnings, 1567 lines checked
---
From: Hiroshi Shimamoto <[email protected]>
Subject: [PATCH] x86: clean up apic_32.c
White space and coding style clean up.
--- arch/x86/kernel/apic_32.c | 13 +++++++------ 1 files changed, 7 insertions(+), 6 deletions(-)
arch/x86/kernel/apic_32.c +7 -6
@@ -46,7 +46,7 @@/* * Sanity check */ -#if (SPURIOUS_APIC_VECTOR &0x0F ) !=0x0F +#if ((SPURIOUS_APIC_VECTOR &0x0F ) !=0x0F )# error SPURIOUS_APIC_VECTOR definition error#endif
@@ -55,7 +55,7 @@* * -1=force-disable, +1=force-enable */ -static int enable_local_apic__initdata =0 ; +static int enable_local_apic__initdata ;/* Local APIC timer verification ok */ static int local_apic_timer_verify_ok;
@@ -432,7 +432,7 @@ void __init setup_boot_APIC_clock(void)"with PM Timer: %ldms instead of 100ms\n" , (long)res);/* Correct the lapic counter value */ - res = (((u64 ) delta ) * pm_100ms); + res = (((u64 ) delta) * pm_100ms);do_div (res, deltapm);printk (KERN_INFO "APIC delta adjusted to PM-Timer: " "%lu (%ld)\n" , (unsigned long ) res, delta);
@@ -976,7 +976,8 @@ void __cpuinit setup_local_APIC(void) value |=APIC_LVT_LEVEL_TRIGGER ;apic_write_around (APIC_LVT1 , value); -if (integrated && !esr_disable) {/* !82489DX */ +if (integrated && !esr_disable) { +/* !82489DX */ maxlvt =lapic_get_maxlvt ();if (maxlvt >3 )/* Due to the Pentium erratum 3AP. */ apic_write (APIC_ESR ,0 );
@@ -1262,7 +1263,7 @@ void smp_error_interrupt(struct pt_regs *regs)6: Received illegal vector 7: Illegal register address */ -printk (KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n" , +printk (KERN_DEBUG "APIC error on CPU%d: %02lx(%02lx)\n" ,smp_processor_id (), v , v1);irq_exit (); }
@@ -1349,7 +1350,7 @@ void disconnect_bsp_APIC(int virt_wire_setup) value =apic_read (APIC_LVT0 ); value &= ~(APIC_MODE_MASK |APIC_SEND_PENDING |APIC_INPUT_POLARITY |APIC_LVT_REMOTE_IRR | -APIC_LVT_LEVEL_TRIGGER |APIC_LVT_MASKED ); +APIC_LVT_LEVEL_TRIGGER |APIC_LVT_MASKED ); value |=APIC_LVT_REMOTE_IRR |APIC_SEND_PENDING ; value =SET_APIC_DELIVERY_MODE (value,APIC_MODE_EXTINT );apic_write_around (APIC_LVT0 , value);
Signature · 1 line
1.5.3.6
Ingo Molnar
AppliedQuoted 4 lines · Hiroshi Shimamoto
From: Hiroshi Shimamoto <[email protected]>
Subject: [PATCH] x86: clean upapic_32.cWhite space and coding style clean up.
thanks, applied.
Ingo