Skip to contentSkip to conversation

Change a WARN message in checkpatch

PATCH New Paolo Ciarrocchi 1 participant 1 message Jan 4, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Change a WARN message in checkpatch

Hi Andy,
I just started using checkpatch and I was confused by the following WARN message:

no space between function name and open parenthesis

I thought the probelm was that a space was missing while the truth is the opposite.

How about the following patch?

checkpatch.pl renamed from checkpatch.pl.old +1 -1
@@ -1117,7 +1117,7 @@
 		while ($line =~ /($Ident)\s+\(/g) {
 			if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ &&
 		            $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) {
-				WARN("no space between function name and open parenthesis '('\n" . $herecurr);
+				WARN("don't put a space between function name and open parenthesis '('\n" . $herecurr);
 			}
 		}
 # Check operator spacing.