Skip to contentSkip to conversation

git-svn doesn't like !! in the url

PATCH In review Michael J. Cohen 3 participants 5 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

I think it needs to urlencode the items before it passes it back to the server.

W: Ignoring error from SVN, path probably does not exist: (175007): HTTP Path Not Found: REPORT request failed on '/wowace/!svn/bc/100/trunk/!!!LeaveMeAloneLibraries': '/wowace/!svn/bc/100/trunk/!!!LeaveMeAloneLibraries' path not found

works fine with svn co.

-mjc

#1 lore raw
Quoted 9 lines · Michael J. Cohen

I think it needs to urlencode the items before it passes it back to the server.

W: Ignoring error from SVN, path probably does not exist: (175007):
HTTP Path Not Found: REPORT request failed on '/wowace/!svn/bc/100/ trunk/!!!LeaveMeAloneLibraries': '/wowace/!svn/bc/100/trunk/!!! LeaveMeAloneLibraries' path not found

works fine with svn co.

Hi,

That was just a warning message (hence "W:"). If the path you're tracking did not have a revision between r0 - r100 in the repository; then it'll spew that warning once (it used to spew it a lot more).

git-svn looks at old history in chunks starting at the beginning of the repository to avoid pulling (potentially) hundreds of thousands of revisions + filenames into memory all at once.

As long as git-svn started importing revisions when the project started, everything should be alright.

I just dug up cfbe7ab333d68790eb37341e30f040f99cef6af7 and that should've escaped everything that needs to be urlencoded for HTTP(S). (you were also the one that noticed the need for that one, too :).

I also just noticed that changeset didn't make it into 1.5.3.7 nor maint, however...

Junio: if there are plans for 1.5.3.8, could you please add cfbe7ab333d68790eb37341e30f040f99cef6af7 to it? Thanks.

Signature · 1 line
Eric Wong
#2 lore raw

PATCH 1/1 git-svn: clarify the "Ignoring error from SVN" piece

I've heard of several users puzzled by this, and it sometimes it appears as if git-svn is doing nothing on slower connections and larger repositories.

---
 git-svn.perl |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
git-svn.perl +4 -0
index 2c97b05..3308fe1 100755
@@ -4085,6 +4085,10 @@ sub skip_unknown_revs {
 			warn "W: Ignoring error from SVN, path probably ",
 			     "does not exist: ($errno): ",
 			     $err->expanded_message,"\n";
+			warn "W: Do not be alarmed at the above message ",
+			     "git-svn is just searching aggressively for ",
+			     "old history.\n",
+			     "This may take a while on large repositories\n";
 			$ignored_err{$err_key} = 1;
 		}
 		return;
Signature · 1 line
Eric Wong
#3 lore raw

Re: [PATCH] git-svn: clarify the "Ignoring error from SVN" piece

Will apply to 'maint' ;-)

#4 lore raw
In reply to Eric Wong
Quoted 9 lines · Eric Wong

I just dug up cfbe7ab333d68790eb37341e30f040f99cef6af7 and that should've escaped everything that needs to be urlencoded for HTTP(S). (you were also the one that noticed the need for that one, too :).

I also just noticed that changeset didn't make it into 1.5.3.7 nor maint, however...

Junio: if there are plans for 1.5.3.8, could you please add cfbe7ab333d68790eb37341e30f040f99cef6af7 to it? Thanks.

Surely I can cherry pick that commit. Are you sure the test in it (t9118) does not depend on any other new features that appear on 'master'?