LVM on debian

I've just try for the first time grub2.

I'm on debian/unstable (grub2 version 1.95+20080105) I have only one thing to say. It's simply amazing ! I love it !

I have an lvm /usr partition. And everything works great.
I only have to look on /etc/grub.d/10_linux to see what was the variable for command line option of the kernel.

So I had to had GRUB_CMDLINE_LINUX on /etc/default/grub. I also have to edit /etc/grub.d/00_header because grub does not work if he cannot access to the font (that are on my /usr partition).

So I added "insmod
lvm" before font loading.

Thanks all for your work. Now I'm looking forward to the next upload of grub2 on debian to have TGA image support :-)

Hi Martin!

Quoted 5 lines · Martin Braure de Calignon

I've just try for the first time grub2.

I'm on debian/unstable (grub2 version 1.95+20080105) I have only one thing to say. It's simply amazing ! I love it !

Glad to hear that.

Quoted 3 lines

I have an lvm /usr partition. And everything works great.
I only have to look on /etc/grub.d/10_linux to see what was the variable for command line option of the kernel.

Yeah I'm afraid we lack documentation. We could use some help on that ;-)

Quoted 3 lines

So I had to had GRUB_CMDLINE_LINUX on /etc/default/grub. I also have to edit /etc/grub.d/00_header because grub does not work if he cannot access to the font (that are on my /usr partition).

There's something wrong here. update-grub is supposed to detect when your /usr is inaccessible and disable font automaticaly. You mean that it falls back to text mode, or that it won't install/boot at all?

Quoted 2 lines

Thanks all for your work. Now I'm looking forward to the next upload of grub2 on debian to have TGA image support :-)

I can't yet! I'm waiting for #459352

Quoted 5 lines · Robert Millan

Quoted 3 lines · Martin Braure de Calignon

I have an lvm /usr partition. And everything works great.
I only have to look on /etc/grub.d/10_linux to see what was the variable for command line option of the kernel.

Quoted 1 line

Yeah I'm afraid we lack documentation. We could use some help on that ;-)

Of course. One possible temporary solution would be to insert all customization variables in 10_linux and other files in /etc/default/grub with no value no and a simple comment over it (all the common used variables). I can try to do it if you want, but I've just discovered grub2 so it's quite risky.

Is it complicated to convert kopt= options in grub menu.lst to the GRUB_CMDLINE_LINUX ? in postinst ?

Of course. One possible temporary solution would be to insert all customization variables in 10_linux and other files in /etc/default/grub with no value no and a simple comment over it (all the common used variables).

Is it complicated to convert kopt= options in grub menu.lst to the GRUB_CMDLINE_LINUX ? in postinst ?

Quoted 3 lines

There's something wrong here. update-grub is supposed to detect when your /usr is inaccessible and disable font automaticaly. You mean that it falls back to text mode, or that it won't install/boot at all?

Well, when I tried, I had a graphical menu with no entry. I had to type 'ESC' and try to find what was wrong (that's where I discover insert lvm). If you wan't me to try again somes things, I can. I think it disable font but try to load graphic mode without font. Is it possible ?

Quoted 4 lines · Martin Braure de Calignon

Of course. One possible temporary solution would be to insert all customization variables in 10_linux and other files in /etc/default/grub with no value no and a simple comment over it (all the common used variables).

I don't like it. 10_linux is technicaly a config file, but it's also a script, which means it's much more likely to be updated (causing upgrade conflicts for those who modify it) than /etc/default/grub.

Also, /etc/default/grub is provided by debian, while 10_linux is not. We wouldn't want to put "GRUB_DISTRIBUTOR=Debian" in 10_linux would we ?

And not all variables in /etc/default/grub are meant for 10_linux. Some are there for 00_header. And even GRUB_DISTRIBUTOR is also used by 10_hurd.

Quoted 2 lines

Is it complicated to convert kopt= options in grub menu.lst to the GRUB_CMDLINE_LINUX ? in postinst ?

Maybe. It's basicaly just some sedding, but you have to be careful to get all the corner cases right. I didn't do it because I didn't consider it important, but feel free to send a patch.

Yes, but first I need to understand better what you saw. Does "graphical" mean it was in VESA mode? You can tell that because "terminal" command would return "gfxterm" rather than "console". Or does it simply mean you had a menu?
When you say "with no entry", does this mean you didn't see any text

(including the messages at the top and bottom)? Or just that there were no options in the menu?

Ok it makes sense to not include all the variables in /etc/default/grub because of course, /etc/default/grub should only contains variable that do not really depends on script. But a kernel command line personalization should be in there. If there's no default in there with non-valued variables, it should be documented.

Well, I think it can be important when you want grub2 to replace grub because people don't want their computer do not boot any longer (some options (noapictimer) missing can make my system unbootable). For now, it's probably not urgent.
A simple

	sed '/^# kopt=/!d;s/^# kopt=//g' /boot/grub/menu.lst

gives the kernel command line
Then one could use a "echo GRUB_CMD_LINE_LINUX=$(sed '/^# kopt=/!d;s/^# kopt=//g' /boot/grub/menu.lst) >> /etc/default/grub

It's probably not very robust,

so a better transitional solution could
be to ask in debconf for experimental importing of grub1 configuration. If not, one could also add these informations to README.Debian

I can try to do a patch for this, but I need some advices do not make common and obvious mistakes on how manage this conversion.

Quoted 5 lines

Yes, but first I need to understand better what you saw. Does "graphical" mean it was in VESA mode? You can tell that because "terminal" command would return "gfxterm" rather than "console". Or does it simply mean you had a menu?
When you say "with no entry", does this mean you didn't see any text

at all

Quoted 3 lines

(including the messages at the top and bottom)? Or just that there were no options in the menu?

I've just reinstall the default configuration files of grub2 and reboot. What I have is a black and white screen with "GNU GRub Version 1.95", then a menu without any entry and then the message on the bottom saying me that I can do some commands.

Then I go in 'command mode', do a insmod lvm, then configFile /boot/grub/grub.cfg and it works perfectly.

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

When you're in command mode, is "normal" module inserted? (use lsmod)

What happens if you don't insmod lvm and try configfile /boot/grub/grub.cfg directly?

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1

Quoted 6 lines · Martin Braure de Calignon

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1

Here is the problem ! Some command return error code, then the script is not parsed correctly. this problem can be fixed by my parser patch.

I think the most likely command to cause the error is

font (mainvg-usr)/share/grub/unicode.pff
or
terminal gfxterm

Quoted 5 lines · Bean

I think the most likely command to cause the error is

font (mainvg-usr)/share/grub/unicode.pff
or
terminal gfxterm

I think 'font' line can't work because font are on my /usr, and /usr is LVM and lvm module is not loaded... But I though grub2 know how to deals with it.
You're patch for the parser is on the cvs or svn or git (I don't know which one you use)

Quoted 5 lines · Bean

I think the most likely command to cause the error is

font (mainvg-usr)/share/grub/unicode.pff
or
terminal gfxterm

I think 'font' line can't work because font are on my /usr, and /usr is LVM and lvm module is not loaded... But I though grub2 know how to deals with it.

Quoted 5 lines · Bean

I think the most likely command to cause the error is

font (mainvg-usr)/share/grub/unicode.pff
or
terminal gfxterm

I think 'font' line can't work because font are on my /usr, and /usr is LVM and lvm module is not loaded... But I though grub2 know how to deals with it.

It's a bit funny. I tried to fix your problem, and at some point I realized I was fixing something else.

Quoted 3 lines · Robert Millan

It's a bit funny. I tried to fix your problem, and at some point I realized I was fixing something else.

Ok, so I fixed lvm/raid handling in core.img (by grub-install). This will help those who (unlike you) have their /boot under LVM or software RAID.

Please could someone test? (I'm CCing a few people who I heard have this problem)

Ok, so I fixed lvm/raid handling in core.img (by grub-install). This will help those who (unlike you) have their /boot under LVM or software RAID.

Quoted 2 lines · Robert Millan

Ok, so I fixed lvm/raid handling in core.img (by grub-install). This will help those who (unlike you) have their /boot under LVM or software RAID.

I applied both pathces, but lvm does not work for me yet. The second patch has

     +devtype_module=`$grub_probe --target=type --device-map=${device_map} ${grubdir}`

but my grub-probe patched against latest CVS does grok --target=type, it says

Try ``grub-probe --help'' for more information. -t, --target=(fs|drive|device|partmap)

Should I be pulling some git branch of yours?

When I replace the line above with

     +devtype_module=`$grub_probe --target=device --device-map=${device_map} ${grubdir}`

Try this one.

Quoted 1 line · Robert Millan

Try this one.

That's better, grub-install now does

   grub-mkimage --output=/tmp/boot/grub/core.img --prefix=/tmp/boot/grub ext2 lvm biosdisk _chain

I haven't tested yet, but this won't work, gpt (or pc?) is also needed, right?

I remember having seen

grub rescue> ls
(hd0) (hd1)

ie: no partitions when I tried without gpt/pc. I do not know how to recover from that from withing grub (cannot mount anything to insmod gpt/pc from).

grub-probe --target=partmap --device-map=/boot/grub/device.map /boot/grub
grub-probe: error: Cannot detect partition map for lvmraid-lvm1

Wait, do lvm devices actually contain a partition map?

If not, then this is
normal, although in this case grub-probe should tell you the partmap for
whatever physical partition contains the lvm data.

Quoted 1 line · Robert Millan

Wait, do lvm devices actually contain a partition map?

I don't think so. LVM devices have volume groups and logical volumes.

Quoted 4 lines

If not, then this is
normal, although in this case grub-probe should tell you the partmap for
whatever physical partition contains the lvm data.

Yes. Or at least grub-install should check if grub-probe reports an error when checking for the partmap and warn the user or insert gpt/pc.

Partition maps aren't really mandatory; much like lvm/raid.

Quoted 1 line · Robert Millan

Partition maps aren't really mandatory; much like lvm/raid.

Hmm, yes of course. But having one may save your day if booting fails and
you have useful non-lvm partitions. It is very useful if you can browse/use all your hdx,y if booting fails?

The problem with that is it can't really solve the problem, only provide a half-baked solution. If you include pc and gpt, you're misusing space in a component where it's really critical, and you still don't support all partitions GRUB might be installed on. For that, you'd have to load _all_ partition maps, which means even more space.

Quoted 5 lines · Robert Millan

The problem with that is it can't really solve the problem, only provide a half-baked solution. If you include pc and gpt, you're misusing space in a component where it's really critical, and you still don't support all partitions GRUB might be installed on. For that, you'd have to load _all_ partition maps, which means even more space.

I understand, and I've been wondering about this. As I do not have much if any knowledge for the sizing constraints of a bootloader, so I cannot appreciate the efforts of reducing space.

As a (blonde) user,

I would think that you'd want to use *as much*
rather than as little space you can. Why not (from a sizing pov, stability could be another issue), after core.img contains all necessary modules, fill up any `remaining' space (if that is how it works) with extra non-essential modules? Little harm in the ability to read more devices, I would say?

With your second patch, executing :

grub-probe --target=type /usr/share/grub/unicode.pff output :
lvm

So it seems to gives correct output (but I have only unicode.pff not unifont.pff)

So I think it's great :-)

    grub-mkimage --output=/boot/grub/core.img --prefix=/boot/grub ext2 lvm pc gpt biosdisk _chain
    grub-setup '(hd0)'

but that again gave me a grub rescue> prompt with exactly the same problems as before: error: unknown device, until I rmmod lvm, insmod lvm by hand

Quoted 1 line

    grub-mkimage --output=/boot/grub/core.img --prefix=/boot/grub ext2 lvm pc gpt biosdisk _chain

What happens if you change grub-mkimage parameter order? Put "lvm" as the last one.

Quoted 1 line · Robert Millan

Quoted 1 line

    grub-mkimage --output=/boot/grub/core.img --prefix=/boot/grub ext2 lvm pc gpt biosdisk _chain

Quoted 2 lines

What happens if you change grub-mkimage parameter order? Put "lvm" as the last one.

Yes, that's it. For the archives, this

    grub-mkimage --output=/boot/grub/core.img ext2 pc gpt biosdisk lvm

works for me. Thanks!

I reworked and cleaned up the patch a bit. Please, can you test this one?

Quoted 1 line · Robert Millan

I reworked and cleaned up the patch a bit. Please, can you test this one?

This has lvm after biosdisk, which looks ok.

    grub-mkimage --output=/boot/grub/core.img --prefix=/tmp/boot/grub ext2 biosdisk lvm _chain

Haven't boot-tested this yet, but should be ok.

Btw, I'm editing grub-install all the time to not really install, what about a --dry-run option? (patch against your version attached)

Quoted 7 lines · Jan Nieuwenhuizen

Quoted 4 lines · Robert Millan

Quoted 1 line

    grub-mkimage --output=/boot/grub/core.img --prefix=/boot/grub ext2 lvm pc gpt biosdisk _chain

What happens if you change grub-mkimage parameter order? Put "lvm" as the last one.

Quoted 5 lines

Yes, that's it. For the archives, this

    grub-mkimage --output=/boot/grub/core.img ext2 pc gpt biosdisk lvm

works for me. Thanks!

I reworked and cleaned up the patch a bit. Please, can you test this one?

/usr/lib/grub/update-grub_lib: line 103: probe: command not found Updating /boot/grub/grub.cfg ...
Found linux image: /boot/vmlinuz-2.6.23-1-amd64
Found initrd image: /boot/initrd.img-2.6.23-1-amd64 done

GRUB_PRELOAD_MODULES="`${GRUB_PRELOAD_MODULES} ${grub-probe} -t abstrac

on this line change ${grub-probe} ${grub_probe}

Quoted 4 lines · Martin Braure de Calignon

GRUB_PRELOAD_MODULES="`${GRUB_PRELOAD_MODULES} ${grub-probe} -t abstrac

on this line change ${grub-probe} ${grub_probe}

Thanks

Quoted 6 lines · Robert Millan

Quoted 4 lines · Martin Braure de Calignon

GRUB_PRELOAD_MODULES="`${GRUB_PRELOAD_MODULES} ${grub-probe} -t abstrac

on this line change ${grub-probe} ${grub_probe}

Quoted 1 line

Thanks

It didn't work because I only do a dpkg -i grub-pc_*.deb and the old conf-files still exists..
But I have removed all my /etc/grub.d/ then do a dpkg with --force-confmiss

Here's my grub.cfg in attachement. I don't see any insmod lvm :-/

(with modification in kern.c to insmod lvm on normal module loading)

There should be one. Can you find out why 00_header is not echoing it?

Quoted 1 line · Robert Millan

There should be one. Can you find out why 00_header is not echoing it?

because font_path is never called ?

New patch, a bit simpler (after giving it a though, I don't think the gained speed is worth the extra complication)

Signature · 34 lines

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)


	* include/grub/util/getroot.h (grub_dev_abstraction_types): New enum.
	(grub_util_get_dev_abstraction): New function prototype.

	* util/getroot.c: Include `<grub/util/getroot.h>'
	(grub_util_get_grub_dev): Move detection of abstraction type to ...
	(grub_util_get_dev_abstraction): ... here (new function).

	* util/grub-probe.c: Convert PRINT_* to an enum.  Add
	`PRINT_ABSTRACTION'.
	(probe): Probe for abstraction type when requested.
	(main): Understand `--target=abstraction'.

	* util/i386/efi/grub-install.in: Add abstraction module to core
	image when it is found to be necessary.
	* util/i386/pc/grub-install.in: Likewise.
	* util/powerpc/ieee1275/grub-install.in: Likewise.

	* util/update-grub_lib.in (font_path): Return system path without
	converting to GRUB path.
	* util/update-grub.in: Convert system path returned by font_path()
	to a GRUB path.  Use `grub-probe -t abstraction' to determine what
	abstraction module is needed for loading fonts (if any).  Export
	that as `GRUB_PRELOAD_MODULES'.
	* util/grub.d/00_header.in: Process `GRUB_PRELOAD_MODULES' (print
	insmod commands).

diff -x configure -x config.h.in -urp grub2/include/grub/util/getroot.h lvmraid/include/grub/util/getroot.h

include/grub/util/getroot.h +8 -1

@@ -1,6 +1,6 @@
 /*
  *  GRUB  --  GRand Unified Bootloader
- *  Copyright (C) 2003, 2007  Free Software Foundation, Inc.
+ *  Copyright (C) 2003, 2007, 2008  Free Software Foundation, Inc.
  *
  *  GRUB is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by

@@ -19,8 +19,15 @@
 #ifndef GRUB_UTIL_GETROOT_HEADER
 #define GRUB_UTIL_GETROOT_HEADER	1
 
+enum grub_dev_abstraction_types {
+  GRUB_DEV_ABSTRACTION_NONE,
+  GRUB_DEV_ABSTRACTION_LVM,
+  GRUB_DEV_ABSTRACTION_RAID,
+};
+
 char *grub_guess_root_device (const char *dir);
 char *grub_get_prefix (const char *dir);
+int grub_util_get_dev_abstraction (const char *os_dev);
 char *grub_util_get_grub_dev (const char *os_dev);
 
 #endif /* ! GRUB_UTIL_GETROOT_HEADER */

diff -x configure -x config.h.in -urp grub2/util/getroot.c lvmraid/util/getroot.c

util/getroot.c +33 -17

@@ -1,7 +1,7 @@
 /* getroot.c - Get root device */
 /*
  *  GRUB  --  GRand Unified Bootloader
- *  Copyright (C) 1999,2000,2001,2002,2003,2006,2007  Free Software Foundation, Inc.
+ *  Copyright (C) 1999,2000,2001,2002,2003,2006,2007,2008  Free Software Foundation, Inc.
  *
  *  GRUB is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by

@@ -24,6 +24,7 @@
 
 #include <grub/util/misc.h>
 #include <grub/util/biosdisk.h>
+#include <grub/util/getroot.h>
 
 static void
 strip_extra_slashes (char *dir)

@@ -239,27 +240,42 @@ grub_guess_root_device (const char *dir)
   return os_dev;
 }
 
-char *
-grub_util_get_grub_dev (const char *os_dev)
+int
+grub_util_get_dev_abstraction (const char *os_dev)
 {
   /* Check for LVM.  */
   if (!strncmp (os_dev, "/dev/mapper/", 12))
-    {
-      char *grub_dev = xmalloc (strlen (os_dev) - 12 + 1);
-
-      strcpy (grub_dev, os_dev+12);
-
-      return grub_dev;
-    }
+    return GRUB_DEV_ABSTRACTION_LVM;
 
   /* Check for RAID.  */
   if (!strncmp (os_dev, "/dev/md", 7))
+    return GRUB_DEV_ABSTRACTION_RAID;
+
+  /* No abstraction found.  */
+  return GRUB_DEV_ABSTRACTION_NONE;
+}
+
+char *
+grub_util_get_grub_dev (const char *os_dev)
+{
+  char *grub_dev;
+
+  switch (grub_util_get_dev_abstraction (os_dev))
     {
-      const char *p;
-      char *grub_dev = xmalloc (20);
+    case GRUB_DEV_ABSTRACTION_LVM:
+      grub_dev = xmalloc (strlen (os_dev) - 12 + 1);
+
+      strcpy (grub_dev, os_dev + 12);
+
+      break;
+
+    case GRUB_DEV_ABSTRACTION_RAID:
+      grub_dev = xmalloc (20);
 
       if (os_dev[7] == '_' && os_dev[8] == 'd')
 	{
+	  const char *p;
+
 	  /* This a partitionable RAID device of the form /dev/md_dNNpMM. */
 	  int i;
 

@@ -297,17 +313,17 @@ grub_util_get_grub_dev (const char *os_d
 	}
       else if (os_dev[7] >= '0' && os_dev[7] <= '9')
 	{
-	  p = os_dev + 5;
-	  memcpy (grub_dev, p, 7);
+	  memcpy (grub_dev, os_dev + 5, 7);
 	  grub_dev[7] = '\0';
 	}
       else
 	grub_util_error ("Unknown kind of RAID device `%s'", os_dev);
 
+      break;
 
-      return grub_dev;
+    default:  /* GRUB_DEV_ABSTRACTION_NONE */
+      grub_dev = grub_util_biosdisk_get_grub_dev (os_dev);
     }
 
-  /* If it's not RAID or LVM, it should be a biosdisk.  */
-  return grub_util_biosdisk_get_grub_dev (os_dev);
+  return grub_dev;
 }

diff -x configure -x config.h.in -urp grub2/util/grub.d/00_header.in lvmraid/util/grub.d/00_header.in

util/grub.d/00_header.in +7 -1

@@ -1,7 +1,7 @@
 #! /bin/sh -e
 
 # update-grub helper script.
-# Copyright (C) 2006,2007  Free Software Foundation, Inc.
+# Copyright (C) 2006,2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -24,6 +24,12 @@ platform=@platform@
 # for convert_system_path_to_grub_path()
 . ${libdir}/grub/update-grub_lib
 
+# Do this as early as possible, since other commands might depend on it.
+# (e.g. the `font' command might need lvm or raid modules)
+for i in ${GRUB_PRELOAD_MODULES} ; do
+  echo "insmod $i"
+done
+
 if [ "x${GRUB_DEFAULT}" = "x" ] ; then GRUB_DEFAULT=0 ; fi
 if [ "x${GRUB_TIMEOUT}" = "x" ] ; then GRUB_TIMEOUT=5 ; fi
 

diff -x configure -x config.h.in -urp grub2/util/grub-probe.c lvmraid/util/grub-probe.c

util/grub-probe.c +35 -7

@@ -1,7 +1,7 @@
 /* grub-probe.c - probe device information for a given path */
 /*
  *  GRUB  --  GRand Unified Bootloader
- *  Copyright (C) 2005,2006,2007 Free Software Foundation, Inc.
+ *  Copyright (C) 2005,2006,2007,2008 Free Software Foundation, Inc.
  *
  *  GRUB is free software: you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by

@@ -39,10 +39,13 @@
 #define _GNU_SOURCE	1
 #include <getopt.h>
 
-#define PRINT_FS	0
-#define PRINT_DRIVE	1
-#define PRINT_DEVICE	2
-#define PRINT_PARTMAP	3
+enum {
+  PRINT_FS,
+  PRINT_DRIVE,
+  PRINT_DEVICE,
+  PRINT_PARTMAP,
+  PRINT_ABSTRACTION,
+};
 
 int print = PRINT_FS;
 

@@ -74,6 +77,7 @@ probe (const char *path)
 {
   char *device_name;
   char *drive_name = NULL;
+  int abstraction_type;
   grub_device_t dev;
   grub_fs_t fs;
 

@@ -87,6 +91,28 @@ probe (const char *path)
       goto end;
     }
 
+  abstraction_type = grub_util_get_dev_abstraction (device_name);
+  /* No need to check for errors; lack of abstraction is permissible.  */
+  
+  if (print == PRINT_ABSTRACTION)
+    {
+      char *abstraction_name;
+      switch (abstraction_type)
+	{
+	case GRUB_DEV_ABSTRACTION_NONE:
+	  grub_util_info ("did not find LVM/RAID in %s, assuming raw device", device_name);
+	  goto end;
+	case GRUB_DEV_ABSTRACTION_LVM:
+	  abstraction_name = "lvm";
+	  break;
+	case GRUB_DEV_ABSTRACTION_RAID:
+	  abstraction_name = "raid";
+	  break;
+	}
+      printf ("%s\n", abstraction_name);
+      goto end;
+    }
+
   drive_name = grub_util_get_grub_dev (device_name);
   if (! drive_name)
     grub_util_error ("cannot find a GRUB drive for %s.\n", device_name);

@@ -159,8 +185,8 @@ Usage: grub-probe [OPTION]... PATH\n\
 Probe device information for a given path.\n\
 \n\
   -m, --device-map=FILE     use FILE as the device map [default=%s]\n\
-  -t, --target=(fs|drive|device|partmap)\n\
-                            print filesystem module, GRUB drive, system device or partition map module [default=fs]\n\
+  -t, --target=(fs|drive|device|partmap|abstraction)\n\
+                            print filesystem module, GRUB drive, system device, partition map module or abstraction module [default=fs]\n\
   -h, --help                display this message and exit\n\
   -V, --version             print version information and exit\n\
   -v, --verbose             print verbose messages\n\

@@ -206,6 +232,8 @@ main (int argc, char *argv[])
 	      print = PRINT_DEVICE;
 	    else if (!strcmp (optarg, "partmap"))
 	      print = PRINT_PARTMAP;
+	    else if (!strcmp (optarg, "abstraction"))
+	      print = PRINT_ABSTRACTION;
 	    else
 	      usage (1);
 	    break;

diff -x configure -x config.h.in -urp grub2/util/i386/efi/grub-install.in lvmraid/util/i386/efi/grub-install.in

util/i386/efi/grub-install.in +5 -2

@@ -1,7 +1,7 @@
 #! /bin/sh
 
 # Install GRUB on your EFI partition.
-# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007  Free Software Foundation, Inc.
+# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -190,8 +190,11 @@ fi
 # filesystem will be accessible).
 partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} 2> /dev/null`
 
+# Device abstraction module, if any (lvm, raid).
+devabstraction_module=`$grub_probe --target=abstraction --device-map=${device_map} ${grubdir}`
+
 # _chain is often useful
-modules="$modules $fs_module $partmap_module _chain"
+modules="$modules $fs_module $partmap_module $devabstraction_module _chain"
 
 $grub_mkimage --output=${grubdir}/grub.efi $modules || exit 1
 

diff -x configure -x config.h.in -urp grub2/util/i386/pc/grub-install.in lvmraid/util/i386/pc/grub-install.in

util/i386/pc/grub-install.in +5 -2

@@ -1,7 +1,7 @@
 #! /bin/sh
 
 # Install GRUB on your drive.
-# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007  Free Software Foundation, Inc.
+# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -223,8 +223,11 @@ fi
 # filesystem will be accessible).
 partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} 2> /dev/null`
 
+# Device abstraction module, if any (lvm, raid).
+devabstraction_module=`$grub_probe --target=abstraction --device-map=${device_map} ${grubdir}`
+
 # _chain is often useful
-modules="$modules $fs_module $partmap_module biosdisk _chain"
+modules="$modules $fs_module $partmap_module biosdisk $devabstraction_module _chain"
 
 $grub_mkimage --output=${grubdir}/core.img --prefix=`make_system_path_relative_to_its_root ${grubdir}` $modules || exit 1
 

diff -x configure -x config.h.in -urp grub2/util/powerpc/ieee1275/grub-install.in lvmraid/util/powerpc/ieee1275/grub-install.in

util/powerpc/ieee1275/grub-install.in +5 -2

@@ -1,7 +1,7 @@
 #! /bin/sh
 
 # Install GRUB on your drive.
-# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007  Free Software Foundation, Inc.
+# Copyright (C) 1999,2000,2001,2002,2003,2004,2005,2006,2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -176,7 +176,10 @@ fi
 # filesystem will be accessible).
 partmap_module=`$grub_probe --target=partmap --device-map=${device_map} ${grubdir} 2> /dev/null`
 
-modules="$modules $fs_module $partmap_module"
+# Device abstraction module, if any (lvm, raid).
+devabstraction_module=`$grub_probe --target=abstraction --device-map=${device_map} ${grubdir}`
+
+modules="$modules $fs_module $partmap_module $devabstraction_module"
 
 # Now perform the installation.
 "$grub_mkimage" --output=${grubdir}/grub $modules || exit 1

diff -x configure -x config.h.in -urp grub2/util/update-grub.in lvmraid/util/update-grub.in

util/update-grub.in +6 -3

@@ -1,7 +1,7 @@
 #! /bin/sh -e
 
 # Generate grub.cfg by inspecting /boot contents.
-# Copyright (C) 2006,2007  Free Software Foundation, Inc.
+# Copyright (C) 2006,2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -103,7 +103,10 @@ esac
 # check for terminals that require fonts
 case ${GRUB_TERMINAL} in
   gfxterm)
-    if GRUB_FONT_PATH=`font_path` ; then : ; else
+    if path=`font_path` ; then
+      GRUB_FONT_PATH="`convert_system_path_to_grub_path ${path}`"
+      GRUB_PRELOAD_MODULES="`${GRUB_PRELOAD_MODULES} ${grub_probe} -t abstraction ${path}`"
+    else
       # fallback to console
       GRUB_TERMINAL=console
     fi

@@ -121,7 +124,7 @@ esac
 
 # These are defined in this script, export them here so that user can
 # override them.
-export GRUB_DEVICE GRUB_FS GRUB_DRIVE GRUB_DRIVE_BOOT GRUB_DRIVE_BOOT_GRUB GRUB_FONT_PATH
+export GRUB_DEVICE GRUB_FS GRUB_DRIVE GRUB_DRIVE_BOOT GRUB_DRIVE_BOOT_GRUB GRUB_FONT_PATH GRUB_PRELOAD_MODULES
 
 # These are optional, user-defined variables.
 export GRUB_DEFAULT GRUB_TIMEOUT GRUB_DISTRIBUTOR GRUB_CMDLINE_LINUX GRUB_TERMINAL GRUB_SERIAL_COMMAND

diff -x configure -x config.h.in -urp grub2/util/update-grub_lib.in lvmraid/util/update-grub_lib.in

util/update-grub_lib.in +4 -9

@@ -1,5 +1,5 @@
 # Helper library for update-grub
-# Copyright (C) 2007  Free Software Foundation, Inc.
+# Copyright (C) 2007,2008  Free Software Foundation, Inc.
 #
 # GRUB is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by

@@ -93,19 +93,14 @@ convert_system_path_to_grub_path ()
 
 font_path ()
 {
-  if [ "x${GRUB_FONT_PATH}" = "x" ] ; then : ; else
-    echo "${GRUB_FONT_PATH}"
-    return 0
-  fi
-
   # Prefer system path for space reasons (/boot/grub might be a very small
   # partition in case of OpenFirmware, etc).
   for dir in ${pkgdatadir} /usr/share/grub /boot/grub ; do
     # Prefer complete fonts over incomplete ones.
     for basename in unicode unifont ascii ; do
-      if path=`convert_system_path_to_grub_path ${dir}/${basename}.pff` ; then
-        GRUB_FONT_PATH="${path}"
-        echo "${GRUB_FONT_PATH}"
+      path="${dir}/${basename}.pff"
+      if convert_system_path_to_grub_path ${path} > /dev/null ; then
+        echo "${path}"
         return 0
       fi
     done

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

New patch, a bit simpler (after giving it a though, I don't think the gained speed is worth the extra complication)

Quoted 2 lines · Robert Millan

New patch, a bit simpler (after giving it a though, I don't think the gained speed is worth the extra complication)

What does this patch fix? Too many problems in one thread...

BTW, does it also work for the case both LVM and RAID are used?

Quoted 6 lines · Marco Gerards

Quoted 2 lines · Robert Millan

New patch, a bit simpler (after giving it a though, I don't think the gained speed is worth the extra complication)

What does this patch fix? Too many problems in one thread...

It fixes loading of lvm/raid modules in two situations:

- In core.img, by grub-install, when they're needed to access /boot. This is still not enough to get it working due to another bug (detection of partmap).

- In grub.cfg, by update-grub, when they're needed to access /usr for the font file.

Quoted 1 line

BTW, does it also work for the case both LVM and RAID are used?

No, for that we need to handle recursion in grub-probe, which is the same we'll need to get partmap detection working on lvm/raid.

Quoted 14 lines · Robert Millan

Quoted 6 lines · Marco Gerards

Quoted 2 lines · Robert Millan

New patch, a bit simpler (after giving it a though, I don't think the gained speed is worth the extra complication)

What does this patch fix? Too many problems in one thread...

It fixes loading of lvm/raid modules in two situations:

- In core.img, by grub-install, when they're needed to access /boot. This is still not enough to get it working due to another bug (detection of partmap).

Quoted 2 lines

- In grub.cfg, by update-grub, when they're needed to access /usr for the font file.

Oh, great. Why can't this font be put in /boot/grub? Using /usr can mean we need: raid, lvm, fshelp, a fs and a partitioning scheme module in addition to what we need to access /boot.

Quoted 4 lines

Quoted 1 line

BTW, does it also work for the case both LVM and RAID are used?

No, for that we need to handle recursion in grub-probe, which is the same we'll need to get partmap detection working on lvm/raid.

You are working on this?

Or is this bug documented?

The remaining known problem is detecting partmap; I'll probably find time to do that one too, but I'll need to know how can one obtain a machine-parseable list of physical devices that conform an LVM virtual device (and the same for software RAID).

grub-probe /usr
ext2

Is it normal ?

Quoted 2 lines

grub-probe /usr
ext2

and not lvm :-/

It's a bit funny. I tried to fix your problem, and at some point I realized I was fixing something else. Then got back at your problem, and turned out we just need to force load of "lvm" and "raid" before entering normal mode.

Quoted 3 lines · Robert Millan

It's a bit funny. I tried to fix your problem, and at some point I realized I was fixing something else. Then got back at your problem, and turned out we just need to force load of "lvm" and "raid" before entering normal mode.

Ah, but this looks promising form my lvm in core bug too, I'll give it a test.

Quoted 11 lines · Martin Braure de Calignon

Quoted 5 lines · Bean

I think the most likely command to cause the error is

font (mainvg-usr)/share/grub/unicode.pff
or
terminal gfxterm

I think 'font' line can't work because font are on my /usr, and /usr is LVM and lvm module is not loaded... But I though grub2 know how to deals with it.

It's a bit funny. I tried to fix your problem, and at some point I realized I was fixing something else. Then got back at your problem, and turned out we just need to force load of "lvm" and "raid" before entering normal mode.

Please try attached patch and report (note: this is unrelated to the parser error Bean fixed; the parser error simply makes the real problem in your setup go away unnoticed).

Quoted 4 lines

Please try attached patch and report (note: this is unrelated to the parser error Bean fixed; the parser error simply makes the real problem in your setup go away unnoticed).

my previous post was for this patch testing

Quoted 6 lines · Martin Braure de Calignon

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1

Here is the problem ! Some command return error code, then the script is not parsed correctly. this problem can be fixed by my parser patch.

Quoted 5 lines · Bean

Quoted 4 lines · Martin Braure de Calignon

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

Quoted 5 lines

Quoted 2 lines

set gives the following output :
?=1

Here is the problem ! Some command return error code, then the script is not parsed correctly. this problem can be fixed by my parser patch.

Ugh.. I forgot about that one. Will you check it in soon?

Quoted 10 lines · Robert Millan

Quoted 8 lines · Bean

Quoted 6 lines · Martin Braure de Calignon

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1

Quoted 4 lines

Quoted 2 lines

Here is the problem ! Some command return error code, then the script is not parsed correctly. this problem can be fixed by my parser patch.

Ugh.. I forgot about that one. Will you check it in soon?

should i wait for macro to check it first ?

Quoted 14 lines · Bean

Quoted 13 lines · Robert Millan

Quoted 10 lines · Bean

Quoted 6 lines · Martin Braure de Calignon

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1

Here is the problem ! Some command return error code, then the script is not parsed correctly. this problem can be fixed by my parser patch.

Quoted 3 lines

Quoted 1 line

Ugh.. I forgot about that one. Will you check it in soon?

should i wait for macro to check it first ?

I don't know. You can try mailing him directly.

Anyway, if you did something wrong we can always revert it.

Quoted 2 lines · Robert Millan

Ok, so you have fonts. What are the color settings? (run "set" and check for menu_color_* variables)

set gives the following output :
?=1
color_highlight=
color_normal=
default=0
prefix=(hd0,9)/boot/grub
root=(hd0,9)

so no menu_color* variables

Quoted 1 line

When you're in command mode, is "normal" module inserted? (use lsmod)

yes it is (modules loaded are : font, normal, _chain, biosdisk, pc, ext2 and fshelp)

Quoted 2 lines

What happens if you don't insmod lvm and try configfile /boot/grub/grub.cfg directly?

It try to load it, then it seems it can't, because I'm again on the same black & white menu.

Does your empty menu look exactly like this one?

http://aybabtu.com/tmp/screenshot.png

Quoted 4 lines · Robert Millan

Does your empty menu look exactly like this one?

http://aybabtu.com/tmp/screenshot.png

Not exactly, it looks like this one, but I have a rectangular zone and a highlighted blank line where the menu should be

Quoted 4 lines · Robert Millan

Does your empty menu look exactly like this one?

http://aybabtu.com/tmp/screenshot.png

Not exactly, it looks like this one, but I have a rectangular zone and a highlighted blank line where the menu should be