clean up use of ia64 tool chain check scripts --resent
RFC PATCH 1/1 clean up use of ia64 tool chain check scripts --resent
Hello list,
ia64 seems to be the only one that use arch specific scripts to check tool chain bugs that create the dependency on ia64 cross tool chain that make the command : make ARCH=ia64 olconfig failed if ia64 cross tool chain is __not__ installed or OBJDUMP and CC is __not__ set with correct path on a non-ia64 box. Given the current state of art of the tool chain, I don't know if these checks are still useful. Please consider the following patch.
Thanks,
Luming
clean up use of ia64 tool chain check scripts
--
Makefile | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
arch/ia64/Makefile renamed from arch/ia64/Makefile.orig +1 -10
@@ -28,16 +28,7 @@ -falign-functions2 -frename-registers -fno-optimize-sibling-calls CFLAGS_KERNEL := -mconstant-gp -GAS_STATUS = $(shell $(srctree)/arch/ia64/scripts/check-gas "$(CC)" "$(OBJDUMP)") -CPPFLAGS += $(shell $(srctree)/arch/ia64/scripts/toolchain-flags "$(CC)" "$(OBJDUMP)" "$(READELF)") - -ifeq ($(GAS_STATUS),buggy) -$(error Sorry, you need a newer version of the assember, one that is built from \ - a source-tree that post-dates 18-Dec-2002. You can find a pre-compiled \ - static binary of such an assembler at: \ - \ - ftp://ftp.hpl.hp.com/pub/linux-ia64/gas-030124.tar.gz) -endif +CPPFLAGS += -DHAVE_WORKING_TEXT_ALIGN -DHAVE_MODEL_SMALL_ATTRIBUTE -DHAVE_SERIALIZE_DIRECTIVE ifeq ($(call cc-version),0304) cflags-$(CONFIG_ITANIUM) += -mtune=merced
-GAS_STATUS = $(shell $(srctree)/arch/ia64/scripts/check-gas "$(CC)" "$(OBJDUMP)")
-CPPFLAGS += $(shell $(srctree)/arch/ia64/scripts/toolchain-flags "$(CC)" "$(OBJDUMP)" "$(READELF)")
If we delete these calls from the Makefile, then should we also delete the scripts themselves (and the test programs that they use) from arch/ia64/scripts?
+CPPFLAGS += -DHAVE_WORKING_TEXT_ALIGN -DHAVE_MODEL_SMALL_ATTRIBUTE -DHAVE_SERIALIZE_DIRECTIVE
and if we are going to just unconditionally set these defines, perhaps we should clean the #ifdef'd code out of the source tree so we can remove this clutter from the Makefile too?
It all sounds good to me ... but I'll wait a few more days in case somebody who knows better is still on their winter holiday break. [This is 2.6.25 cleanup material anyway, so waiting is not an issue]
-Tony
Re: [RFC PATCH] clean up use of ia64 tool chain check scripts
In reply to Luming YuLuming Yu wrote: [Thu Dec 20 2007, 09:20:53AM EST]
Quoted 3 lines
make ARCH=ia64 olconfig failed if ia64 cross
tool chain is__not__installed or OBJDUMP and CC is__not__set with correct path on a non-ia64 box
Hey Luming, this has always bothered me. Thanks for fixing it!
Aron