Skip to contentSkip to conversation

enable built-in networking for Sequoia defconfig

PATCH Applied Hollis Blanchard 4 participants 8 messages Jan 4, 2008 – Jan 9, 2008 PowerPC

lore
Share & tools
lore

Hollis Blanchard

author
#0 lore raw

PATCH 1/1 enable built-in networking for Sequoia defconfig

Enable EMAC driver for Sequoia (and while we're in there, disable Macintosh drivers for Sequoia and Bamboo).

Signed-off-by Hollis Blanchard <[email protected]>
arch/powerpc/configs/bamboo_defconfig +1 -3
@@ -372,9 +372,7 @@ CONFIG_MISC_DEVICES=y
 # CONFIG_FIREWIRE is not set
 # CONFIG_IEEE1394 is not set
 # CONFIG_I2O is not set
-CONFIG_MACINTOSH_DRIVERS=y
-# CONFIG_MAC_EMUMOUSEBTN is not set
-# CONFIG_WINDFARM is not set
+# CONFIG_MACINTOSH_DRIVERS is not set
 CONFIG_NETDEVICES=y
 # CONFIG_NETDEVICES_MULTIQUEUE is not set
 # CONFIG_DUMMY is not set
arch/powerpc/configs/sequoia_defconfig +20 -4
@@ -446,9 +446,7 @@ CONFIG_MISC_DEVICES=y
 # CONFIG_FIREWIRE is not set
 # CONFIG_IEEE1394 is not set
 # CONFIG_I2O is not set
-CONFIG_MACINTOSH_DRIVERS=y
-# CONFIG_MAC_EMUMOUSEBTN is not set
-# CONFIG_WINDFARM is not set
+# CONFIG_MACINTOSH_DRIVERS is not set
 CONFIG_NETDEVICES=y
 # CONFIG_NETDEVICES_MULTIQUEUE is not set
 # CONFIG_DUMMY is not set

@@ -459,10 +457,28 @@ CONFIG_NETDEVICES=y
 # CONFIG_VETH is not set
 # CONFIG_IP1000 is not set
 # CONFIG_ARCNET is not set
-# CONFIG_NET_ETHERNET is not set
+# CONFIG_PHYLIB is not set
+CONFIG_NET_ETHERNET=y
+# CONFIG_MII is not set
+# CONFIG_HAPPYMEAL is not set
+# CONFIG_SUNGEM is not set
+# CONFIG_CASSINI is not set
+# CONFIG_NET_VENDOR_3COM is not set
+# CONFIG_NET_TULIP is not set
+# CONFIG_HP100 is not set
+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
+# CONFIG_IBM_NEW_EMAC_DEBUG is not set
 CONFIG_IBM_NEW_EMAC_ZMII=y
 CONFIG_IBM_NEW_EMAC_RGMII=y
+# CONFIG_IBM_NEW_EMAC_TAH is not set
 CONFIG_IBM_NEW_EMAC_EMAC4=y
+# CONFIG_NET_PCI is not set
+# CONFIG_B44 is not set
 CONFIG_NETDEV_1000=y
 # CONFIG_ACENIC is not set
 # CONFIG_DL2K is not set
#2 lore raw

Josh,

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

BTW, is it normal to edit the defconfig file by hand?
I cannot get CONFIG_IBM_NEW_EMAC enabled through Kconfig. Am I missing something:

a) Patch to enable IBM_NEW_EMAC via Kconfig is welcome
b) Matthias only knows only half the truth.

Matthias

Quoted 17 lines · Josh Boyer
Quoted 4 lines · On Fri, 04 Jan 2008 17:26:54 -0600 Hollis Blanchard <[email protected]> wrote:

Enable EMAC driver for Sequoia (and while we're in there, disable Macintosh drivers for Sequoia and Bamboo).

Signed-off-by Hollis Blanchard <[email protected]>

applied, thanks.

josh
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

#3 lore raw
Quoted 3 lines · On Wed, 9 Jan 2008 12:16:25 +0100 Matthias Fuchs…

Josh,

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

I applied it there, just haven't pushed it out yet. Will do that today.

Quoted 1 line

BTW, is it normal to edit the defconfig file by hand?

The defconfig? Not sure. What I normally do is a make foo_defconfig, edit the .config, make oldconfig, and copy the resulting .config back to foo_defconfig.

josh

#4 lore raw
Quoted 7 lines · Josh Boyer
Quoted 3 lines · On Wed, 9 Jan 2008 12:16:25 +0100 Matthias Fuchs…

Josh,

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

Quoted 7 lines

I applied it there, just haven't pushed it out yet. Will do that today.

Quoted 1 line

BTW, is it normal to edit the defconfig file by hand?

The defconfig? Not sure. What I normally do is a make foo_defconfig, edit the .config, make oldconfig, and copy the resulting .config back to foo_defconfig.

Yes, this is what I also do.

But how did Hollis get these lines into .config or sequoia_defconfig:

+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0

I did not find any Kconfigs where these might come from.

Any hint?

Matthias

#5 lore raw
Quoted 15 lines · Matthias Fuchs
Quoted 3 lines

The defconfig? Not sure. What I normally do is a make foo_defconfig, edit the .config, make oldconfig, and copy the resulting .config back to foo_defconfig.

Yes, this is what I also do.

But how did Hollis get these lines into .config or sequoia_defconfig:

(quoted diff) +6 -0
+CONFIG_IBM_NEW_EMAC=3Dy
+CONFIG_IBM_NEW_EMAC_RXB=3D128
+CONFIG_IBM_NEW_EMAC_TXB=3D64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=3D32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=3D256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=3D0
Quoted 1 line

I did not find any Kconfigs where these might come from.

Take a look at drivers/net/ibm_newemac/Kconfig.

Viele Gr=FC=DFe,
Stefan

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

#6 lore raw
In reply to Matthias Fuchs
Quoted 26 lines · On Wed, 9 Jan 2008 15:42:38 +0100 Matthias Fuchs…
Quoted 7 lines · Josh Boyer
Quoted 3 lines · On Wed, 9 Jan 2008 12:16:25 +0100 Matthias Fuchs…

Josh,

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

Quoted 7 lines

I applied it there, just haven't pushed it out yet. Will do that today.

Quoted 1 line

BTW, is it normal to edit the defconfig file by hand?

The defconfig? Not sure. What I normally do is a make foo_defconfig, edit the .config, make oldconfig, and copy the resulting .config back to foo_defconfig.

Yes, this is what I also do.

But how did Hollis get these lines into .config or sequoia_defconfig:

arch/powerpc/configs/sequoia_defconfig +6 -0
+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
Quoted 1 line

I did not find any Kconfigs where these might come from.

They're in drivers/net/ibm_newemac/Kconfig.

josh

#7 lore raw

Thanks,

Sorry, I must have been blind.

Matthias

Quoted 36 lines · Josh Boyer
Quoted 26 lines · On Wed, 9 Jan 2008 15:42:38 +0100 Matthias Fuchs…
Quoted 7 lines · Josh Boyer
Quoted 3 lines · On Wed, 9 Jan 2008 12:16:25 +0100 Matthias Fuchs…

Josh,

Where did you apply this patch to? Couldn't find it in your for-2.6.25 branch.

Quoted 7 lines

I applied it there, just haven't pushed it out yet. Will do that today.

Quoted 1 line

BTW, is it normal to edit the defconfig file by hand?

The defconfig? Not sure. What I normally do is a make foo_defconfig, edit the .config, make oldconfig, and copy the resulting .config back to foo_defconfig.

Yes, this is what I also do.

But how did Hollis get these lines into .config or sequoia_defconfig:

arch/powerpc/configs/sequoia_defconfig +6 -0
+CONFIG_IBM_NEW_EMAC=y
+CONFIG_IBM_NEW_EMAC_RXB=128
+CONFIG_IBM_NEW_EMAC_TXB=64
+CONFIG_IBM_NEW_EMAC_POLL_WEIGHT=32
+CONFIG_IBM_NEW_EMAC_RX_COPY_THRESHOLD=256
+CONFIG_IBM_NEW_EMAC_RX_SKB_HEADROOM=0
Quoted 1 line

I did not find any Kconfigs where these might come from.

They're in drivers/net/ibm_newemac/Kconfig.

josh