Skip to contentSkip to conversation

: nested VLAN: fix lockdep's recursive locking warning

VLAN Applied Patrick McHardy 2 participants 2 messages Jan 10, 2008 – Jan 11, 2008

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Patrick McHardy

author
#0 lore raw

[VLAN]: nested VLAN: fix lockdep's recursive locking warning

Allow vlans nesting other vlans without lockdep's warnings (max. 2 levels i.e. parent + child). Thanks to Patrick McHardy for pointing a bug in the first version of this patch.

Reported-by Benny Amorsen
Signed-off-by Jarek Poplawski <[email protected]>
Signed-off-by Patrick McHardy <[email protected]>

---
commit 4d14fded63dcaf9d5dcf78e2a8ea3f5de2c29eb9
tree 2f0792e8240151b1e5437b05130d1f569175f572
parent e2474f60798c97f5c05d29a906045dd1f416ba7f
author Jarek Poplawski <[email protected]> Thu, 10 Jan 2008 16:25:00 +0100 committer Patrick McHardy <[email protected]> Thu, 10 Jan 2008 16:25:00 +0100

 net/8021q/vlan.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
net/8021q/vlan.c +6 -1
index 4add9bd..032bf44 100644
@@ -323,6 +323,7 @@ static const struct header_ops vlan_header_ops = {
 static int vlan_dev_init(struct net_device *dev)
 {
 	struct net_device *real_dev = VLAN_DEV_INFO(dev)->real_dev;
+	int subclass = 0;
 
 	/* IFF_BROADCAST|IFF_MULTICAST; ??? */
 	dev->flags  = real_dev->flags & ~IFF_UP;

@@ -349,7 +350,11 @@ static int vlan_dev_init(struct net_device *dev)
 		dev->hard_start_xmit = vlan_dev_hard_start_xmit;
 	}
 
-	lockdep_set_class(&dev->_xmit_lock, &vlan_netdev_xmit_lock_key);
+	if (real_dev->priv_flags & IFF_802_1Q_VLAN)
+		subclass = 1;
+
+	lockdep_set_class_and_subclass(&dev->_xmit_lock,
+				&vlan_netdev_xmit_lock_key, subclass);
 	return 0;
 }
maintainer Applied
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Thu, 10 Jan 2008 16:32:35 +0100

Quoted 10 lines

[VLAN]: nested VLAN: fix lockdep's recursive locking warning

Allow vlans nesting other vlans without lockdep's warnings (max. 2 levels i.e. parent + child). Thanks to Patrick McHardy for pointing a bug in the first version of this patch.

Reported-by Benny Amorsen
Signed-off-by Jarek Poplawski <[email protected]>
Signed-off-by Patrick McHardy <[email protected]>

Applied, thanks.