Please pull coldfire tree
Wolfgang,
The following changes since commit ce37422d0002e10490e268392e0c4e3028e52cec:
Stefan Roese (1):
cfi_flash: Fix bug in flash_isset() to use correct 32bit
function
are available in the git repository at:
git://www.denx.de/git/u-boot-coldfire.git
TsiChungLiew (7):
Coldfire: Update immap files for 5445x and 532x
ColdFire: MCF5445x - PCI, cache and misc update
ColdFire: MCF532x - Update FlexBus CS
ColdFire: Add M5373EVB Platform support
ColdFire: Fixed CFI low level Read/Write macro
ColdFire: Add new coldfire cpu 5227x family and 52277evb platform
ColdFire: Add mcf547x_8x cpu arch and two platforms - M5475EVB and
M5485EVB
CREDITS | 2 +- MAINTAINERS | 4 + MAKEALL | 6 +- Makefile | 84 ++ README | 2 + board/freescale/m52277evb/Makefile | 44 + board/freescale/m52277evb/config.mk | 25 + board/freescale/m52277evb/m52277evb.c | 86 ++ board/freescale/m52277evb/u-boot.lds | 145 ++ board/freescale/m5329evb/nand.c | 4 +- board/freescale/m5373evb/Makefile | 44 + board/freescale/m5373evb/config.mk | 25 + board/freescale/m5373evb/m5373evb.c | 88 ++ board/freescale/m5373evb/mii.c | 306 +++++ board/freescale/m5373evb/nand.c | 114 ++ board/freescale/m5373evb/u-boot.lds | 144 ++ board/freescale/m547xevb/Makefile | 44 + board/freescale/m547xevb/config.mk | 25 + board/freescale/m547xevb/m547xevb.c | 115 ++ board/freescale/m547xevb/mii.c | 322 +++++ board/freescale/m547xevb/u-boot.lds | 143 ++ board/freescale/m548xevb/Makefile | 44 + board/freescale/m548xevb/config.mk | 25 + board/freescale/m548xevb/m548xevb.c | 115 ++ board/freescale/m548xevb/mii.c | 322 +++++ board/freescale/m548xevb/u-boot.lds | 143 ++ cpu/mcf5227x/Makefile | 48 + cpu/mcf5227x/config.mk | 31 + cpu/mcf5227x/cpu.c | 75 + cpu/mcf5227x/cpu_init.c | 146 ++ cpu/mcf5227x/interrupts.c | 52 + cpu/mcf5227x/lcd.c | 372 +++++ cpu/mcf5227x/speed.c | 120 ++ cpu/mcf5227x/start.S | 356 +++++ cpu/mcf532x/cpu.c | 20 +- cpu/mcf5445x/cpu_init.c | 1 - cpu/mcf5445x/pci.c | 69 +- cpu/mcf5445x/start.S | 27 +- cpu/mcf547x_8x/Makefile | 48 + cpu/mcf547x_8x/config.mk | 31 + cpu/mcf547x_8x/cpu.c | 143 ++ cpu/mcf547x_8x/cpu_init.c | 132 ++ cpu/mcf547x_8x/interrupts.c | 50 + cpu/mcf547x_8x/pci.c | 171 +++ cpu/mcf547x_8x/slicetimer.c | 132 ++ cpu/mcf547x_8x/speed.c | 43 + cpu/mcf547x_8x/start.S | 361 +++++ doc/README.m52277evb | 237 ++++ doc/README.m5373evb | 334 +++++ doc/README.m5475evb | 279 ++++ drivers/dma/MCD_dmaApi.c | 1023 ++++++++++++++ drivers/dma/MCD_tasks.c | 2427 +++++++++++++++++++++++++++++++++ drivers/dma/MCD_tasksInit.c | 240 ++++ drivers/dma/Makefile | 46 + drivers/net/Makefile | 1 + drivers/net/fsl_mcdmafec.c | 582 ++++++++ drivers/pci/pci_auto.c | 6 + drivers/usb/usb_ohci.c | 1 + include/MCD_dma.h | 386 ++++++ include/MCD_progCheck.h | 27 + include/MCD_tasksInit.h | 60 + include/asm-m68k/crossbar.h | 79 ++ include/asm-m68k/dspi.h | 156 +++ include/asm-m68k/edma.h | 177 +++ include/asm-m68k/fec.h | 7 +- include/asm-m68k/flexbus.h | 98 ++ include/asm-m68k/fsl_mcdmafec.h | 167 +++ include/asm-m68k/global_data.h | 47 +- include/asm-m68k/immap.h | 145 ++- include/asm-m68k/immap_5227x.h | 343 +++++ include/asm-m68k/immap_5329.h | 340 ++---- include/asm-m68k/immap_5445x.h | 901 ++++--------- include/asm-m68k/immap_547x_8x.h | 297 ++++ include/asm-m68k/io.h | 22 +- include/asm-m68k/lcd.h | 213 +++ include/asm-m68k/m5227x.h | 796 +++++++++++ include/asm-m68k/m5329.h | 286 +---- include/asm-m68k/m5445x.h | 316 +----- include/asm-m68k/m547x_8x.h | 503 +++++++ include/asm-m68k/ssi.h | 175 +++ include/configs/M52277EVB.h | 251 ++++ include/configs/M5329EVB.h | 12 +- include/configs/M5373EVB.h | 267 ++++ include/configs/M54455EVB.h | 11 +- include/configs/M5475EVB.h | 311 +++++ include/configs/M5485EVB.h | 296 ++++ lib_m68k/board.c | 10 + net/eth.c | 4 + 88 files changed, 15108 insertions(+), 1620 deletions(-)
Dear John,
Quoted 11 lines · in message <[email protected]> you wrote:
The following changes since commit
ce37422d0002e10490e268392e0c4e3028e52cec:
Stefan Roese (1):
cfi_flash: Fix bug inflash_isset()to use correct 32bit
functionare available in the git repository at:
git://www.denx.de/git/u-boot-coldfire.git
Quoted 8 lines
TsiChungLiew (7):
Coldfire: Update immap files for 5445x and 532x
ColdFire: MCF5445x - PCI, cache and misc update
ColdFire: MCF532x - Update FlexBus CS
ColdFire: Add M5373EVB Platform support
ColdFire: Fixed CFI low level Read/Write macro
ColdFire: Add new coldfire cpu 5227x family and 52277evb platform
ColdFire: Addmcf547x_8xcpu arch and two platforms - M5475EVB and
Sorry, but this is not how it's supposed to work.
Your repository contains a lot of patches that have never been posted on the mailing list before. Especially changes that affect global files like the ones marked below *must* be reviewed on the list *before* you send a pull request.
...
Quoted 1 line
Makefile | 84 ++
^^^^^^^^^^^^
...
Quoted 1 line
drivers/pci/pci_auto.c | 6 +
^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 1 line
drivers/usb/usb_ohci.c | 1 +
^^^^^^^^^^^^^^^^^^^^^^^^^^
Pull request rejected. Sorry.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Einstein argued that there must be simplified explanations of nature, because God is not capricious or arbitrary. No such faith comforts the software engineer. - Fred Brooks, Jr.
Wolfgang,
Sorry, I knew that and assumed Tsi-chung had submitted the patches to the list. Up until this point I have just been Tsi-chung's git monkey. I will pay more attention in the future to make sure this does not happen again.
John
Quoted 59 lines · Wolfgang Denk
Dear John,
Quoted 11 lines · in message <[email protected]> you wrote:
The following changes since commit
ce37422d0002e10490e268392e0c4e3028e52cec:
Stefan Roese (1):
cfi_flash: Fix bug inflash_isset()to use correct 32bit
functionare available in the git repository at:
git://www.denx.de/git/u-boot-coldfire.gitQuoted 8 lines
TsiChungLiew (7):
Coldfire: Update immap files for 5445x and 532x
ColdFire: MCF5445x - PCI, cache and misc update
ColdFire: MCF532x - Update FlexBus CS
ColdFire: Add M5373EVB Platform support
ColdFire: Fixed CFI low level Read/Write macro
ColdFire: Add new coldfire cpu 5227x family and 52277evb platform
ColdFire: Addmcf547x_8xcpu arch and two platforms - M5475EVBand
Sorry, but this is not how it's supposed to work.
Your repository contains a lot of patches that have never been posted on the mailing list before. Especially changes that affect global files like the ones marked below *must* be reviewed on the list *before* you send a pull request.
...
Quoted 1 line
Makefile | 84 ++^^^^^^^^^^^^
...Quoted 1 line
drivers/pci/pci_auto.c | 6 +^^^^^^^^^^^^^^^^^^^^^^^^^^
Quoted 1 line
drivers/usb/usb_ohci.c | 1 +^^^^^^^^^^^^^^^^^^^^^^^^^^
Pull request rejected. Sorry.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Einstein argued that there must be simplified explanations of nature, because God is not capricious or arbitrary. No such faith comforts
the software engineer. - Fred Brooks, Jr.-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
Quoted 6 lines
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.denx.de/pipermail/u-boot/attachments/20080109/d1ed696e/attachment.htm
Wolfgang and all u-boot users,
Quoted 7 lines
Your repository contains a lot of patches that have never been
posted on the mailing list before. Especially changes that affect
global files like the ones marked below *must* be reviewed on the > list *before* you send a pull request.Makefile | 84 ++ drivers/pci/pci_auto.c | 6 + drivers/usb/usb_ohci.c | 1 +
The changes to the makefile (same as README, MAKEALL, etc) is that we have four new platforms added - M5373EVB, M52277EVB, M5475EVB and M5485EVB. Also, added a dma folder under drivers. (libdma.a in Makefile as well.) M5475EVB and M5485EVB use DMA for FEC transfer (same as Alaska8220)
There is no general routine to skip pci host bridge in pci_auto.c, so added CONFIG_SKIPPCI_HOSTBRIDGE to bypass the host bridge. Affected platforms - M54455EVB, M5475EVB, M5485EVB and Alaska8220 if patch is not applied.
M5475EVB has Philips 1561 PCI-USB OHCI host controller, just added its PCI Vendor ID and Device ID so that the usb ohci drivers able to recognize and configure the driver probably.
Originally, I thought the merge is going to close tomorrow. I did it in a rush without posted on the mailing list. Until you sent out an email today about extend the window til 17. And, sorry to hear about the network problem at your home.
These patches do not affect globally, except files in dma that need to add #ifdef ... #endif in each .c file.
Regards,
TsiChung
Dear Tsi Chung,
Quoted 5 lines · in message <4791E710007FEB4BBF83775D787F462F05CC6132@az33exm22.fsl.freescale.ne…
Quoted 3 lines
Your repository contains a lot of patches that have never been posted on the mailing list before. Especially changes that affect global files like the ones marked below *must* be reviewed on the >
list *before* you send a pull request.
Quoted 7 lines
Quoted 3 lines
Makefile | 84 ++ drivers/pci/pci_auto.c | 6 + drivers/usb/usb_ohci.c | 1 +The changes to the makefile (same as README, MAKEALL, etc) is that we have four new platforms added - M5373EVB, M52277EVB, M5475EVB and M5485EVB. Also, added a dma folder under drivers. (libdma.a in
Makefile
Yes, but you did not add simple targets, but complicated multi-line script stuff. Are you sure that would have passed a review uncommented? I am not so sure...
Quoted 4 lines
There is no general routine to skip pci host bridge in
pci_auto.c, so addedCONFIG_SKIPPCI_HOSTBRIDGEto bypass the host bridge. Affected platforms - M54455EVB, M5475EVB, M5485EVB and Alaska8220 if patch is not applied.
No matter how obvious this seems to be to you, the rule is that ALL changes shall be posted for review on the mailing list *before* they go into the public tree, i. e. before the custodian calls for a pull.
Quoted 2 lines
Originally, I thought the merge is going to close tomorrow. I did it in a rush without posted on the mailing list. Until you sent out an email
This is no excuse. If the deadline is close, you miss that merge window. Period. You must always post your patches, and you must give the people on the mailing list sufficient time to review your changes.
Quoted 2 lines
today about extend the window til 17. And, sorry to hear about the network problem at your home.
Heh, that's solved for now, and in less than one week we'll have a new provider. Bye Telekom!
Quoted 2 lines
These patches do not affect globally, except files in dma that need to add #ifdef ... #endif in each .c file.
I disagree. You do change global files, and I probably will object against some of the changes, and others might have to say a word or two, too.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de G's Third Law: In spite of all evidence to the contra- ry, the entire universe is composed of only two basic substances: magic and bullshit. H's Dictum: There is no magic ...