Driver 'sd' needs updating

DISCUSSION Nick Warne 3 participants 5 messages Jan 10, 2008 SCSI

lore

Share & tools

lore

Nick Warne

author

2008-01-10 08:52 UTC #0 lore raw

Hi everybody - Happy New Year to you all!

OK, updated to git rc7 yesterday - I now see this in syslog:

"Driver 'sd' needs updating - please use bus_type methods"

The warning never appeared in RC6, and all google reveals are other peoples logs that are posted about other issues.

Do I need to fix up something here?

Thanks,

Nick

Signature · 1 line

Free Software Foundation Associate Member 5508

FUJITA Tomonori

2008-01-10 11:39 UTC #1 lore raw

CC'ed linux-scsi and James,

Quoted 11 lines · On Thu, 10 Jan 2008 08:51:50 +0000 Nick Warne <[email protected]> wrote:

Hi everybody - Happy New Year to you all!
OK, updated to git rc7 yesterday - I now see this in syslog:
"Driver 'sd' needs updating - please use bus_type methods"
The warning never appeared in RC6, and all google reveals are other peoples logs that are posted about other issues.
Do I need to fix up something here?

No, you don't. It's harmless, a side effect of:

commit 751bf4d7865e4ced406be93b04c7436d866d3684

Author: James Bottomley <[email protected]>
Date:   Wed Jan 2 11:14:30 2008 -0600

[SCSI] scsi_sysfs: restore prep_fn when ULD is removed

It would be better to silence this warning.

James, we need to reset prep_fn in each ULD? though it's not nice...

Nick Warne

author

2008-01-10 17:41 UTC #2 lore raw

Quoted 7 lines · On Thu, 10 Jan 2008 20:38:45 +0900 FUJITA Tomonori…

Quoted 6 lines
"Driver 'sd' needs updating - please use bus_type methods"
The warning never appeared in RC6, and all google reveals are other peoples logs that are posted about other issues.
Do I need to fix up something here?

Quoted 7 lines

No, you don't. It's harmless, a side effect of:
commit 751bf4d7865e4ced406be93b04c7436d866d3684
Author: James Bottomley <[email protected]>
Date:   Wed Jan 2 11:14:30 2008 -0600
[SCSI] scsi_sysfs: restore prep_fn when ULD is removed

Ah, I see. Thanks for clarification.

Nick

Signature · 1 line

Free Software Foundation Associate Member 5508

James Bottomley

maintainer

2008-01-10 18:27 UTC #3 lore raw

In reply to FUJITA Tomonori

Quoted 23 lines · FUJITA Tomonori

CC'ed linux-scsi and James,
Quoted 11 lines · On Thu, 10 Jan 2008 08:51:50 +0000 Nick Warne <[email protected]> wrote:
Hi everybody - Happy New Year to you all!
OK, updated to git rc7 yesterday - I now see this in syslog:
"Driver 'sd' needs updating - please use bus_type methods"
The warning never appeared in RC6, and all google reveals are other peoples logs that are posted about other issues.
Do I need to fix up something here?
No, you don't. It's harmless, a side effect of:
commit 751bf4d7865e4ced406be93b04c7436d866d3684
Author: James Bottomley <[email protected]>
Date:   Wed Jan 2 11:14:30 2008 -0600

Quoted 6 lines

[SCSI] scsi_sysfs: restore prep_fn when ULD is removed
It would be better to silence this warning.
James, we need to reset prep_fn in each ULD? though it's not nice...

Really not nice ... to the extent that we shouldn't do it. The reset is in exactly the correct place currently. If we make it a requirement of the ULDs its duplication and someone is bound to forget.

It looks like the problem is the warning in base/driver.c:driver_register() apparently it wants an either/or for ->remove methods (either bus type or driver). We're actually using the bus_type methods, but we also have a driver component, sigh. I suppose what it's wanting is for me to add a scsi_driver type with remove methods ... which looks a bit silly since all of the SCSI drivers want different remove methods.

James

Nick Warne

author

2008-01-10 18:51 UTC #4 lore raw

Quoted 24 lines · On Thu, 10 Jan 2008 12:27:22 -0600 James Bottomley…

Quoted 1 line
Quoted 1 line
OK, updated to git rc7 yesterday - I now see this in syslog:
"Driver 'sd' needs updating - please use bus_type methods"
Quoted 8 lines
Quoted 1 line
Do I need to fix up something here?
No, you don't. It's harmless, a side effect of:
commit 751bf4d7865e4ced406be93b04c7436d866d3684
Author: James Bottomley <[email protected]>
Date:   Wed Jan 2 11:14:30 2008 -0600
Quoted 6 lines
[SCSI] scsi_sysfs: restore prep_fn when ULD is removed
It would be better to silence this warning.
James, we need to reset prep_fn in each ULD? though it's not nice...
Really not nice ... to the extent that we shouldn't do it. The reset is in exactly the correct place currently. If we make it a requirement of the ULDs its duplication and someone is bound to forget.

Quoted 7 lines

It looks like the problem is the warning in base/driver.c:driver_register() apparently it wants an either/or for ->remove methods (either bus type or driver). We're actually using the bus_type methods, but we also have a driver component, sigh. I suppose what it's wanting is for me to add a scsi_driver type with remove methods ... which looks a bit silly since all of the SCSI drivers want different remove methods.

OK, actually, this is wierd for me now. Is this warning ONLY generated on modules?

I build with no modules, but do have modules enabled due to nVidia. I did post about a module called 'scsi_wait' being built, even though I didn't want it/need it but can't stop it - please refer:

http://marc.info/?t=119705493500007&r=1&w=2

If this is true, what I have now is a module being built I don't want/need and can't stop it being built, and a warning about it not using bus_type methods anyway.

Nick

Signature · 1 line

Free Software Foundation Associate Member 5508