blkparse extensions for PC requests
cover blkparse extensions for PC requests
As a follow-up to the blktrace extension for SCSI generic device files, here are two patches that extend the tracing of PC requests in blkparse. When tracing I/O to SCSI tape drives, the I/O trace only contains PC requests. These extensions allow to get some more data from these traces.
Signature · 1 line
Christof Schmitt
Quoted 5 lines · Christof Schmitt
As a follow-up to the blktrace extension for SCSI generic device files, here are two patches that extend the tracing of PC requests in blkparse. When tracing I/O to SCSI tape drives, the I/O trace only contains PC requests. These extensions allow to get some more data from these traces.
Patches look fine, however should it just not default do this accounting? But only print the status fields, if we actually saw a PC request.
Signature · 1 line
Jens Axboe
Quoted 3 lines · Jens Axboe
Patches look fine, however should it just not default do this accounting? But only print the status fields, if we actually saw a PC request.
My intent was to not change the data shown in the current summary output. But you are right, it makes more sense to simply output the PC summary when a PC request has been seen. I will post an updated patch that does this without the --pc flag.
Christof Schmitt
Quoted 9 lines · Christof Schmitt
Quoted 3 lines · Jens Axboe
Patches look fine, however should it just not default do this accounting? But only print the status fields, if we actually saw a PC request.
My intent was to not change the data shown in the current summary output. But you are right, it makes more sense to simply output the PC summary when a PC request has been seen. I will post an updated patch that does this without the --pc flag.
Yep I think so. If you send a patch that does that, I'll apply it.
Signature · 1 line
Jens Axboe