Skip to contentSkip to conversation

libsas: fix sense_buffer overrun

PATCH In review FUJITA Tomonori 2 participants 2 messages Jan 12, 2008 – Jan 14, 2008

Subsystems (2)
SCSI SCSI libsas
lore
Share & tools
lore

FUJITA Tomonori

author
#0 lore raw

PATCH 1/1 libsas: fix sense_buffer overrun

Signed-off-by FUJITA Tomonori <[email protected]>
---
 drivers/scsi/libsas/sas_scsi_host.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/libsas/sas_scsi_host.c +1 -1
index b784089..828fed1 100644
@@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
 			break;
 		case SAM_CHECK_COND:
 			memcpy(sc->sense_buffer, ts->buf,
-			       max(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
+			       min(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
 			stat = SAM_CHECK_COND;
 			break;
 		default:
Signature · 1 line
1.5.3.4
Acked-by on v1 1/1
#1 lore raw

Looks sane to me;

Acked-by Darrick J. Wong <[email protected]>

--D

Quoted 26 lines · FUJITA Tomonori
Signed-off-by FUJITA Tomonori <[email protected]>
---
 drivers/scsi/libsas/sas_scsi_host.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/libsas/sas_scsi_host.c +1 -1
index b784089..828fed1 100644
@@ -108,7 +108,7 @@ static void sas_scsi_task_done(struct sas_task *task)
 			break;
 		case SAM_CHECK_COND:
 			memcpy(sc->sense_buffer, ts->buf,
-			       max(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
+			       min(SCSI_SENSE_BUFFERSIZE, ts->buf_valid_size));
 			stat = SAM_CHECK_COND;
 			break;
 		default:
Signature · 6 lines
1.5.3.4

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html